* [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency
@ 2017-03-17 16:36 Fathi Boudra
2017-03-17 16:36 ` [morty-next][PATCH 2/2] kselftests: fix seccomp test build failure Fathi Boudra
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Fathi Boudra @ 2017-03-17 16:36 UTC (permalink / raw)
To: meta-ti
libpcap-ng is required to build capabilities tests.
Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
---
recipes-kernel/kselftests/kselftests_4.9.bb | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb b/recipes-kernel/kselftests/kselftests_4.9.bb
index a7b4ba67..dd94a65b 100644
--- a/recipes-kernel/kselftests/kselftests_4.9.bb
+++ b/recipes-kernel/kselftests/kselftests_4.9.bb
@@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-DEPENDS = "libcap popt rsync-native"
+DEPENDS = "libcap libcap-ng popt rsync-native"
inherit kernel-arch
@@ -139,8 +139,6 @@ FILES_${PN}-x86 = "${bindir}/kselftests/x86"
FILES_${PN}-zram = "${bindir}/kselftests/zram"
FILES_${PN}-dbg += "${bindir}/kselftests/*/.debug"
-ALLOW_EMPTY_${PN}-capabilities = "1"
-
RDEPENDS_${PN}-cpu-hotplug += "bash"
RDEPENDS_${PN}-efivarfs += "bash"
RDEPENDS_${PN}-memory-hotplug += "bash"
--
2.11.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [morty-next][PATCH 2/2] kselftests: fix seccomp test build failure 2017-03-17 16:36 [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency Fathi Boudra @ 2017-03-17 16:36 ` Fathi Boudra 2017-03-17 16:47 ` [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency Khem Raj 2017-03-17 17:04 ` Denys Dmytriyenko 2 siblings, 0 replies; 15+ messages in thread From: Fathi Boudra @ 2017-03-17 16:36 UTC (permalink / raw) To: meta-ti Use the same fixup as used for timers test: use LDLIBS to properly link against libpthread. Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> --- recipes-kernel/kselftests/kselftests_4.9.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb b/recipes-kernel/kselftests/kselftests_4.9.bb index dd94a65b..3cd12ea6 100644 --- a/recipes-kernel/kselftests/kselftests_4.9.bb +++ b/recipes-kernel/kselftests/kselftests_4.9.bb @@ -59,6 +59,7 @@ do_configure () { sed "s|^CC = .*||g" -i ${S}/tools/testing/selftests/memfd/Makefile sed "s|^CC := .*||g" -i ${S}/tools/testing/selftests/powerpc/switch_endian/Makefile sed "s|gcc|\$(CC)|g" -i ${S}/tools/testing/selftests/breakpoints/Makefile + sed "s|^LDFLAGS += -lpthread|LDLIBS += -lpthread|g" -i ${S}/tools/testing/selftests/seccomp/Makefile sed "s|^LDFLAGS += -lrt -lpthread|LDLIBS += -lrt -lpthread|g" -i ${S}/tools/testing/selftests/timers/Makefile sed "s|BINARIES|TEST_PROGS|g" -i ${S}/tools/testing/selftests/sigaltstack/Makefile } -- 2.11.0 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 16:36 [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency Fathi Boudra 2017-03-17 16:36 ` [morty-next][PATCH 2/2] kselftests: fix seccomp test build failure Fathi Boudra @ 2017-03-17 16:47 ` Khem Raj 2017-03-17 16:59 ` Denys Dmytriyenko 2017-03-17 17:04 ` Denys Dmytriyenko 2 siblings, 1 reply; 15+ messages in thread From: Khem Raj @ 2017-03-17 16:47 UTC (permalink / raw) To: Fathi Boudra, meta-ti [-- Attachment #1: Type: text/plain, Size: 1346 bytes --] On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org> wrote: > libpcap-ng is required to build capabilities tests. > > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > --- > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb > b/recipes-kernel/kselftests/kselftests_4.9.bb > index a7b4ba67..dd94a65b 100644 > --- a/recipes-kernel/kselftests/kselftests_4.9.bb > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" > > PACKAGE_ARCH = "${MACHINE_ARCH}" > > -DEPENDS = "libcap popt rsync-native" > +DEPENDS = "libcap libcap-ng popt rsync-native" Would ng replace old libcap > > > inherit kernel-arch > > @@ -139,8 +139,6 @@ FILES_${PN}-x86 = "${bindir}/kselftests/x86" > FILES_${PN}-zram = "${bindir}/kselftests/zram" > FILES_${PN}-dbg += "${bindir}/kselftests/*/.debug" > > -ALLOW_EMPTY_${PN}-capabilities = "1" > - > RDEPENDS_${PN}-cpu-hotplug += "bash" > RDEPENDS_${PN}-efivarfs += "bash" > RDEPENDS_${PN}-memory-hotplug += "bash" > -- > 2.11.0 > > -- > _______________________________________________ > meta-ti mailing list > meta-ti@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-ti > [-- Attachment #2: Type: text/html, Size: 3291 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 16:47 ` [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency Khem Raj @ 2017-03-17 16:59 ` Denys Dmytriyenko 2017-03-17 17:03 ` Fathi Boudra 0 siblings, 1 reply; 15+ messages in thread From: Denys Dmytriyenko @ 2017-03-17 16:59 UTC (permalink / raw) To: Khem Raj; +Cc: meta-ti On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote: > On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org> > wrote: > > > libpcap-ng is required to build capabilities tests. > > > > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > > --- > > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb > > b/recipes-kernel/kselftests/kselftests_4.9.bb > > index a7b4ba67..dd94a65b 100644 > > --- a/recipes-kernel/kselftests/kselftests_4.9.bb > > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb > > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" > > > > PACKAGE_ARCH = "${MACHINE_ARCH}" > > > > -DEPENDS = "libcap popt rsync-native" > > +DEPENDS = "libcap libcap-ng popt rsync-native" > > > Would ng replace old libcap Are you asking in general or in this particular case? kselftests-capabilities does use libcap-ng and includes cap-ng.h header file, as I mentioned here: https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html Fathi's fix is indeed better, even though adding another dependency. > > inherit kernel-arch > > > > @@ -139,8 +139,6 @@ FILES_${PN}-x86 = "${bindir}/kselftests/x86" > > FILES_${PN}-zram = "${bindir}/kselftests/zram" > > FILES_${PN}-dbg += "${bindir}/kselftests/*/.debug" > > > > -ALLOW_EMPTY_${PN}-capabilities = "1" > > - > > RDEPENDS_${PN}-cpu-hotplug += "bash" > > RDEPENDS_${PN}-efivarfs += "bash" > > RDEPENDS_${PN}-memory-hotplug += "bash" > > -- > > 2.11.0 > > > > -- > > _______________________________________________ > > meta-ti mailing list > > meta-ti@yoctoproject.org > > https://lists.yoctoproject.org/listinfo/meta-ti > > > -- > _______________________________________________ > meta-ti mailing list > meta-ti@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-ti ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 16:59 ` Denys Dmytriyenko @ 2017-03-17 17:03 ` Fathi Boudra 2017-03-17 17:06 ` Denys Dmytriyenko 0 siblings, 1 reply; 15+ messages in thread From: Fathi Boudra @ 2017-03-17 17:03 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-ti On 17 March 2017 at 18:59, Denys Dmytriyenko <denis@denix.org> wrote: > On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote: >> On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org> >> wrote: >> >> > libpcap-ng is required to build capabilities tests. >> > >> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >> > --- >> > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- >> > 1 file changed, 1 insertion(+), 3 deletions(-) >> > >> > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb >> > b/recipes-kernel/kselftests/kselftests_4.9.bb >> > index a7b4ba67..dd94a65b 100644 >> > --- a/recipes-kernel/kselftests/kselftests_4.9.bb >> > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb >> > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" >> > >> > PACKAGE_ARCH = "${MACHINE_ARCH}" >> > >> > -DEPENDS = "libcap popt rsync-native" >> > +DEPENDS = "libcap libcap-ng popt rsync-native" >> >> >> Would ng replace old libcap > > Are you asking in general or in this particular case? > > kselftests-capabilities does use libcap-ng and includes cap-ng.h header file, > as I mentioned here: > https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html > > Fathi's fix is indeed better, even though adding another dependency. In this particular case, it doesn't replace libcap. Upstream managed to use libcap-ng in capabilities test and libpcap in bpf test... I'm currently queuing patches for upstream. >> > inherit kernel-arch >> > >> > @@ -139,8 +139,6 @@ FILES_${PN}-x86 = "${bindir}/kselftests/x86" >> > FILES_${PN}-zram = "${bindir}/kselftests/zram" >> > FILES_${PN}-dbg += "${bindir}/kselftests/*/.debug" >> > >> > -ALLOW_EMPTY_${PN}-capabilities = "1" >> > - >> > RDEPENDS_${PN}-cpu-hotplug += "bash" >> > RDEPENDS_${PN}-efivarfs += "bash" >> > RDEPENDS_${PN}-memory-hotplug += "bash" >> > -- >> > 2.11.0 >> > >> > -- >> > _______________________________________________ >> > meta-ti mailing list >> > meta-ti@yoctoproject.org >> > https://lists.yoctoproject.org/listinfo/meta-ti >> > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 17:03 ` Fathi Boudra @ 2017-03-17 17:06 ` Denys Dmytriyenko 2017-03-17 17:14 ` Fathi Boudra 0 siblings, 1 reply; 15+ messages in thread From: Denys Dmytriyenko @ 2017-03-17 17:06 UTC (permalink / raw) To: Fathi Boudra; +Cc: meta-ti On Fri, Mar 17, 2017 at 07:03:55PM +0200, Fathi Boudra wrote: > On 17 March 2017 at 18:59, Denys Dmytriyenko <denis@denix.org> wrote: > > On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote: > >> On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org> > >> wrote: > >> > >> > libpcap-ng is required to build capabilities tests. > >> > > >> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > >> > --- > >> > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- > >> > 1 file changed, 1 insertion(+), 3 deletions(-) > >> > > >> > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb > >> > b/recipes-kernel/kselftests/kselftests_4.9.bb > >> > index a7b4ba67..dd94a65b 100644 > >> > --- a/recipes-kernel/kselftests/kselftests_4.9.bb > >> > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb > >> > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" > >> > > >> > PACKAGE_ARCH = "${MACHINE_ARCH}" > >> > > >> > -DEPENDS = "libcap popt rsync-native" > >> > +DEPENDS = "libcap libcap-ng popt rsync-native" > >> > >> > >> Would ng replace old libcap > > > > Are you asking in general or in this particular case? > > > > kselftests-capabilities does use libcap-ng and includes cap-ng.h header file, > > as I mentioned here: > > https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html > > > > Fathi's fix is indeed better, even though adding another dependency. > > In this particular case, it doesn't replace libcap. > Upstream managed to use libcap-ng in capabilities test and libpcap in > bpf test... > I'm currently queuing patches for upstream. What the status of the old libcap? Is it being deprecated everywhere? > >> > inherit kernel-arch > >> > > >> > @@ -139,8 +139,6 @@ FILES_${PN}-x86 = "${bindir}/kselftests/x86" > >> > FILES_${PN}-zram = "${bindir}/kselftests/zram" > >> > FILES_${PN}-dbg += "${bindir}/kselftests/*/.debug" > >> > > >> > -ALLOW_EMPTY_${PN}-capabilities = "1" > >> > - > >> > RDEPENDS_${PN}-cpu-hotplug += "bash" > >> > RDEPENDS_${PN}-efivarfs += "bash" > >> > RDEPENDS_${PN}-memory-hotplug += "bash" > >> > -- > >> > 2.11.0 > >> > > >> > -- > >> > _______________________________________________ > >> > meta-ti mailing list > >> > meta-ti@yoctoproject.org > >> > https://lists.yoctoproject.org/listinfo/meta-ti > >> > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 17:06 ` Denys Dmytriyenko @ 2017-03-17 17:14 ` Fathi Boudra 2017-03-17 18:57 ` Khem Raj 0 siblings, 1 reply; 15+ messages in thread From: Fathi Boudra @ 2017-03-17 17:14 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-ti On 17 March 2017 at 19:06, Denys Dmytriyenko <denis@denix.org> wrote: > On Fri, Mar 17, 2017 at 07:03:55PM +0200, Fathi Boudra wrote: >> On 17 March 2017 at 18:59, Denys Dmytriyenko <denis@denix.org> wrote: >> > On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote: >> >> On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org> >> >> wrote: >> >> >> >> > libpcap-ng is required to build capabilities tests. >> >> > >> >> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >> >> > --- >> >> > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- >> >> > 1 file changed, 1 insertion(+), 3 deletions(-) >> >> > >> >> > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb >> >> > b/recipes-kernel/kselftests/kselftests_4.9.bb >> >> > index a7b4ba67..dd94a65b 100644 >> >> > --- a/recipes-kernel/kselftests/kselftests_4.9.bb >> >> > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb >> >> > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" >> >> > >> >> > PACKAGE_ARCH = "${MACHINE_ARCH}" >> >> > >> >> > -DEPENDS = "libcap popt rsync-native" >> >> > +DEPENDS = "libcap libcap-ng popt rsync-native" >> >> >> >> >> >> Would ng replace old libcap >> > >> > Are you asking in general or in this particular case? >> > >> > kselftests-capabilities does use libcap-ng and includes cap-ng.h header file, >> > as I mentioned here: >> > https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html >> > >> > Fathi's fix is indeed better, even though adding another dependency. >> >> In this particular case, it doesn't replace libcap. >> Upstream managed to use libcap-ng in capabilities test and libpcap in >> bpf test... >> I'm currently queuing patches for upstream. > > What the status of the old libcap? Is it being deprecated everywhere? The traditional libcap is still mainly used. I don't think it's going to be deprecated soon, systemd is using it for example. >> >> > inherit kernel-arch >> >> > >> >> > @@ -139,8 +139,6 @@ FILES_${PN}-x86 = "${bindir}/kselftests/x86" >> >> > FILES_${PN}-zram = "${bindir}/kselftests/zram" >> >> > FILES_${PN}-dbg += "${bindir}/kselftests/*/.debug" >> >> > >> >> > -ALLOW_EMPTY_${PN}-capabilities = "1" >> >> > - >> >> > RDEPENDS_${PN}-cpu-hotplug += "bash" >> >> > RDEPENDS_${PN}-efivarfs += "bash" >> >> > RDEPENDS_${PN}-memory-hotplug += "bash" >> >> > -- >> >> > 2.11.0 >> >> > >> >> > -- >> >> > _______________________________________________ >> >> > meta-ti mailing list >> >> > meta-ti@yoctoproject.org >> >> > https://lists.yoctoproject.org/listinfo/meta-ti >> >> > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 17:14 ` Fathi Boudra @ 2017-03-17 18:57 ` Khem Raj 2017-03-17 19:04 ` Denys Dmytriyenko 0 siblings, 1 reply; 15+ messages in thread From: Khem Raj @ 2017-03-17 18:57 UTC (permalink / raw) To: Fathi Boudra; +Cc: meta-ti@yoctoproject.org On Fri, Mar 17, 2017 at 10:14 AM, Fathi Boudra <fathi.boudra@linaro.org> wrote: > On 17 March 2017 at 19:06, Denys Dmytriyenko <denis@denix.org> wrote: >> On Fri, Mar 17, 2017 at 07:03:55PM +0200, Fathi Boudra wrote: >>> On 17 March 2017 at 18:59, Denys Dmytriyenko <denis@denix.org> wrote: >>> > On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote: >>> >> On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org> >>> >> wrote: >>> >> >>> >> > libpcap-ng is required to build capabilities tests. >>> >> > >>> >> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >>> >> > --- >>> >> > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- >>> >> > 1 file changed, 1 insertion(+), 3 deletions(-) >>> >> > >>> >> > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb >>> >> > b/recipes-kernel/kselftests/kselftests_4.9.bb >>> >> > index a7b4ba67..dd94a65b 100644 >>> >> > --- a/recipes-kernel/kselftests/kselftests_4.9.bb >>> >> > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb >>> >> > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" >>> >> > >>> >> > PACKAGE_ARCH = "${MACHINE_ARCH}" >>> >> > >>> >> > -DEPENDS = "libcap popt rsync-native" >>> >> > +DEPENDS = "libcap libcap-ng popt rsync-native" >>> >> >>> >> >>> >> Would ng replace old libcap >>> > >>> > Are you asking in general or in this particular case? >>> > >>> > kselftests-capabilities does use libcap-ng and includes cap-ng.h header file, >>> > as I mentioned here: >>> > https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html >>> > >>> > Fathi's fix is indeed better, even though adding another dependency. >>> >>> In this particular case, it doesn't replace libcap. >>> Upstream managed to use libcap-ng in capabilities test and libpcap in >>> bpf test... >>> I'm currently queuing patches for upstream. >> >> What the status of the old libcap? Is it being deprecated everywhere? > > The traditional libcap is still mainly used. I don't think it's going > to be deprecated soon, systemd is using it for example. > can both libs live together without stepping on each other ? ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 18:57 ` Khem Raj @ 2017-03-17 19:04 ` Denys Dmytriyenko 2017-03-17 19:12 ` Khem Raj 0 siblings, 1 reply; 15+ messages in thread From: Denys Dmytriyenko @ 2017-03-17 19:04 UTC (permalink / raw) To: Khem Raj; +Cc: meta-ti@yoctoproject.org On Fri, Mar 17, 2017 at 11:57:04AM -0700, Khem Raj wrote: > On Fri, Mar 17, 2017 at 10:14 AM, Fathi Boudra <fathi.boudra@linaro.org> wrote: > > On 17 March 2017 at 19:06, Denys Dmytriyenko <denis@denix.org> wrote: > >> On Fri, Mar 17, 2017 at 07:03:55PM +0200, Fathi Boudra wrote: > >>> On 17 March 2017 at 18:59, Denys Dmytriyenko <denis@denix.org> wrote: > >>> > On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote: > >>> >> On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org> > >>> >> wrote: > >>> >> > >>> >> > libpcap-ng is required to build capabilities tests. > >>> >> > > >>> >> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > >>> >> > --- > >>> >> > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- > >>> >> > 1 file changed, 1 insertion(+), 3 deletions(-) > >>> >> > > >>> >> > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb > >>> >> > b/recipes-kernel/kselftests/kselftests_4.9.bb > >>> >> > index a7b4ba67..dd94a65b 100644 > >>> >> > --- a/recipes-kernel/kselftests/kselftests_4.9.bb > >>> >> > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb > >>> >> > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" > >>> >> > > >>> >> > PACKAGE_ARCH = "${MACHINE_ARCH}" > >>> >> > > >>> >> > -DEPENDS = "libcap popt rsync-native" > >>> >> > +DEPENDS = "libcap libcap-ng popt rsync-native" > >>> >> > >>> >> > >>> >> Would ng replace old libcap > >>> > > >>> > Are you asking in general or in this particular case? > >>> > > >>> > kselftests-capabilities does use libcap-ng and includes cap-ng.h header file, > >>> > as I mentioned here: > >>> > https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html > >>> > > >>> > Fathi's fix is indeed better, even though adding another dependency. > >>> > >>> In this particular case, it doesn't replace libcap. > >>> Upstream managed to use libcap-ng in capabilities test and libpcap in > >>> bpf test... > >>> I'm currently queuing patches for upstream. > >> > >> What the status of the old libcap? Is it being deprecated everywhere? > > > > The traditional libcap is still mainly used. I don't think it's going > > to be deprecated soon, systemd is using it for example. > > > > can both libs live together without stepping on each other ? FWIW, I haven't tested on all platforms yet (still crunching), but the initial results I'm getting here show no build, stage or run-time issues with images that include both kselftests and systemd... -- Denys ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 19:04 ` Denys Dmytriyenko @ 2017-03-17 19:12 ` Khem Raj 2017-03-17 20:08 ` Denys Dmytriyenko 0 siblings, 1 reply; 15+ messages in thread From: Khem Raj @ 2017-03-17 19:12 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-ti@yoctoproject.org On Fri, Mar 17, 2017 at 12:04 PM, Denys Dmytriyenko <denys@ti.com> wrote: > On Fri, Mar 17, 2017 at 11:57:04AM -0700, Khem Raj wrote: >> On Fri, Mar 17, 2017 at 10:14 AM, Fathi Boudra <fathi.boudra@linaro.org> wrote: >> > On 17 March 2017 at 19:06, Denys Dmytriyenko <denis@denix.org> wrote: >> >> On Fri, Mar 17, 2017 at 07:03:55PM +0200, Fathi Boudra wrote: >> >>> On 17 March 2017 at 18:59, Denys Dmytriyenko <denis@denix.org> wrote: >> >>> > On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote: >> >>> >> On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org> >> >>> >> wrote: >> >>> >> >> >>> >> > libpcap-ng is required to build capabilities tests. >> >>> >> > >> >>> >> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >> >>> >> > --- >> >>> >> > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- >> >>> >> > 1 file changed, 1 insertion(+), 3 deletions(-) >> >>> >> > >> >>> >> > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb >> >>> >> > b/recipes-kernel/kselftests/kselftests_4.9.bb >> >>> >> > index a7b4ba67..dd94a65b 100644 >> >>> >> > --- a/recipes-kernel/kselftests/kselftests_4.9.bb >> >>> >> > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb >> >>> >> > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" >> >>> >> > >> >>> >> > PACKAGE_ARCH = "${MACHINE_ARCH}" >> >>> >> > >> >>> >> > -DEPENDS = "libcap popt rsync-native" >> >>> >> > +DEPENDS = "libcap libcap-ng popt rsync-native" >> >>> >> >> >>> >> >> >>> >> Would ng replace old libcap >> >>> > >> >>> > Are you asking in general or in this particular case? >> >>> > >> >>> > kselftests-capabilities does use libcap-ng and includes cap-ng.h header file, >> >>> > as I mentioned here: >> >>> > https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html >> >>> > >> >>> > Fathi's fix is indeed better, even though adding another dependency. >> >>> >> >>> In this particular case, it doesn't replace libcap. >> >>> Upstream managed to use libcap-ng in capabilities test and libpcap in >> >>> bpf test... >> >>> I'm currently queuing patches for upstream. >> >> >> >> What the status of the old libcap? Is it being deprecated everywhere? >> > >> > The traditional libcap is still mainly used. I don't think it's going >> > to be deprecated soon, systemd is using it for example. >> > >> >> can both libs live together without stepping on each other ? > > FWIW, I haven't tested on all platforms yet (still crunching), but the initial > results I'm getting here show no build, stage or run-time issues with images > that include both kselftests and systemd... > OK you might want to compare the contents of both packages and see if there are any changes that can have effect on behavior subtly. > -- > Denys ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 19:12 ` Khem Raj @ 2017-03-17 20:08 ` Denys Dmytriyenko 2017-03-17 22:26 ` Khem Raj 0 siblings, 1 reply; 15+ messages in thread From: Denys Dmytriyenko @ 2017-03-17 20:08 UTC (permalink / raw) To: Khem Raj; +Cc: meta-ti@yoctoproject.org On Fri, Mar 17, 2017 at 12:12:24PM -0700, Khem Raj wrote: > On Fri, Mar 17, 2017 at 12:04 PM, Denys Dmytriyenko <denys@ti.com> wrote: > > On Fri, Mar 17, 2017 at 11:57:04AM -0700, Khem Raj wrote: > >> On Fri, Mar 17, 2017 at 10:14 AM, Fathi Boudra <fathi.boudra@linaro.org> wrote: > >> > On 17 March 2017 at 19:06, Denys Dmytriyenko <denis@denix.org> wrote: > >> >> On Fri, Mar 17, 2017 at 07:03:55PM +0200, Fathi Boudra wrote: > >> >>> On 17 March 2017 at 18:59, Denys Dmytriyenko <denis@denix.org> wrote: > >> >>> > On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote: > >> >>> >> On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org> > >> >>> >> wrote: > >> >>> >> > >> >>> >> > libpcap-ng is required to build capabilities tests. > >> >>> >> > > >> >>> >> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > >> >>> >> > --- > >> >>> >> > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- > >> >>> >> > 1 file changed, 1 insertion(+), 3 deletions(-) > >> >>> >> > > >> >>> >> > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb > >> >>> >> > b/recipes-kernel/kselftests/kselftests_4.9.bb > >> >>> >> > index a7b4ba67..dd94a65b 100644 > >> >>> >> > --- a/recipes-kernel/kselftests/kselftests_4.9.bb > >> >>> >> > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb > >> >>> >> > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" > >> >>> >> > > >> >>> >> > PACKAGE_ARCH = "${MACHINE_ARCH}" > >> >>> >> > > >> >>> >> > -DEPENDS = "libcap popt rsync-native" > >> >>> >> > +DEPENDS = "libcap libcap-ng popt rsync-native" > >> >>> >> > >> >>> >> > >> >>> >> Would ng replace old libcap > >> >>> > > >> >>> > Are you asking in general or in this particular case? > >> >>> > > >> >>> > kselftests-capabilities does use libcap-ng and includes cap-ng.h header file, > >> >>> > as I mentioned here: > >> >>> > https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html > >> >>> > > >> >>> > Fathi's fix is indeed better, even though adding another dependency. > >> >>> > >> >>> In this particular case, it doesn't replace libcap. > >> >>> Upstream managed to use libcap-ng in capabilities test and libpcap in > >> >>> bpf test... > >> >>> I'm currently queuing patches for upstream. > >> >> > >> >> What the status of the old libcap? Is it being deprecated everywhere? > >> > > >> > The traditional libcap is still mainly used. I don't think it's going > >> > to be deprecated soon, systemd is using it for example. > >> > > >> > >> can both libs live together without stepping on each other ? > > > > FWIW, I haven't tested on all platforms yet (still crunching), but the initial > > results I'm getting here show no build, stage or run-time issues with images > > that include both kselftests and systemd... > > > > OK you might want to compare the contents of both packages > and see if there are any changes that can have effect on behavior subtly. Looked at all the packaged stuff - cap-ng is very careful to maintain separate namespace. There are no conflicts in packaged files - headers, libraries, aclocal, pkgconfig, etc. all have cap-ng in the name. Even the new API in the header file uses CAPNG_* enums and capng_*() functions: https://sourcecodebrowser.com/libcap-ng/0.6.5/cap-ng_8h.html -- Denys ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 20:08 ` Denys Dmytriyenko @ 2017-03-17 22:26 ` Khem Raj 0 siblings, 0 replies; 15+ messages in thread From: Khem Raj @ 2017-03-17 22:26 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-ti@yoctoproject.org On Fri, Mar 17, 2017 at 1:08 PM, Denys Dmytriyenko <denys@ti.com> wrote: > On Fri, Mar 17, 2017 at 12:12:24PM -0700, Khem Raj wrote: >> On Fri, Mar 17, 2017 at 12:04 PM, Denys Dmytriyenko <denys@ti.com> wrote: >> > On Fri, Mar 17, 2017 at 11:57:04AM -0700, Khem Raj wrote: >> >> On Fri, Mar 17, 2017 at 10:14 AM, Fathi Boudra <fathi.boudra@linaro.org> wrote: >> >> > On 17 March 2017 at 19:06, Denys Dmytriyenko <denis@denix.org> wrote: >> >> >> On Fri, Mar 17, 2017 at 07:03:55PM +0200, Fathi Boudra wrote: >> >> >>> On 17 March 2017 at 18:59, Denys Dmytriyenko <denis@denix.org> wrote: >> >> >>> > On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote: >> >> >>> >> On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra@linaro.org> >> >> >>> >> wrote: >> >> >>> >> >> >> >>> >> > libpcap-ng is required to build capabilities tests. >> >> >>> >> > >> >> >>> >> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >> >> >>> >> > --- >> >> >>> >> > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- >> >> >>> >> > 1 file changed, 1 insertion(+), 3 deletions(-) >> >> >>> >> > >> >> >>> >> > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb >> >> >>> >> > b/recipes-kernel/kselftests/kselftests_4.9.bb >> >> >>> >> > index a7b4ba67..dd94a65b 100644 >> >> >>> >> > --- a/recipes-kernel/kselftests/kselftests_4.9.bb >> >> >>> >> > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb >> >> >>> >> > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" >> >> >>> >> > >> >> >>> >> > PACKAGE_ARCH = "${MACHINE_ARCH}" >> >> >>> >> > >> >> >>> >> > -DEPENDS = "libcap popt rsync-native" >> >> >>> >> > +DEPENDS = "libcap libcap-ng popt rsync-native" >> >> >>> >> >> >> >>> >> >> >> >>> >> Would ng replace old libcap >> >> >>> > >> >> >>> > Are you asking in general or in this particular case? >> >> >>> > >> >> >>> > kselftests-capabilities does use libcap-ng and includes cap-ng.h header file, >> >> >>> > as I mentioned here: >> >> >>> > https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html >> >> >>> > >> >> >>> > Fathi's fix is indeed better, even though adding another dependency. >> >> >>> >> >> >>> In this particular case, it doesn't replace libcap. >> >> >>> Upstream managed to use libcap-ng in capabilities test and libpcap in >> >> >>> bpf test... >> >> >>> I'm currently queuing patches for upstream. >> >> >> >> >> >> What the status of the old libcap? Is it being deprecated everywhere? >> >> > >> >> > The traditional libcap is still mainly used. I don't think it's going >> >> > to be deprecated soon, systemd is using it for example. >> >> > >> >> >> >> can both libs live together without stepping on each other ? >> > >> > FWIW, I haven't tested on all platforms yet (still crunching), but the initial >> > results I'm getting here show no build, stage or run-time issues with images >> > that include both kselftests and systemd... >> > >> >> OK you might want to compare the contents of both packages >> and see if there are any changes that can have effect on behavior subtly. > > Looked at all the packaged stuff - cap-ng is very careful to maintain separate > namespace. There are no conflicts in packaged files - headers, libraries, > aclocal, pkgconfig, etc. all have cap-ng in the name. Even the new API in the > header file uses CAPNG_* enums and capng_*() functions: > https://sourcecodebrowser.com/libcap-ng/0.6.5/cap-ng_8h.html > that looks good. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 16:36 [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency Fathi Boudra 2017-03-17 16:36 ` [morty-next][PATCH 2/2] kselftests: fix seccomp test build failure Fathi Boudra 2017-03-17 16:47 ` [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency Khem Raj @ 2017-03-17 17:04 ` Denys Dmytriyenko 2017-03-17 17:09 ` Fathi Boudra 2 siblings, 1 reply; 15+ messages in thread From: Denys Dmytriyenko @ 2017-03-17 17:04 UTC (permalink / raw) To: Fathi Boudra; +Cc: meta-ti Fathi, Since I haven't merged morty-next anywhere yet, I can rebase and modify my previous patch to not do a workaround for capabilities tests... On Fri, Mar 17, 2017 at 06:36:52PM +0200, Fathi Boudra wrote: > libpcap-ng is required to build capabilities tests. > > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > --- > recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb b/recipes-kernel/kselftests/kselftests_4.9.bb > index a7b4ba67..dd94a65b 100644 > --- a/recipes-kernel/kselftests/kselftests_4.9.bb > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" > > PACKAGE_ARCH = "${MACHINE_ARCH}" > > -DEPENDS = "libcap popt rsync-native" > +DEPENDS = "libcap libcap-ng popt rsync-native" > > inherit kernel-arch > > @@ -139,8 +139,6 @@ FILES_${PN}-x86 = "${bindir}/kselftests/x86" > FILES_${PN}-zram = "${bindir}/kselftests/zram" > FILES_${PN}-dbg += "${bindir}/kselftests/*/.debug" > > -ALLOW_EMPTY_${PN}-capabilities = "1" > - > RDEPENDS_${PN}-cpu-hotplug += "bash" > RDEPENDS_${PN}-efivarfs += "bash" > RDEPENDS_${PN}-memory-hotplug += "bash" > -- > 2.11.0 > > -- > _______________________________________________ > meta-ti mailing list > meta-ti@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-ti > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 17:04 ` Denys Dmytriyenko @ 2017-03-17 17:09 ` Fathi Boudra 2017-03-17 18:07 ` Denys Dmytriyenko 0 siblings, 1 reply; 15+ messages in thread From: Fathi Boudra @ 2017-03-17 17:09 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-ti On 17 March 2017 at 19:04, Denys Dmytriyenko <denis@denix.org> wrote: > Fathi, > > Since I haven't merged morty-next anywhere yet, I can rebase and modify my > previous patch to not do a workaround for capabilities tests... works for me. Thanks! > On Fri, Mar 17, 2017 at 06:36:52PM +0200, Fathi Boudra wrote: >> libpcap-ng is required to build capabilities tests. >> >> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> >> --- >> recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb b/recipes-kernel/kselftests/kselftests_4.9.bb >> index a7b4ba67..dd94a65b 100644 >> --- a/recipes-kernel/kselftests/kselftests_4.9.bb >> +++ b/recipes-kernel/kselftests/kselftests_4.9.bb >> @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" >> >> PACKAGE_ARCH = "${MACHINE_ARCH}" >> >> -DEPENDS = "libcap popt rsync-native" >> +DEPENDS = "libcap libcap-ng popt rsync-native" >> >> inherit kernel-arch >> >> @@ -139,8 +139,6 @@ FILES_${PN}-x86 = "${bindir}/kselftests/x86" >> FILES_${PN}-zram = "${bindir}/kselftests/zram" >> FILES_${PN}-dbg += "${bindir}/kselftests/*/.debug" >> >> -ALLOW_EMPTY_${PN}-capabilities = "1" >> - >> RDEPENDS_${PN}-cpu-hotplug += "bash" >> RDEPENDS_${PN}-efivarfs += "bash" >> RDEPENDS_${PN}-memory-hotplug += "bash" >> -- >> 2.11.0 >> >> -- >> _______________________________________________ >> meta-ti mailing list >> meta-ti@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/meta-ti ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency 2017-03-17 17:09 ` Fathi Boudra @ 2017-03-17 18:07 ` Denys Dmytriyenko 0 siblings, 0 replies; 15+ messages in thread From: Denys Dmytriyenko @ 2017-03-17 18:07 UTC (permalink / raw) To: Fathi Boudra; +Cc: meta-ti On Fri, Mar 17, 2017 at 07:09:21PM +0200, Fathi Boudra wrote: > On 17 March 2017 at 19:04, Denys Dmytriyenko <denis@denix.org> wrote: > > Fathi, > > > > Since I haven't merged morty-next anywhere yet, I can rebase and modify my > > previous patch to not do a workaround for capabilities tests... > > works for me. Thanks! And s/libpcap/libcap/g in couple places... :) > > On Fri, Mar 17, 2017 at 06:36:52PM +0200, Fathi Boudra wrote: > >> libpcap-ng is required to build capabilities tests. > >> > >> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> > >> --- > >> recipes-kernel/kselftests/kselftests_4.9.bb | 4 +--- > >> 1 file changed, 1 insertion(+), 3 deletions(-) > >> > >> diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb b/recipes-kernel/kselftests/kselftests_4.9.bb > >> index a7b4ba67..dd94a65b 100644 > >> --- a/recipes-kernel/kselftests/kselftests_4.9.bb > >> +++ b/recipes-kernel/kselftests/kselftests_4.9.bb > >> @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}" > >> > >> PACKAGE_ARCH = "${MACHINE_ARCH}" > >> > >> -DEPENDS = "libcap popt rsync-native" > >> +DEPENDS = "libcap libcap-ng popt rsync-native" > >> > >> inherit kernel-arch > >> > >> @@ -139,8 +139,6 @@ FILES_${PN}-x86 = "${bindir}/kselftests/x86" > >> FILES_${PN}-zram = "${bindir}/kselftests/zram" > >> FILES_${PN}-dbg += "${bindir}/kselftests/*/.debug" > >> > >> -ALLOW_EMPTY_${PN}-capabilities = "1" > >> - > >> RDEPENDS_${PN}-cpu-hotplug += "bash" > >> RDEPENDS_${PN}-efivarfs += "bash" > >> RDEPENDS_${PN}-memory-hotplug += "bash" > >> -- > >> 2.11.0 > >> > >> -- > >> _______________________________________________ > >> meta-ti mailing list > >> meta-ti@yoctoproject.org > >> https://lists.yoctoproject.org/listinfo/meta-ti > ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-03-17 22:27 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-03-17 16:36 [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency Fathi Boudra 2017-03-17 16:36 ` [morty-next][PATCH 2/2] kselftests: fix seccomp test build failure Fathi Boudra 2017-03-17 16:47 ` [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency Khem Raj 2017-03-17 16:59 ` Denys Dmytriyenko 2017-03-17 17:03 ` Fathi Boudra 2017-03-17 17:06 ` Denys Dmytriyenko 2017-03-17 17:14 ` Fathi Boudra 2017-03-17 18:57 ` Khem Raj 2017-03-17 19:04 ` Denys Dmytriyenko 2017-03-17 19:12 ` Khem Raj 2017-03-17 20:08 ` Denys Dmytriyenko 2017-03-17 22:26 ` Khem Raj 2017-03-17 17:04 ` Denys Dmytriyenko 2017-03-17 17:09 ` Fathi Boudra 2017-03-17 18:07 ` Denys Dmytriyenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.