From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/15] ARM: dts: imx: fix PCI bus dtc warnings
Date: Wed, 22 Mar 2017 16:19:44 +0800 [thread overview]
Message-ID: <20170322081942.GM3443@dragon> (raw)
In-Reply-To: <20170322020313.24338-5-robh@kernel.org>
On Tue, Mar 21, 2017 at 09:03:03PM -0500, Rob Herring wrote:
> dtc recently added PCI bus checks. Fix these warnings.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
Applied with a couple of changes below.
> ---
> Sub-arch maintainers, please apply to your trees unless arm-soc wants
> to take the whole lot.
>
> arch/arm/boot/dts/imx6qdl.dtsi | 3 ++-
> arch/arm/boot/dts/imx6qp.dtsi | 2 +-
> arch/arm/boot/dts/imx6sx.dtsi | 3 ++-
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 6d7bf6496117..f95e24e73252 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -197,7 +197,7 @@
> arm,shared-override;
> };
>
> - pcie: pcie at 0x01000000 {
> + pcie: pcie at 1ffc000 {
> compatible = "fsl,imx6q-pcie", "snps,dw-pcie";
> reg = <0x01ffc000 0x04000>,
> <0x01f00000 0x80000>;
> @@ -205,6 +205,7 @@
> #address-cells = <3>;
> #size-cells = <2>;
> device_type = "pci";
> + bus-range = <0 0xff>;
For sake of consistency, I changed it to <0x00 0xff> like you did for
imx6sx.dtsi.
> ranges = <0x81000000 0 0 0x01f80000 0 0x00010000 /* downstream I/O */
> 0x82000000 0 0x01000000 0x01000000 0 0x00f00000>; /* non-prefetchable memory */
> num-lanes = <1>;
> diff --git a/arch/arm/boot/dts/imx6qp.dtsi b/arch/arm/boot/dts/imx6qp.dtsi
> index 24d071f5d9cd..b7688f1e3c86 100644
> --- a/arch/arm/boot/dts/imx6qp.dtsi
> +++ b/arch/arm/boot/dts/imx6qp.dtsi
> @@ -82,7 +82,7 @@
> "ldb_di0", "ldb_di1", "prg";
> };
>
> - pcie: pcie at 0x01000000 {
> + pcie: pcie at 1ffc000 {
We had a patch on IMX tree changing this to use label for referencing
the node, and hence this imx6qp.dtsi bit change can be saved.
Shawn
> compatible = "fsl,imx6qp-pcie", "snps,dw-pcie";
> };
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index dd4ec85ecbaa..c7f76de57c7b 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -1281,7 +1281,7 @@
> };
> };
>
> - pcie: pcie at 0x08000000 {
> + pcie: pcie at 8ffc000 {
> compatible = "fsl,imx6sx-pcie", "snps,dw-pcie";
> reg = <0x08ffc000 0x4000>; /* DBI */
> #address-cells = <3>;
> @@ -1293,6 +1293,7 @@
> 0x81000000 0 0 0x08f80000 0 0x00010000
> /* non-prefetchable memory */
> 0x82000000 0 0x08000000 0x08000000 0 0x00f00000>;
> + bus-range = <0x00 0xff>;
> num-lanes = <1>;
> interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6SX_CLK_PCIE_REF_125M>,
> --
> 2.10.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
devicetree@vger.kernel.org, arm@kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/15] ARM: dts: imx: fix PCI bus dtc warnings
Date: Wed, 22 Mar 2017 16:19:44 +0800 [thread overview]
Message-ID: <20170322081942.GM3443@dragon> (raw)
In-Reply-To: <20170322020313.24338-5-robh@kernel.org>
On Tue, Mar 21, 2017 at 09:03:03PM -0500, Rob Herring wrote:
> dtc recently added PCI bus checks. Fix these warnings.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
Applied with a couple of changes below.
> ---
> Sub-arch maintainers, please apply to your trees unless arm-soc wants
> to take the whole lot.
>
> arch/arm/boot/dts/imx6qdl.dtsi | 3 ++-
> arch/arm/boot/dts/imx6qp.dtsi | 2 +-
> arch/arm/boot/dts/imx6sx.dtsi | 3 ++-
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 6d7bf6496117..f95e24e73252 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -197,7 +197,7 @@
> arm,shared-override;
> };
>
> - pcie: pcie@0x01000000 {
> + pcie: pcie@1ffc000 {
> compatible = "fsl,imx6q-pcie", "snps,dw-pcie";
> reg = <0x01ffc000 0x04000>,
> <0x01f00000 0x80000>;
> @@ -205,6 +205,7 @@
> #address-cells = <3>;
> #size-cells = <2>;
> device_type = "pci";
> + bus-range = <0 0xff>;
For sake of consistency, I changed it to <0x00 0xff> like you did for
imx6sx.dtsi.
> ranges = <0x81000000 0 0 0x01f80000 0 0x00010000 /* downstream I/O */
> 0x82000000 0 0x01000000 0x01000000 0 0x00f00000>; /* non-prefetchable memory */
> num-lanes = <1>;
> diff --git a/arch/arm/boot/dts/imx6qp.dtsi b/arch/arm/boot/dts/imx6qp.dtsi
> index 24d071f5d9cd..b7688f1e3c86 100644
> --- a/arch/arm/boot/dts/imx6qp.dtsi
> +++ b/arch/arm/boot/dts/imx6qp.dtsi
> @@ -82,7 +82,7 @@
> "ldb_di0", "ldb_di1", "prg";
> };
>
> - pcie: pcie@0x01000000 {
> + pcie: pcie@1ffc000 {
We had a patch on IMX tree changing this to use label for referencing
the node, and hence this imx6qp.dtsi bit change can be saved.
Shawn
> compatible = "fsl,imx6qp-pcie", "snps,dw-pcie";
> };
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index dd4ec85ecbaa..c7f76de57c7b 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -1281,7 +1281,7 @@
> };
> };
>
> - pcie: pcie@0x08000000 {
> + pcie: pcie@8ffc000 {
> compatible = "fsl,imx6sx-pcie", "snps,dw-pcie";
> reg = <0x08ffc000 0x4000>; /* DBI */
> #address-cells = <3>;
> @@ -1293,6 +1293,7 @@
> 0x81000000 0 0 0x08f80000 0 0x00010000
> /* non-prefetchable memory */
> 0x82000000 0 0x08000000 0x08000000 0 0x00f00000>;
> + bus-range = <0x00 0xff>;
> num-lanes = <1>;
> interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX6SX_CLK_PCIE_REF_125M>,
> --
> 2.10.1
>
next prev parent reply other threads:[~2017-03-22 8:19 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 2:02 [PATCH 01/15] ARM: dts: alpine: fix PCIe node name Rob Herring
2017-03-22 2:02 ` Rob Herring
2017-03-22 2:03 ` [PATCH 02/15] ARM: dts: marvell: fix PCI bus dtc warnings Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-24 14:17 ` Gregory CLEMENT
2017-03-24 14:17 ` Gregory CLEMENT
2017-03-22 2:03 ` [PATCH 04/15] ARM: dts: exynos: " Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-23 19:37 ` Krzysztof Kozlowski
2017-03-23 19:37 ` Krzysztof Kozlowski
2017-03-22 2:03 ` [PATCH 05/15] ARM: dts: imx: " Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-22 8:19 ` Shawn Guo [this message]
2017-03-22 8:19 ` Shawn Guo
2017-03-22 13:53 ` Rob Herring
2017-03-22 13:53 ` Rob Herring
2017-03-24 1:28 ` Shawn Guo
2017-03-24 1:28 ` Shawn Guo
2017-03-22 2:03 ` [PATCH 06/15] ARM: dts: r8a779x: " Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-22 8:58 ` Geert Uytterhoeven
2017-03-22 8:58 ` Geert Uytterhoeven
2017-03-22 8:58 ` Geert Uytterhoeven
2017-03-22 13:47 ` Rob Herring
2017-03-22 13:47 ` Rob Herring
2017-03-22 13:47 ` Rob Herring
2017-03-22 14:06 ` Geert Uytterhoeven
2017-03-22 14:06 ` Geert Uytterhoeven
2017-03-22 14:06 ` Geert Uytterhoeven
2017-03-24 7:06 ` Simon Horman
2017-03-24 7:06 ` Simon Horman
2017-03-24 7:06 ` Simon Horman
2017-03-24 7:59 ` Geert Uytterhoeven
2017-03-24 7:59 ` Geert Uytterhoeven
2017-03-24 7:59 ` Geert Uytterhoeven
2017-03-22 2:03 ` [PATCH 07/15] ARM: dts: spear13xx: " Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-22 4:11 ` Viresh Kumar
2017-03-22 4:11 ` Viresh Kumar
2017-03-22 2:03 ` [PATCH 09/15] ARM: dts: versatile: " Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-22 2:03 ` [PATCH 10/15] ARM: dts: bcm: fix msi-controller name and unit address Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-22 6:07 ` Ray Jui
2017-03-22 6:07 ` Ray Jui
2017-03-22 17:16 ` Florian Fainelli
2017-03-22 17:16 ` Florian Fainelli
[not found] ` <20170322020313.24338-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-03-22 2:03 ` [PATCH 03/15] ARM: dts: ti: fix PCI bus dtc warnings Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-22 2:03 ` [PATCH 08/15] ARM: dts: tegra: " Rob Herring
2017-03-22 2:03 ` Rob Herring
[not found] ` <20170322020313.24338-8-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-13 14:51 ` Thierry Reding
2017-06-13 14:51 ` Thierry Reding
2017-03-22 2:03 ` [PATCH 11/15] arm64: dts: nvidia: " Rob Herring
2017-03-22 2:03 ` Rob Herring
[not found] ` <20170322020313.24338-11-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-13 14:52 ` Thierry Reding
2017-06-13 14:52 ` Thierry Reding
2017-03-22 2:03 ` [PATCH 12/15] arm64: dts: apm: " Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-22 2:03 ` [PATCH 13/15] arm64: dts: juno: " Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-22 11:56 ` Liviu Dudau
2017-03-22 11:56 ` Liviu Dudau
2017-03-22 2:03 ` [PATCH 14/15] arm64: dts: broadcom: " Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-22 5:36 ` Jayachandran C.
2017-03-22 5:36 ` Jayachandran C.
2017-03-22 2:03 ` [PATCH 15/15] arm64: dts: xilinx: " Rob Herring
2017-03-22 2:03 ` Rob Herring
2017-03-23 14:35 ` Michal Simek
2017-03-23 14:35 ` Michal Simek
2017-03-22 8:01 ` [PATCH 01/15] ARM: dts: alpine: fix PCIe node name Antoine Tenart
2017-03-22 8:01 ` Antoine Tenart
2017-03-24 17:00 ` Arnd Bergmann
2017-03-24 17:00 ` Arnd Bergmann
2017-03-24 18:25 ` Antoine Tenart
2017-03-24 18:25 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322081942.GM3443@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.