From: Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
To: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org,
pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org,
bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
heyi.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v3] efifb: avoid reconfiguration of BAR that covers the framebuffer
Date: Wed, 22 Mar 2017 20:31:11 +0100 [thread overview]
Message-ID: <20170322193111.GA8190@wunner.de> (raw)
In-Reply-To: <1490196629-28088-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Wed, Mar 22, 2017 at 03:30:29PM +0000, Ard Biesheuvel wrote:
> On UEFI systems, the PCI subsystem is enumerated by the firmware,
> and if a graphical framebuffer is exposed by a PCI device, its base
> address and size are exposed to the OS via the Graphics Output
> Protocol (GOP).
>
> On arm64 PCI systems, the entire PCI hierarchy is reconfigured from
> scratch at boot. This may result in the GOP framebuffer address to
> become stale, if the BAR covering the framebuffer is modified. This
> will cause the framebuffer to become unresponsive, and may in some
> cases result in unpredictable behavior if the range is reassigned to
> another device.
Hm, commit message seems to indicate the issue is restricted to arm64,
yet there's no IS_ENABLED(ARM64) to constrain the added code to that arch?
> +DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, efifb_fixup_resources);
Maybe this can be constrained to PCI_BASE_CLASS_DISPLAY?
Thanks,
Lukas
WARNING: multiple messages have this Message-ID (diff)
From: Lukas Wunner <lukas@wunner.de>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: lorenzo.pieralisi@arm.com, matt@codeblueprint.co.uk,
linux-pci@vger.kernel.org, pjones@redhat.com,
heyi.guo@linaro.org, linux-efi@vger.kernel.org,
hanjun.guo@linaro.org, bhelgaas@google.com, yinghai@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] efifb: avoid reconfiguration of BAR that covers the framebuffer
Date: Wed, 22 Mar 2017 20:31:11 +0100 [thread overview]
Message-ID: <20170322193111.GA8190@wunner.de> (raw)
In-Reply-To: <1490196629-28088-1-git-send-email-ard.biesheuvel@linaro.org>
On Wed, Mar 22, 2017 at 03:30:29PM +0000, Ard Biesheuvel wrote:
> On UEFI systems, the PCI subsystem is enumerated by the firmware,
> and if a graphical framebuffer is exposed by a PCI device, its base
> address and size are exposed to the OS via the Graphics Output
> Protocol (GOP).
>
> On arm64 PCI systems, the entire PCI hierarchy is reconfigured from
> scratch at boot. This may result in the GOP framebuffer address to
> become stale, if the BAR covering the framebuffer is modified. This
> will cause the framebuffer to become unresponsive, and may in some
> cases result in unpredictable behavior if the range is reassigned to
> another device.
Hm, commit message seems to indicate the issue is restricted to arm64,
yet there's no IS_ENABLED(ARM64) to constrain the added code to that arch?
> +DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, efifb_fixup_resources);
Maybe this can be constrained to PCI_BASE_CLASS_DISPLAY?
Thanks,
Lukas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: lukas@wunner.de (Lukas Wunner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] efifb: avoid reconfiguration of BAR that covers the framebuffer
Date: Wed, 22 Mar 2017 20:31:11 +0100 [thread overview]
Message-ID: <20170322193111.GA8190@wunner.de> (raw)
In-Reply-To: <1490196629-28088-1-git-send-email-ard.biesheuvel@linaro.org>
On Wed, Mar 22, 2017 at 03:30:29PM +0000, Ard Biesheuvel wrote:
> On UEFI systems, the PCI subsystem is enumerated by the firmware,
> and if a graphical framebuffer is exposed by a PCI device, its base
> address and size are exposed to the OS via the Graphics Output
> Protocol (GOP).
>
> On arm64 PCI systems, the entire PCI hierarchy is reconfigured from
> scratch at boot. This may result in the GOP framebuffer address to
> become stale, if the BAR covering the framebuffer is modified. This
> will cause the framebuffer to become unresponsive, and may in some
> cases result in unpredictable behavior if the range is reassigned to
> another device.
Hm, commit message seems to indicate the issue is restricted to arm64,
yet there's no IS_ENABLED(ARM64) to constrain the added code to that arch?
> +DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, efifb_fixup_resources);
Maybe this can be constrained to PCI_BASE_CLASS_DISPLAY?
Thanks,
Lukas
next prev parent reply other threads:[~2017-03-22 19:31 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 15:30 [PATCH v3] efifb: avoid reconfiguration of BAR that covers the framebuffer Ard Biesheuvel
2017-03-22 15:30 ` Ard Biesheuvel
2017-03-22 15:30 ` Ard Biesheuvel
[not found] ` <1490196629-28088-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-03-22 19:31 ` Lukas Wunner [this message]
2017-03-22 19:31 ` Lukas Wunner
2017-03-22 19:31 ` Lukas Wunner
2017-03-22 19:32 ` Ard Biesheuvel
2017-03-22 19:32 ` Ard Biesheuvel
2017-03-22 19:32 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_X-SEnz7h9J8boqqjOQGHQawwdSAq4haH-OGu8zdfNfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-23 8:48 ` Lukas Wunner
2017-03-23 8:48 ` Lukas Wunner
2017-03-23 8:48 ` Lukas Wunner
2017-03-23 9:04 ` Ard Biesheuvel
2017-03-23 9:04 ` Ard Biesheuvel
2017-03-23 9:04 ` Ard Biesheuvel
[not found] ` <CAKv+Gu93eJ-js3g7M6Jdm6XGMaWMswFmzBG2qNT4rn+3=1+EyA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-23 10:57 ` Lorenzo Pieralisi
2017-03-23 10:57 ` Lorenzo Pieralisi
2017-03-23 10:57 ` Lorenzo Pieralisi
2017-03-23 12:25 ` Ard Biesheuvel
2017-03-23 12:25 ` Ard Biesheuvel
2017-03-23 12:25 ` Ard Biesheuvel
2017-03-23 14:31 ` Lorenzo Pieralisi
2017-03-23 14:31 ` Lorenzo Pieralisi
2017-03-23 14:31 ` Lorenzo Pieralisi
2017-03-23 15:15 ` Ard Biesheuvel
2017-03-23 15:15 ` Ard Biesheuvel
2017-03-23 15:15 ` Ard Biesheuvel
2017-03-27 15:37 ` Ard Biesheuvel
2017-03-27 15:37 ` Ard Biesheuvel
2017-03-27 15:37 ` Ard Biesheuvel
2017-03-28 21:27 ` Sinan Kaya
2017-03-28 21:27 ` Sinan Kaya
2017-03-28 21:27 ` Sinan Kaya
2017-03-28 21:39 ` Ard Biesheuvel
2017-03-28 21:39 ` Ard Biesheuvel
2017-03-28 21:39 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9LbwpnJNi1OL25MWvYPxEOfKRHcs2jA2121BPaQWPzow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-28 21:49 ` Sinan Kaya
2017-03-28 21:49 ` Sinan Kaya
2017-03-28 21:49 ` Sinan Kaya
[not found] ` <27f50de3-721e-e8ec-00c8-b7a9d3cff0d6-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-03-30 8:46 ` Ard Biesheuvel
2017-03-30 8:46 ` Ard Biesheuvel
2017-03-30 8:46 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-qRg8-YRCairppKrEfeLcW+OwVF8qZHp7vxXJA_AwPOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-03-30 10:05 ` Lorenzo Pieralisi
2017-03-30 10:05 ` Lorenzo Pieralisi
2017-03-30 10:05 ` Lorenzo Pieralisi
2017-03-30 10:09 ` Ard Biesheuvel
2017-03-30 10:09 ` Ard Biesheuvel
2017-03-30 10:09 ` Ard Biesheuvel
2017-03-30 11:42 ` okaya
2017-03-30 11:42 ` okaya at codeaurora.org
2017-03-30 11:42 ` okaya
2017-03-30 13:38 ` Ard Biesheuvel
2017-03-30 13:38 ` Ard Biesheuvel
2017-03-30 13:38 ` Ard Biesheuvel
2017-03-30 13:50 ` Sinan Kaya
2017-03-30 13:50 ` Sinan Kaya
2017-03-30 13:50 ` Sinan Kaya
[not found] ` <ae87ae28-f50d-095f-576e-f3fd7f96dea2-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-04-02 15:16 ` Ard Biesheuvel
2017-04-02 15:16 ` Ard Biesheuvel
2017-04-02 15:16 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8x0rQUnTUorknW-mW9LFgrxFYsXyy4LU_w9JbA-m_sjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-10 15:28 ` Ard Biesheuvel
2017-04-10 15:28 ` Ard Biesheuvel
2017-04-10 15:28 ` Ard Biesheuvel
2017-04-10 16:53 ` Lorenzo Pieralisi
2017-04-10 16:53 ` Lorenzo Pieralisi
2017-04-10 16:53 ` Lorenzo Pieralisi
2017-04-10 17:06 ` Sinan Kaya
2017-04-10 17:06 ` Sinan Kaya
2017-04-10 17:06 ` Sinan Kaya
2017-04-10 17:13 ` Ard Biesheuvel
2017-04-10 17:13 ` Ard Biesheuvel
2017-04-10 17:13 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-AN-OwnAJG5dt0Qg4GU8HxZBowTSA0H3LhNA3nHfrsQg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-10 17:29 ` Ard Biesheuvel
2017-04-10 17:29 ` Ard Biesheuvel
2017-04-10 17:29 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9dS4OhLbBw59yKYQmoJ8SpFexzk9yH=XfXnzn8NJ4mcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-11 13:16 ` Lorenzo Pieralisi
2017-04-11 13:16 ` Lorenzo Pieralisi
2017-04-11 13:16 ` Lorenzo Pieralisi
2017-04-11 16:06 ` Ard Biesheuvel
2017-04-11 16:06 ` Ard Biesheuvel
2017-04-11 16:06 ` Ard Biesheuvel
2017-04-23 1:45 ` Yinghai Lu
2017-04-23 1:45 ` Yinghai Lu
2017-04-23 1:45 ` Yinghai Lu
[not found] ` <20170423014546.GA2704-HmG2f/OLMhfd32I7TRUmRQWg3BAJk+jzdezBB/11ZoCIZ3GwZIjcak9v6f1uFnsJ2SarAXORi/o@public.gmane.org>
2017-04-27 13:55 ` Ard Biesheuvel
2017-04-27 13:55 ` Ard Biesheuvel
2017-04-27 13:55 ` Ard Biesheuvel
[not found] ` <CAKv+Gu_n7xP-2RtF44GVzwyoMXDOeF-bR43yStwp2y+oBNs4jg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-28 20:51 ` Yinghai Lu
2017-04-28 20:51 ` Yinghai Lu
2017-04-28 20:51 ` Yinghai Lu
2017-03-22 19:36 ` Sinan Kaya
2017-03-22 19:36 ` Sinan Kaya
2017-03-22 19:36 ` Sinan Kaya
2017-03-22 19:41 ` Ard Biesheuvel
2017-03-22 19:41 ` Ard Biesheuvel
2017-03-22 19:41 ` Ard Biesheuvel
2017-03-22 19:49 ` Sinan Kaya
2017-03-22 19:49 ` Sinan Kaya
2017-03-22 19:49 ` Sinan Kaya
2017-03-22 19:52 ` Ard Biesheuvel
2017-03-22 19:52 ` Ard Biesheuvel
2017-03-22 19:52 ` Ard Biesheuvel
2017-03-22 19:57 ` Sinan Kaya
2017-03-22 19:57 ` Sinan Kaya
2017-03-22 19:57 ` Sinan Kaya
[not found] ` <4ccb4d92-3830-3980-38c3-7085a3d97734-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-03-22 20:00 ` Ard Biesheuvel
2017-03-22 20:00 ` Ard Biesheuvel
2017-03-22 20:00 ` Ard Biesheuvel
2017-05-03 3:09 ` Heyi Guo
2017-05-03 3:09 ` Heyi Guo
2017-05-03 3:09 ` Heyi Guo
2017-05-18 14:01 ` Bjorn Helgaas
2017-05-18 14:01 ` Bjorn Helgaas
2017-05-18 14:01 ` Bjorn Helgaas
[not found] ` <20170518140154.GA24324-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2017-05-20 8:19 ` Heyi Guo
2017-05-20 8:19 ` Heyi Guo
2017-05-20 8:19 ` Heyi Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322193111.GA8190@wunner.de \
--to=lukas-jfq808j9c/izqb+pc5nmwq@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=heyi.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org \
--cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
--cc=pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=yinghai-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.