All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	kasan-dev <kasan-dev@googlegroups.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"x86@kernel.org" <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations
Date: Tue, 28 Mar 2017 09:52:32 +0200	[thread overview]
Message-ID: <20170328075232.GA19590@gmail.com> (raw)
In-Reply-To: <CACT4Y+YaFhVpu8-37=rOfOT1UN5K_bKMsMVQ+qiPZUWuSSERuw@mail.gmail.com>


* Dmitry Vyukov <dvyukov@google.com> wrote:

> On Fri, Mar 24, 2017 at 11:57 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Dmitry Vyukov <dvyukov@google.com> wrote:
> >
> >> > Are just utterly disgusting that turn perfectly readable code into an
> >> > unreadable, unmaintainable mess.
> >> >
> >> > You need to find some better, cleaner solution please, or convince me that no
> >> > such solution is possible. NAK for the time being.
> >>
> >> Well, I can just write all functions as is. Does it better confirm to kernel
> >> style?
> >
> > I think writing the prototypes out as-is, properly organized, beats any of these
> > macro based solutions.
> 
> You mean write out the prototypes, but use what for definitions? Macros again?

No, regular C code.

I don't see the point of generating all this code via CPP - it's certainly not 
making it more readable to me. I.e. this patch I commented on is a step backwards 
for readability.

I'd prefer repetition and a higher overall line count over complex CPP constructs.

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	kasan-dev <kasan-dev@googlegroups.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"x86@kernel.org" <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 2/3] asm-generic, x86: wrap atomic operations
Date: Tue, 28 Mar 2017 09:52:32 +0200	[thread overview]
Message-ID: <20170328075232.GA19590@gmail.com> (raw)
In-Reply-To: <CACT4Y+YaFhVpu8-37=rOfOT1UN5K_bKMsMVQ+qiPZUWuSSERuw@mail.gmail.com>


* Dmitry Vyukov <dvyukov@google.com> wrote:

> On Fri, Mar 24, 2017 at 11:57 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Dmitry Vyukov <dvyukov@google.com> wrote:
> >
> >> > Are just utterly disgusting that turn perfectly readable code into an
> >> > unreadable, unmaintainable mess.
> >> >
> >> > You need to find some better, cleaner solution please, or convince me that no
> >> > such solution is possible. NAK for the time being.
> >>
> >> Well, I can just write all functions as is. Does it better confirm to kernel
> >> style?
> >
> > I think writing the prototypes out as-is, properly organized, beats any of these
> > macro based solutions.
> 
> You mean write out the prototypes, but use what for definitions? Macros again?

No, regular C code.

I don't see the point of generating all this code via CPP - it's certainly not 
making it more readable to me. I.e. this patch I commented on is a step backwards 
for readability.

I'd prefer repetition and a higher overall line count over complex CPP constructs.

Thanks,

	Ingo

  reply	other threads:[~2017-03-28  7:52 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14 19:24 [PATCH 0/3] x86, kasan: add KASAN checks to atomic operations Dmitry Vyukov
2017-03-14 19:24 ` Dmitry Vyukov
2017-03-14 19:24 ` [PATCH 1/3] kasan: allow kasan_check_read/write() to accept pointers to volatiles Dmitry Vyukov
2017-03-14 19:24   ` Dmitry Vyukov
2017-03-14 19:24 ` [PATCH 2/3] asm-generic, x86: wrap atomic operations Dmitry Vyukov
2017-03-14 19:24   ` Dmitry Vyukov
2017-03-20 16:41   ` Andrey Ryabinin
2017-03-20 16:41     ` Andrey Ryabinin
2017-03-20 17:17   ` Mark Rutland
2017-03-20 17:17     ` Mark Rutland
2017-03-21  9:25     ` Andrey Ryabinin
2017-03-21  9:25       ` Andrey Ryabinin
2017-03-21 10:41       ` Mark Rutland
2017-03-21 10:41         ` Mark Rutland
2017-03-21 18:06         ` Dmitry Vyukov
2017-03-21 18:06           ` Dmitry Vyukov
2017-03-21 21:20           ` Arnd Bergmann
2017-03-21 21:20             ` Arnd Bergmann
2017-03-22 10:42             ` Dmitry Vyukov
2017-03-22 10:42               ` Dmitry Vyukov
2017-03-22 11:30               ` Arnd Bergmann
2017-03-22 11:30                 ` Arnd Bergmann
2017-03-22 12:14                 ` Dmitry Vyukov
2017-03-22 12:14                   ` Dmitry Vyukov
2017-03-22 12:48                   ` Arnd Bergmann
2017-03-22 12:48                     ` Arnd Bergmann
2017-03-24  6:52   ` Ingo Molnar
2017-03-24  6:52     ` Ingo Molnar
2017-03-24  7:14     ` Dmitry Vyukov
2017-03-24  7:14       ` Dmitry Vyukov
2017-03-24  8:39       ` Dmitry Vyukov
2017-03-24  8:39         ` Dmitry Vyukov
2017-03-24 10:57       ` Ingo Molnar
2017-03-24 10:57         ` Ingo Molnar
2017-03-24 12:46         ` Dmitry Vyukov
2017-03-24 12:46           ` Dmitry Vyukov
2017-03-28  7:52           ` Ingo Molnar [this message]
2017-03-28  7:52             ` Ingo Molnar
2017-03-28  9:27             ` Peter Zijlstra
2017-03-28  9:27               ` Peter Zijlstra
2017-03-28  9:46               ` Dmitry Vyukov
2017-03-28  9:46                 ` Dmitry Vyukov
2017-03-28  9:51               ` Ingo Molnar
2017-03-28  9:51                 ` Ingo Molnar
2017-03-28  9:56                 ` Dmitry Vyukov
2017-03-28  9:56                   ` Dmitry Vyukov
2017-03-28 10:15                   ` Ingo Molnar
2017-03-28 10:15                     ` Ingo Molnar
2017-03-28 16:29                     ` Dmitry Vyukov
2017-03-28 16:29                       ` Dmitry Vyukov
2017-03-14 19:24 ` [PATCH 3/3] asm-generic: add KASAN instrumentation to " Dmitry Vyukov
2017-03-14 19:24   ` Dmitry Vyukov
2017-03-30 22:30 ` [PATCH 0/3] x86, kasan: add KASAN checks " Andrew Morton
2017-03-30 22:30   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170328075232.GA19590@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=dvyukov@google.com \
    --cc=hpa@zytor.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.