From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Enric Balletbo i Serra
<enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bryan Freed <bfreed-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH v3] tpm: Apply a sane minimum adapterlimit value for retransmission.
Date: Tue, 28 Mar 2017 18:20:44 +0200 [thread overview]
Message-ID: <20170328162044.GA29742@lunn.ch> (raw)
In-Reply-To: <20170328152938.14539-1-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
On Tue, Mar 28, 2017 at 05:29:38PM +0200, Enric Balletbo i Serra wrote:
> From: Bryan Freed <bfreed-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> When the I2C Infineon part is attached to an I2C adapter that imposes
> a size limitation, large requests will fail with -EOPNOTSUPP. Retry
> them with a sane minimum size without re-issuing the 0x05 command
> as this appears to occasionally put the TPM in a bad state.
>
> Signed-off-by: Bryan Freed <bfreed-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> [rework the patch to adapt to the feedback received]
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
This looks O.K. now. Thanks for remembering the adaptor limit.
Acked-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Andrew
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
wsa@the-dreams.de,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Bryan Freed <bfreed@chromium.org>
Subject: Re: [PATCH v3] tpm: Apply a sane minimum adapterlimit value for retransmission.
Date: Tue, 28 Mar 2017 18:20:44 +0200 [thread overview]
Message-ID: <20170328162044.GA29742@lunn.ch> (raw)
In-Reply-To: <20170328152938.14539-1-enric.balletbo@collabora.com>
On Tue, Mar 28, 2017 at 05:29:38PM +0200, Enric Balletbo i Serra wrote:
> From: Bryan Freed <bfreed@chromium.org>
>
> When the I2C Infineon part is attached to an I2C adapter that imposes
> a size limitation, large requests will fail with -EOPNOTSUPP. Retry
> them with a sane minimum size without re-issuing the 0x05 command
> as this appears to occasionally put the TPM in a bad state.
>
> Signed-off-by: Bryan Freed <bfreed@chromium.org>
> [rework the patch to adapt to the feedback received]
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
This looks O.K. now. Thanks for remembering the adaptor limit.
Acked-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-03-28 16:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 15:29 [PATCH v3] tpm: Apply a sane minimum adapterlimit value for retransmission Enric Balletbo i Serra
2017-03-28 15:29 ` Enric Balletbo i Serra
[not found] ` <20170328152938.14539-1-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2017-03-28 16:20 ` Andrew Lunn [this message]
2017-03-28 16:20 ` Andrew Lunn
2017-03-31 8:13 ` Jarkko Sakkinen
2017-04-05 9:03 ` Jarkko Sakkinen
[not found] ` <20170405090327.pssnm3mjcpajpoy6-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-04-05 10:05 ` Peter Huewe
2017-04-05 10:05 ` Peter Huewe
[not found] ` <384D02FC-BCCF-45F0-896D-058326EC6783-Mmb7MZpHnFY@public.gmane.org>
2017-04-05 13:37 ` Jarkko Sakkinen
2017-04-05 13:37 ` Jarkko Sakkinen
2017-04-05 13:24 ` Andrew Lunn
2017-04-05 13:24 ` Andrew Lunn
[not found] ` <20170405132431.GA11583-g2DYL2Zd6BY@public.gmane.org>
2017-04-05 13:35 ` Jarkko Sakkinen
2017-04-05 13:35 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2017-05-22 9:20 Enric Balletbo i Serra
2017-05-24 19:10 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328162044.GA29742@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=bfreed-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.