From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/8] arm64: mm: mark fault_info __ro_after_init
Date: Wed, 29 Mar 2017 12:23:26 +0100 [thread overview]
Message-ID: <20170329112326.GE23442@leverpostej> (raw)
In-Reply-To: <20170328213431.10904-3-opendmb@gmail.com>
On Tue, Mar 28, 2017 at 02:34:25PM -0700, Doug Berger wrote:
> The fault_info table must be made writeable to allow installation
> of custom memory abort handlers, but it can be made read-only
> after initialization to provide some protection.
>
> Signed-off-by: Doug Berger <opendmb@gmail.com>
Thanks for putting this together. I agree that making this RO is good.
However, I also think that we should not allow arbitrary hooking of
fault codes, and thus this can be const.
Thanks,
Mark.
> ---
> arch/arm64/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index cdf1260f1005..43319ed58a47 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -493,7 +493,7 @@ static struct fault_info {
> int sig;
> int code;
> const char *name;
> -} fault_info[] = {
> +} fault_info[] __ro_after_init = {
> { do_bad, SIGBUS, 0, "ttbr address size fault" },
> { do_bad, SIGBUS, 0, "level 1 address size fault" },
> { do_bad, SIGBUS, 0, "level 2 address size fault" },
> --
> 2.12.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Doug Berger <opendmb@gmail.com>
Cc: wangkefeng.wang@huawei.com, catalin.marinas@arm.com,
linus.walleij@linaro.org, will.deacon@arm.com, mingo@kernel.org,
f.fainelli@gmail.com, jonathanh@nvidia.com,
bgolaszewski@baylibre.com, bcm-kernel-feedback-list@broadcom.com,
shijie.huang@arm.com, treding@nvidia.com,
devicetree@vger.kernel.org, suzuki.poulose@arm.com,
robh+dt@kernel.org, gregory.0xf0@gmail.com,
sandeepa.s.prabhu@gmail.com,
linux-arm-kernel@lists.infradead.org, mirza.krak@gmail.com,
linux-kernel@vger.kernel.org, james.morse@arm.com,
olof@lixom.net, computersforpeace@gmail.com
Subject: Re: [PATCH v2 2/8] arm64: mm: mark fault_info __ro_after_init
Date: Wed, 29 Mar 2017 12:23:26 +0100 [thread overview]
Message-ID: <20170329112326.GE23442@leverpostej> (raw)
In-Reply-To: <20170328213431.10904-3-opendmb@gmail.com>
On Tue, Mar 28, 2017 at 02:34:25PM -0700, Doug Berger wrote:
> The fault_info table must be made writeable to allow installation
> of custom memory abort handlers, but it can be made read-only
> after initialization to provide some protection.
>
> Signed-off-by: Doug Berger <opendmb@gmail.com>
Thanks for putting this together. I agree that making this RO is good.
However, I also think that we should not allow arbitrary hooking of
fault codes, and thus this can be const.
Thanks,
Mark.
> ---
> arch/arm64/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index cdf1260f1005..43319ed58a47 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -493,7 +493,7 @@ static struct fault_info {
> int sig;
> int code;
> const char *name;
> -} fault_info[] = {
> +} fault_info[] __ro_after_init = {
> { do_bad, SIGBUS, 0, "ttbr address size fault" },
> { do_bad, SIGBUS, 0, "level 1 address size fault" },
> { do_bad, SIGBUS, 0, "level 2 address size fault" },
> --
> 2.12.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Doug Berger <opendmb@gmail.com>
Cc: robh+dt@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com,
computersforpeace@gmail.com, gregory.0xf0@gmail.com,
f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com,
wangkefeng.wang@huawei.com, james.morse@arm.com,
mingo@kernel.org, sandeepa.s.prabhu@gmail.com,
shijie.huang@arm.com, linus.walleij@linaro.org,
treding@nvidia.com, jonathanh@nvidia.com, olof@lixom.net,
mirza.krak@gmail.com, suzuki.poulose@arm.com,
bgolaszewski@baylibre.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/8] arm64: mm: mark fault_info __ro_after_init
Date: Wed, 29 Mar 2017 12:23:26 +0100 [thread overview]
Message-ID: <20170329112326.GE23442@leverpostej> (raw)
In-Reply-To: <20170328213431.10904-3-opendmb@gmail.com>
On Tue, Mar 28, 2017 at 02:34:25PM -0700, Doug Berger wrote:
> The fault_info table must be made writeable to allow installation
> of custom memory abort handlers, but it can be made read-only
> after initialization to provide some protection.
>
> Signed-off-by: Doug Berger <opendmb@gmail.com>
Thanks for putting this together. I agree that making this RO is good.
However, I also think that we should not allow arbitrary hooking of
fault codes, and thus this can be const.
Thanks,
Mark.
> ---
> arch/arm64/mm/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index cdf1260f1005..43319ed58a47 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -493,7 +493,7 @@ static struct fault_info {
> int sig;
> int code;
> const char *name;
> -} fault_info[] = {
> +} fault_info[] __ro_after_init = {
> { do_bad, SIGBUS, 0, "ttbr address size fault" },
> { do_bad, SIGBUS, 0, "level 1 address size fault" },
> { do_bad, SIGBUS, 0, "level 2 address size fault" },
> --
> 2.12.0
>
next prev parent reply other threads:[~2017-03-29 11:23 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 21:34 [PATCH v2 0/8] bus: brcmstb_gisb: add support for GISBv7 arbiter Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-28 21:34 ` [PATCH v2 1/8] arm64: mm: Allow installation of memory abort handlers Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-29 11:32 ` Mark Rutland
2017-03-29 11:32 ` Mark Rutland
2017-03-28 21:34 ` [PATCH v2 2/8] arm64: mm: mark fault_info __ro_after_init Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-29 11:23 ` Mark Rutland [this message]
2017-03-29 11:23 ` Mark Rutland
2017-03-29 11:23 ` Mark Rutland
2017-03-28 21:34 ` [PATCH v2 3/8] bus: brcmstb_gisb: Use register offsets with writes too Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-28 21:34 ` [PATCH v2 4/8] bus: brcmstb_gisb: Correct hooking of ARM aborts Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-28 21:34 ` [PATCH v2 5/8] bus: brcmstb_gisb: correct support for 64-bit address output Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-28 21:34 ` [PATCH v2 6/8] bus: brcmstb_gisb: Add ARM64 support Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-29 11:20 ` Mark Rutland
2017-03-29 11:20 ` Mark Rutland
2017-03-29 11:20 ` Mark Rutland
2017-03-28 21:34 ` [PATCH v2 7/8] bus: brcmstb_gisb: add notifier handling Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-29 10:13 ` Mark Rutland
2017-03-29 10:13 ` Mark Rutland
2017-03-29 10:13 ` Mark Rutland
2017-03-29 17:39 ` Doug Berger
2017-03-29 17:39 ` Doug Berger
2017-03-29 17:39 ` Doug Berger
2017-03-29 18:17 ` Mark Rutland
2017-03-29 18:17 ` Mark Rutland
2017-03-28 21:34 ` [PATCH v2 8/8] bus: brcmstb_gisb: update to support new revision Doug Berger
2017-03-28 21:34 ` Doug Berger
2017-03-29 11:25 ` Mark Rutland
2017-03-29 11:25 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329112326.GE23442@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.