All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: cera@cera.cz, mlxsw@mellanox.com,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	netdev@vger.kernel.org, peter@svinota.eu,
	bridge@lists.linux-foundation.org, idosch@mellanox.com,
	davem@davemloft.net
Subject: Re: [Bridge] [PATCH net] bridge: netlink: register netdevice before executing changelink
Date: Fri, 7 Apr 2017 21:16:49 +0300	[thread overview]
Message-ID: <20170407181649.GA21938@splinter> (raw)
In-Reply-To: <20170407133753.1602f3cd@plumbers-lap.home.lan>

On Fri, Apr 07, 2017 at 01:37:53PM -0400, Stephen Hemminger wrote:
> Fix it right now. The patch you propose is too half baked.

Given this patch needs to be back ported to three different stable
kernels I tried to keep the amount of changes to a minimum while fixing
the bug.

I'll work on the ndo_uninit() patch and submit it. Then people can
decide which course of action they're more comfortable with.

WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: cera@cera.cz, mlxsw@mellanox.com,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	netdev@vger.kernel.org, peter@svinota.eu,
	bridge@lists.linux-foundation.org, idosch@mellanox.com,
	davem@davemloft.net
Subject: Re: [PATCH net] bridge: netlink: register netdevice before executing changelink
Date: Fri, 7 Apr 2017 21:16:49 +0300	[thread overview]
Message-ID: <20170407181649.GA21938@splinter> (raw)
In-Reply-To: <20170407133753.1602f3cd@plumbers-lap.home.lan>

On Fri, Apr 07, 2017 at 01:37:53PM -0400, Stephen Hemminger wrote:
> Fix it right now. The patch you propose is too half baked.

Given this patch needs to be back ported to three different stable
kernels I tried to keep the amount of changes to a minimum while fixing
the bug.

I'll work on the ndo_uninit() patch and submit it. Then people can
decide which course of action they're more comfortable with.

  reply	other threads:[~2017-04-07 18:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 12:49 [Bridge] [PATCH net] bridge: netlink: register netdevice before executing changelink idosch
2017-04-07 12:49 ` idosch
2017-04-07 14:10 ` [Bridge] " Stephen Hemminger
2017-04-07 14:10   ` Stephen Hemminger
2017-04-07 14:19   ` [Bridge] " Nikolay Aleksandrov
2017-04-07 14:19     ` Nikolay Aleksandrov via Bridge
2017-04-07 15:22     ` [Bridge] " Stephen Hemminger
2017-04-07 15:22       ` Stephen Hemminger
2017-04-07 15:27       ` [Bridge] " Nikolay Aleksandrov
2017-04-07 15:27         ` Nikolay Aleksandrov
2017-04-07 15:36         ` [Bridge] " Stephen Hemminger
2017-04-07 15:36           ` Stephen Hemminger
2017-04-07 15:43           ` [Bridge] " Nikolay Aleksandrov
2017-04-07 15:43             ` Nikolay Aleksandrov via Bridge
2017-04-07 17:37             ` [Bridge] " Stephen Hemminger
2017-04-07 17:37               ` Stephen Hemminger
2017-04-07 18:16               ` Ido Schimmel [this message]
2017-04-07 18:16                 ` Ido Schimmel
2017-04-07 18:44                 ` [Bridge] " Stephen Hemminger
2017-04-07 18:44                   ` Stephen Hemminger
2017-04-07 18:45                 ` [Bridge] " Stephen Hemminger
2017-04-07 18:45                   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407181649.GA21938@splinter \
    --to=idosch@idosch.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=cera@cera.cz \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=peter@svinota.eu \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.