From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
jason@lakedaemon.net, andrew@lunn.ch,
gregory.clement@free-electrons.com,
sebastian.hesselbarth@gmail.com, linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
boris.brezillon@free-electrons.com, oferh@marvell.com,
igall@marvell.com, nadavh@marvell.com
Subject: Re: [PATCH 4/7] arm64: marvell: dts: add crypto engine description for 7k/8k
Date: Wed, 12 Apr 2017 10:56:08 +0200 [thread overview]
Message-ID: <20170412105608.41501b63@free-electrons.com> (raw)
In-Reply-To: <20170329124432.27457-5-antoine.tenart@free-electrons.com>
Hello,
On Wed, 29 Mar 2017 14:44:29 +0200, Antoine Tenart wrote:
> + cpm_crypto: crypto@800000 {
> + compatible = "inside-secure,safexcel-eip197";
> + reg = <0x800000 0x200000>;
> + interrupts = <GIC_SPI 34 (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_LEVEL_HIGH)>,
Now that I look into this, does it makes sense for an interrupt to be
both an edge interrupt and a level interrupt at the same time? This
looks odd.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] arm64: marvell: dts: add crypto engine description for 7k/8k
Date: Wed, 12 Apr 2017 10:56:08 +0200 [thread overview]
Message-ID: <20170412105608.41501b63@free-electrons.com> (raw)
In-Reply-To: <20170329124432.27457-5-antoine.tenart@free-electrons.com>
Hello,
On Wed, 29 Mar 2017 14:44:29 +0200, Antoine Tenart wrote:
> + cpm_crypto: crypto at 800000 {
> + compatible = "inside-secure,safexcel-eip197";
> + reg = <0x800000 0x200000>;
> + interrupts = <GIC_SPI 34 (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_LEVEL_HIGH)>,
Now that I look into this, does it makes sense for an interrupt to be
both an edge interrupt and a level interrupt at the same time? This
looks odd.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-12 8:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 12:44 [PATCH 0/7] arm64: marvell: add cryptographic engine support for 7k/8k Antoine Tenart
2017-03-29 12:44 ` Antoine Tenart
2017-03-29 12:44 ` [PATCH 1/7] Documentation/bindings: Document the SafeXel cryptographic engine driver Antoine Tenart
2017-03-29 12:44 ` Antoine Tenart
2017-03-29 12:44 ` [PATCH 2/7] crypto: inside-secure: add SafeXcel EIP197 crypto " Antoine Tenart
2017-03-29 12:44 ` Antoine Tenart
2017-04-12 13:54 ` Robin Murphy
2017-04-12 13:54 ` Robin Murphy
2017-04-18 8:04 ` Antoine Tenart
2017-04-18 8:04 ` Antoine Tenart
2017-03-29 12:44 ` [PATCH 3/7] MAINTAINERS: add a maintainer for the Inside Secure crypto driver Antoine Tenart
2017-03-29 12:44 ` Antoine Tenart
2017-03-29 12:44 ` [PATCH 4/7] arm64: marvell: dts: add crypto engine description for 7k/8k Antoine Tenart
2017-03-29 12:44 ` Antoine Tenart
2017-04-12 8:36 ` Gregory CLEMENT
2017-04-12 8:36 ` Gregory CLEMENT
2017-04-12 8:56 ` Thomas Petazzoni [this message]
2017-04-12 8:56 ` Thomas Petazzoni
2017-04-18 7:34 ` Antoine Tenart
2017-04-18 7:34 ` Antoine Tenart
2017-03-29 12:44 ` [PATCH 5/7] arm64: marvell: dts: enable the crypto engine on the Armada 7040 DB Antoine Tenart
2017-03-29 12:44 ` Antoine Tenart
2017-04-12 8:36 ` Gregory CLEMENT
2017-04-12 8:36 ` Gregory CLEMENT
2017-03-29 12:44 ` [PATCH 6/7] arm64: marvell: dts: enable the crypto engine on the Armada 8040 DB Antoine Tenart
2017-03-29 12:44 ` Antoine Tenart
2017-04-12 8:37 ` Gregory CLEMENT
2017-04-12 8:37 ` Gregory CLEMENT
2017-03-29 12:44 ` [PATCH 7/7] arm64: defconfig: enable the Safexcel crypto engine as a module Antoine Tenart
2017-03-29 12:44 ` Antoine Tenart
2017-04-12 8:38 ` Gregory CLEMENT
2017-04-12 8:38 ` Gregory CLEMENT
2017-04-10 9:39 ` [PATCH 0/7] arm64: marvell: add cryptographic engine support for 7k/8k Herbert Xu
2017-04-10 9:39 ` Herbert Xu
2017-04-11 16:12 ` Gregory CLEMENT
2017-04-11 16:12 ` Gregory CLEMENT
2017-04-12 6:11 ` Herbert Xu
2017-04-12 6:11 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412105608.41501b63@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=herbert@gondor.apana.org.au \
--cc=igall@marvell.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=nadavh@marvell.com \
--cc=oferh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.