All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: checking for NULL instead of IS_ERR() in mock selftests
@ 2017-04-13 19:52 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-04-13 19:52 UTC (permalink / raw)
  To: Daniel Vetter, Chris Wilson
  Cc: dri-devel, Arnd Bergmann, Tvrtko Ursulin, intel-gfx,
	Joonas Lahtinen, kernel-janitors, Matthew Auld

i915_gem_request_alloc() uses error pointers.  It never returns NULLs.

Fixes: 0daf0113cff6 ("drm/i915: Mock infrastructure for request emission")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/i915/selftests/mock_request.c b/drivers/gpu/drm/i915/selftests/mock_request.c
index 0e8d2e7f8c70..8097e3693ec4 100644
--- a/drivers/gpu/drm/i915/selftests/mock_request.c
+++ b/drivers/gpu/drm/i915/selftests/mock_request.c
@@ -35,7 +35,7 @@ mock_request(struct intel_engine_cs *engine,
 
 	/* NB the i915->requests slab cache is enlarged to fit mock_request */
 	request = i915_gem_request_alloc(engine, context);
-	if (!request)
+	if (IS_ERR(request))
 		return NULL;
 
 	mock = container_of(request, typeof(*mock), base);

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/i915: checking for NULL instead of IS_ERR() in mock selftests
@ 2017-04-13 19:52 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-04-13 19:52 UTC (permalink / raw)
  To: Daniel Vetter, Chris Wilson
  Cc: dri-devel, Arnd Bergmann, Tvrtko Ursulin, intel-gfx,
	Joonas Lahtinen, kernel-janitors, Matthew Auld

i915_gem_request_alloc() uses error pointers.  It never returns NULLs.

Fixes: 0daf0113cff6 ("drm/i915: Mock infrastructure for request emission")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/i915/selftests/mock_request.c b/drivers/gpu/drm/i915/selftests/mock_request.c
index 0e8d2e7f8c70..8097e3693ec4 100644
--- a/drivers/gpu/drm/i915/selftests/mock_request.c
+++ b/drivers/gpu/drm/i915/selftests/mock_request.c
@@ -35,7 +35,7 @@ mock_request(struct intel_engine_cs *engine,
 
 	/* NB the i915->requests slab cache is enlarged to fit mock_request */
 	request = i915_gem_request_alloc(engine, context);
-	if (!request)
+	if (IS_ERR(request))
 		return NULL;
 
 	mock = container_of(request, typeof(*mock), base);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: checking for NULL instead of IS_ERR() in mock selftests
  2017-04-13 19:52 ` Dan Carpenter
@ 2017-04-13 20:26   ` Chris Wilson
  -1 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2017-04-13 20:26 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Daniel Vetter, Jani Nikula, David Airlie, Tvrtko Ursulin,
	Joonas Lahtinen, Matthew Auld, Arnd Bergmann, intel-gfx,
	dri-devel, kernel-janitors

On Thu, Apr 13, 2017 at 10:52:17PM +0300, Dan Carpenter wrote:
> i915_gem_request_alloc() uses error pointers.  It never returns NULLs.
> 
> Fixes: 0daf0113cff6 ("drm/i915: Mock infrastructure for request emission")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks for the catch.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: checking for NULL instead of IS_ERR() in mock selftests
@ 2017-04-13 20:26   ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2017-04-13 20:26 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Daniel Vetter, Jani Nikula, David Airlie, Tvrtko Ursulin,
	Joonas Lahtinen, Matthew Auld, Arnd Bergmann, intel-gfx,
	dri-devel, kernel-janitors

On Thu, Apr 13, 2017 at 10:52:17PM +0300, Dan Carpenter wrote:
> i915_gem_request_alloc() uses error pointers.  It never returns NULLs.
> 
> Fixes: 0daf0113cff6 ("drm/i915: Mock infrastructure for request emission")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks for the catch.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: checking for NULL instead of IS_ERR() in mock selftests
  2017-04-13 19:52 ` Dan Carpenter
  (?)
  (?)
@ 2017-04-13 21:02 ` Patchwork
  2017-04-13 21:17   ` Chris Wilson
  -1 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2017-04-13 21:02 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: checking for NULL instead of IS_ERR() in mock selftests
URL   : https://patchwork.freedesktop.org/series/23040/
State : success

== Summary ==

Series 23040v1 drm/i915: checking for NULL instead of IS_ERR() in mock selftests
https://patchwork.freedesktop.org/api/1.0/series/23040/revisions/1/mbox/

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:429s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:433s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:577s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:504s
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20  time:549s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time:485s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:480s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:406s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:407s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time:411s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:489s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:480s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:459s
fi-kbl-7560u     total:278  pass:267  dwarn:1   dfail:0   fail:0   skip:10  time:573s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:449s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time:568s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:466s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:492s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:432s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:524s
fi-snb-2600      total:278  pass:249  dwarn:0   dfail:0   fail:0   skip:29  time:408s

0a54b7fee9ecda9257d34e5c3ac8de6516a60a90 drm-tip: 2017y-04m-13d-19h-12m-59s UTC integration manifest
b5ac781 drm/i915: checking for NULL instead of IS_ERR() in mock selftests

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4506/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: ✓ Fi.CI.BAT: success for drm/i915: checking for NULL instead of IS_ERR() in mock selftests
  2017-04-13 21:02 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-04-13 21:17   ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2017-04-13 21:17 UTC (permalink / raw)
  To: intel-gfx; +Cc: Dan Carpenter

On Thu, Apr 13, 2017 at 09:02:15PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: checking for NULL instead of IS_ERR() in mock selftests
> URL   : https://patchwork.freedesktop.org/series/23040/
> State : success
> 
> == Summary ==
> 
> Series 23040v1 drm/i915: checking for NULL instead of IS_ERR() in mock selftests
> https://patchwork.freedesktop.org/api/1.0/series/23040/revisions/1/mbox/

Thanks for the patch, pushed.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-13 21:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-13 19:52 [PATCH] drm/i915: checking for NULL instead of IS_ERR() in mock selftests Dan Carpenter
2017-04-13 19:52 ` Dan Carpenter
2017-04-13 20:26 ` Chris Wilson
2017-04-13 20:26   ` Chris Wilson
2017-04-13 21:02 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-04-13 21:17   ` Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.