From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Hannes Reinecke <hare@suse.com>
Subject: [PATCH v3 5/8] blk-mq: Make blk_flags_show() callers append a newline character
Date: Tue, 18 Apr 2017 16:29:46 -0700 [thread overview]
Message-ID: <20170418232949.5228-6-bart.vanassche@sandisk.com> (raw)
In-Reply-To: <20170418232949.5228-1-bart.vanassche@sandisk.com>
This patch does not change any functionality but makes it possible
to produce a single line of output with multiple flag-to-name
translations.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Omar Sandoval <osandov@fb.com>
Cc: Hannes Reinecke <hare@suse.com>
---
block/blk-mq-debugfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index 34cac9a5fd28..27054293b37b 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -60,7 +60,6 @@ static int blk_flags_show(struct seq_file *m, const unsigned long flags,
else
seq_printf(m, "%d", i);
}
- seq_puts(m, "\n");
return 0;
}
@@ -102,6 +101,7 @@ static int blk_queue_flags_show(struct seq_file *m, void *v)
blk_flags_show(m, q->queue_flags, blk_queue_flag_name,
ARRAY_SIZE(blk_queue_flag_name));
+ seq_puts(m, "\n");
return 0;
}
@@ -190,6 +190,7 @@ static int hctx_state_show(struct seq_file *m, void *v)
blk_flags_show(m, hctx->state, hctx_state_name,
ARRAY_SIZE(hctx_state_name));
+ seq_puts(m, "\n");
return 0;
}
@@ -233,6 +234,7 @@ static int hctx_flags_show(struct seq_file *m, void *v)
blk_flags_show(m,
hctx->flags ^ BLK_ALLOC_POLICY_TO_MQ_FLAG(alloc_policy),
hctx_flag_name, ARRAY_SIZE(hctx_flag_name));
+ seq_puts(m, "\n");
return 0;
}
--
2.12.2
next prev parent reply other threads:[~2017-04-18 23:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 23:29 [PATCH v3 0/8] blk-mq debugfs patches for kernel v4.12 Bart Van Assche
2017-04-18 23:29 ` [PATCH v3 1/8] blk-mq: Register <dev>/queue/mq after having registered <dev>/queue Bart Van Assche
2017-04-21 22:05 ` Omar Sandoval
2017-04-21 22:09 ` Bart Van Assche
2017-04-21 22:11 ` Omar Sandoval
2017-04-18 23:29 ` [PATCH v3 2/8] blk-mq: Let blk_mq_debugfs_register() look up the queue name Bart Van Assche
2017-04-21 22:06 ` Omar Sandoval
2017-04-18 23:29 ` [PATCH v3 3/8] blk-mq: Unregister debugfs attributes earlier Bart Van Assche
2017-04-21 22:16 ` Omar Sandoval
2017-04-21 22:17 ` Omar Sandoval
2017-04-18 23:29 ` [PATCH v3 4/8] blk-mq: Move the "state" debugfs attribute one level down Bart Van Assche
2017-04-18 23:29 ` Bart Van Assche [this message]
2017-04-18 23:29 ` [PATCH v3 6/8] blk-mq: Show operation, cmd_flags and rq_flags names Bart Van Assche
2017-04-18 23:29 ` [PATCH v3 7/8] blk-mq: Add blk_mq_ops.show_rq() Bart Van Assche
2017-04-20 20:49 ` Omar Sandoval
2017-04-18 23:29 ` [PATCH v3 8/8] scsi: Implement blk_mq_ops.show_rq() Bart Van Assche
2017-04-18 23:29 ` Bart Van Assche
2017-04-19 23:25 ` Martin K. Petersen
2017-04-19 23:25 ` Martin K. Petersen
2017-04-19 23:29 ` Bart Van Assche
2017-04-19 23:29 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418232949.5228-6-bart.vanassche@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.