From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Omar Sandoval <osandov@fb.com>, Hannes Reinecke <hare@suse.com>
Subject: [PATCH v3 7/8] blk-mq: Add blk_mq_ops.show_rq()
Date: Tue, 18 Apr 2017 16:29:48 -0700 [thread overview]
Message-ID: <20170418232949.5228-8-bart.vanassche@sandisk.com> (raw)
In-Reply-To: <20170418232949.5228-1-bart.vanassche@sandisk.com>
This new callback function will be used in the next patch to show
more information about SCSI requests.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Omar Sandoval <osandov@fb.com>
Cc: Hannes Reinecke <hare@suse.com>
---
block/blk-mq-debugfs.c | 6 +++++-
include/linux/blk-mq.h | 6 ++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index 64b584ba576a..b1b669f98ea0 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -308,6 +308,7 @@ static const char *const rqf_name[] = {
static int blk_mq_debugfs_rq_show(struct seq_file *m, void *v)
{
struct request *rq = list_entry_rq(v);
+ const struct blk_mq_ops *const mq_ops = rq->q->mq_ops;
const unsigned int op = rq->cmd_flags & REQ_OP_MASK;
seq_printf(m, "%p {.op=", rq);
@@ -321,8 +322,11 @@ static int blk_mq_debugfs_rq_show(struct seq_file *m, void *v)
seq_puts(m, ", .rq_flags=");
blk_flags_show(m, (__force unsigned int)rq->rq_flags, rqf_name,
ARRAY_SIZE(rqf_name));
- seq_printf(m, ", .tag=%d, .internal_tag=%d}\n", rq->tag,
+ seq_printf(m, ", .tag=%d, .internal_tag=%d", rq->tag,
rq->internal_tag);
+ if (mq_ops->show_rq)
+ mq_ops->show_rq(m, rq);
+ seq_puts(m, "}\n");
return 0;
}
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index d75de612845d..a761d275cb44 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -121,6 +121,12 @@ struct blk_mq_ops {
softirq_done_fn *complete;
/*
+ * Used by the debugfs implementation to show driver-specific
+ * information about a request.
+ */
+ void (*show_rq)(struct seq_file *m, struct request *rq);
+
+ /*
* Called when the block layer side of a hardware queue has been
* set up, allowing the driver to allocate/init matching structures.
* Ditto for exit/teardown.
--
2.12.2
next prev parent reply other threads:[~2017-04-18 23:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 23:29 [PATCH v3 0/8] blk-mq debugfs patches for kernel v4.12 Bart Van Assche
2017-04-18 23:29 ` [PATCH v3 1/8] blk-mq: Register <dev>/queue/mq after having registered <dev>/queue Bart Van Assche
2017-04-21 22:05 ` Omar Sandoval
2017-04-21 22:09 ` Bart Van Assche
2017-04-21 22:11 ` Omar Sandoval
2017-04-18 23:29 ` [PATCH v3 2/8] blk-mq: Let blk_mq_debugfs_register() look up the queue name Bart Van Assche
2017-04-21 22:06 ` Omar Sandoval
2017-04-18 23:29 ` [PATCH v3 3/8] blk-mq: Unregister debugfs attributes earlier Bart Van Assche
2017-04-21 22:16 ` Omar Sandoval
2017-04-21 22:17 ` Omar Sandoval
2017-04-18 23:29 ` [PATCH v3 4/8] blk-mq: Move the "state" debugfs attribute one level down Bart Van Assche
2017-04-18 23:29 ` [PATCH v3 5/8] blk-mq: Make blk_flags_show() callers append a newline character Bart Van Assche
2017-04-18 23:29 ` [PATCH v3 6/8] blk-mq: Show operation, cmd_flags and rq_flags names Bart Van Assche
2017-04-18 23:29 ` Bart Van Assche [this message]
2017-04-20 20:49 ` [PATCH v3 7/8] blk-mq: Add blk_mq_ops.show_rq() Omar Sandoval
2017-04-18 23:29 ` [PATCH v3 8/8] scsi: Implement blk_mq_ops.show_rq() Bart Van Assche
2017-04-18 23:29 ` Bart Van Assche
2017-04-19 23:25 ` Martin K. Petersen
2017-04-19 23:25 ` Martin K. Petersen
2017-04-19 23:29 ` Bart Van Assche
2017-04-19 23:29 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418232949.5228-8-bart.vanassche@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.