Re: [PATCH v3 1/8] blk-mq: Register <dev>/queue/mq after having registered <dev>/queue

[Omar Sandoval <osandov@osandov.com>]

On Fri, Apr 21, 2017 at 10:09:14PM +0000, Bart Van Assche wrote:
> On Fri, 2017-04-21 at 15:05 -0700, Omar Sandoval wrote:
> > On Tue, Apr 18, 2017 at 04:29:42PM -0700, Bart Van Assche wrote:
> > > +int blk_mq_register_dev(struct device *dev, struct request_queue *q)
> > > +{
> > > +	int ret;
> > > +
> > > +	ret = mutex_lock_interruptible(&q->sysfs_lock);
> > 
> > Why did you make this interruptible? blk_mq_disable_hotplug() wasn't
> > interruptible before, so now dm_mq_init_request_queue() can fail
> > silently if it is interrupted.
> 
> Hello Omar,
> 
> Whether or not blk_mq_register_dev() should be interruptible is not that
> important to me. I can change this function such that it again ignores
> signals.
> 
> Bart.

Keeping the old behavior is safer, let's do that.