From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH 4/5] nvme: Adjust the Samsung APST quirk
Date: Wed, 19 Apr 2017 21:07:12 -0600 [thread overview]
Message-ID: <20170420030711.GB23085@kernel.dk> (raw)
In-Reply-To: <a3e55fbb6afca363fcae66ca7d30f1175793594b.1492656278.git.luto@kernel.org>
On Wed, Apr 19 2017, Andy Lutomirski wrote:
> I got a couple more reports: the Samsung APST issues appears to
> affect multiple 950-series devices in Dell XPS 15 9550 and Precision
> 5510 laptops. Change the quirk: rather than blacklisting the
> firmware on the first problematic SSD that was reported, disable
> APST on all 144d:a802 devices if they're installed in the two
> affected Dell models. While we're at it, disable only the deepest
> sleep state instead of all of them -- the reporters say that this is
> sufficient to fix the problem.
>
> (I have a device that appears to be entirely identical to one of the
> affected devices, but I have a different Dell laptop, so it's not
> the case that all Samsung devices with firmware BXW75D0Q are broken
> under all circumstances.)
>
> Samsung engineers have an affected system, and hopefully they'll
> give us a better workaround some time soon. In the mean time, this
> should minimize regressions.
Do we know for a fact that it only happens on those systems, and isn't
purely specific to the device?
At this point in time, I'd be much more comfortable completely disabling
APST on Samsung, period.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Andy Lutomirski <luto@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
Niranjan Sivakumar <ns253@cornell.edu>
Subject: Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk
Date: Wed, 19 Apr 2017 21:07:12 -0600 [thread overview]
Message-ID: <20170420030711.GB23085@kernel.dk> (raw)
In-Reply-To: <a3e55fbb6afca363fcae66ca7d30f1175793594b.1492656278.git.luto@kernel.org>
On Wed, Apr 19 2017, Andy Lutomirski wrote:
> I got a couple more reports: the Samsung APST issues appears to
> affect multiple 950-series devices in Dell XPS 15 9550 and Precision
> 5510 laptops. Change the quirk: rather than blacklisting the
> firmware on the first problematic SSD that was reported, disable
> APST on all 144d:a802 devices if they're installed in the two
> affected Dell models. While we're at it, disable only the deepest
> sleep state instead of all of them -- the reporters say that this is
> sufficient to fix the problem.
>
> (I have a device that appears to be entirely identical to one of the
> affected devices, but I have a different Dell laptop, so it's not
> the case that all Samsung devices with firmware BXW75D0Q are broken
> under all circumstances.)
>
> Samsung engineers have an affected system, and hopefully they'll
> give us a better workaround some time soon. In the mean time, this
> should minimize regressions.
Do we know for a fact that it only happens on those systems, and isn't
purely specific to the device?
At this point in time, I'd be much more comfortable completely disabling
APST on Samsung, period.
--
Jens Axboe
next prev parent reply other threads:[~2017-04-20 3:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 3:02 [PATCH 0/5] nvme APST fixes/improvements for 4.11 Andy Lutomirski
2017-04-20 3:02 ` Andy Lutomirski
2017-04-20 3:02 ` [PATCH 1/5] nvme: Fix APST comment Andy Lutomirski
2017-04-20 3:02 ` Andy Lutomirski
2017-04-20 3:02 ` [PATCH 2/5] nvme: Display raw APST configuration via DYNAMIC_DEBUG Andy Lutomirski
2017-04-20 3:02 ` Andy Lutomirski
2017-04-20 3:02 ` [PATCH 3/5] nvme: Add nvme_core.force_apst to ignore the NO_APST quirk Andy Lutomirski
2017-04-20 3:02 ` Andy Lutomirski
2017-04-20 3:02 ` [PATCH 4/5] nvme: Adjust the Samsung APST quirk Andy Lutomirski
2017-04-20 3:02 ` Andy Lutomirski
2017-04-20 3:07 ` Jens Axboe [this message]
2017-04-20 3:07 ` Jens Axboe
2017-04-20 3:51 ` Andy Lutomirski
2017-04-20 3:51 ` Andy Lutomirski
2017-04-20 4:33 ` Judy Brock
2017-04-20 4:33 ` Judy Brock
2017-04-20 3:02 ` [PATCH 5/5] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA" Andy Lutomirski
2017-04-20 3:02 ` Andy Lutomirski
2017-04-20 3:10 ` [PATCH 0/5] nvme APST fixes/improvements for 4.11 Jens Axboe
2017-04-20 3:10 ` Jens Axboe
2017-04-20 3:55 ` Andy Lutomirski
2017-04-20 3:55 ` Andy Lutomirski
2017-04-20 4:52 ` Andy Lutomirski
2017-04-20 4:52 ` Andy Lutomirski
2017-04-20 5:19 ` Christoph Hellwig
2017-04-20 5:19 ` Christoph Hellwig
2017-04-20 16:01 ` Andy Lutomirski
2017-04-20 16:01 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420030711.GB23085@kernel.dk \
--to=axboe@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.