All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rcuperf: refix rcuperf sched_ops definition
@ 2017-04-20  8:12 Arnd Bergmann
  2017-04-20 15:35 ` Paul E. McKenney
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-04-20  8:12 UTC (permalink / raw)
  To: Paul E. McKenney, Josh Triplett
  Cc: Arnd Bergmann, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan,
	SeongJae Park, Ingo Molnar, linux-kernel

It looks like my fixup was incorrectly folded into the original patch,
and still leaves a duplicated initializer but drops the .sync
callback pointer.

This should rectify it, please fold it as well.

Fixes: df29028c2a9c ("rcuperf: Add ability to performance-test call_rcu() and friends")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/rcu/rcuperf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 1e2a1424d1f5..5158ddba6716 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -308,7 +308,7 @@ static struct rcu_perf_ops sched_ops = {
 	.exp_completed	= rcu_exp_batches_completed_sched,
 	.async		= call_rcu_sched,
 	.gp_barrier	= rcu_barrier_sched,
-	.async		= srcu_call_rcu,
+	.sync		= synchronize_sched,
 	.exp_sync	= synchronize_sched_expedited,
 	.name		= "sched"
 };
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rcuperf: refix rcuperf sched_ops definition
  2017-04-20  8:12 [PATCH] rcuperf: refix rcuperf sched_ops definition Arnd Bergmann
@ 2017-04-20 15:35 ` Paul E. McKenney
  0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2017-04-20 15:35 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Josh Triplett, Steven Rostedt, Mathieu Desnoyers, Lai Jiangshan,
	SeongJae Park, Ingo Molnar, linux-kernel

On Thu, Apr 20, 2017 at 10:12:31AM +0200, Arnd Bergmann wrote:
> It looks like my fixup was incorrectly folded into the original patch,
> and still leaves a duplicated initializer but drops the .sync
> callback pointer.
> 
> This should rectify it, please fold it as well.
> 
> Fixes: df29028c2a9c ("rcuperf: Add ability to performance-test call_rcu() and friends")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I really am not doing well on this commit, am I?  :-/

Thank you very much for your attention to detail and for the fixes!!!

							Thanx, Paul

> ---
>  kernel/rcu/rcuperf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
> index 1e2a1424d1f5..5158ddba6716 100644
> --- a/kernel/rcu/rcuperf.c
> +++ b/kernel/rcu/rcuperf.c
> @@ -308,7 +308,7 @@ static struct rcu_perf_ops sched_ops = {
>  	.exp_completed	= rcu_exp_batches_completed_sched,
>  	.async		= call_rcu_sched,
>  	.gp_barrier	= rcu_barrier_sched,
> -	.async		= srcu_call_rcu,
> +	.sync		= synchronize_sched,
>  	.exp_sync	= synchronize_sched_expedited,
>  	.name		= "sched"
>  };
> -- 
> 2.9.0
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-20 15:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-20  8:12 [PATCH] rcuperf: refix rcuperf sched_ops definition Arnd Bergmann
2017-04-20 15:35 ` Paul E. McKenney

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.