* [Qemu-devel] [PATCH] tests: Ignore another built executable
@ 2017-04-28 2:23 ` Eric Blake
0 siblings, 0 replies; 10+ messages in thread
From: Eric Blake @ 2017-04-28 2:23 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, thuth, dgilbert
Commit 78f86a2b7 added a new test, but forgot to exclude the built
binary from version control.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
tests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index 5ab00a9..40c2e3e 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -40,6 +40,7 @@ test-crypto-tlssession-server/
test-crypto-xts
test-cutils
test-hbitmap
+test-hmp
test-int128
test-iov
test-io-channel-buffer
--
2.9.3
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] tests: Ignore another built executable
2017-04-28 2:23 ` [Qemu-devel] " Eric Blake
@ 2017-04-28 2:58 ` Thomas Huth
-1 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2017-04-28 2:58 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: qemu-trivial, dgilbert
On 28.04.2017 04:23, Eric Blake wrote:
> Commit 78f86a2b7 added a new test, but forgot to exclude the built
> binary from version control.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> tests/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index 5ab00a9..40c2e3e 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -40,6 +40,7 @@ test-crypto-tlssession-server/
> test-crypto-xts
> test-cutils
> test-hbitmap
> +test-hmp
> test-int128
> test-iov
> test-io-channel-buffer
Ah, ok, I'm only doing out-of-tree builds, that's why I did not notice
this...
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: Ignore another built executable
@ 2017-04-28 2:58 ` Thomas Huth
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2017-04-28 2:58 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: qemu-trivial, dgilbert
On 28.04.2017 04:23, Eric Blake wrote:
> Commit 78f86a2b7 added a new test, but forgot to exclude the built
> binary from version control.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> tests/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index 5ab00a9..40c2e3e 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -40,6 +40,7 @@ test-crypto-tlssession-server/
> test-crypto-xts
> test-cutils
> test-hbitmap
> +test-hmp
> test-int128
> test-iov
> test-io-channel-buffer
Ah, ok, I'm only doing out-of-tree builds, that's why I did not notice
this...
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] tests: Ignore another built executable
2017-04-28 2:23 ` [Qemu-devel] " Eric Blake
@ 2017-04-28 8:54 ` Daniel P. Berrange
-1 siblings, 0 replies; 10+ messages in thread
From: Daniel P. Berrange @ 2017-04-28 8:54 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, qemu-trivial, thuth, dgilbert, famz
On Thu, Apr 27, 2017 at 09:23:29PM -0500, Eric Blake wrote:
> Commit 78f86a2b7 added a new test, but forgot to exclude the built
> binary from version control.
CC Fam
I wonder if the patchew test system could be made to report an error
if git identifies built files that are not ignored.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: Ignore another built executable
@ 2017-04-28 8:54 ` Daniel P. Berrange
0 siblings, 0 replies; 10+ messages in thread
From: Daniel P. Berrange @ 2017-04-28 8:54 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, qemu-trivial, thuth, dgilbert, famz
On Thu, Apr 27, 2017 at 09:23:29PM -0500, Eric Blake wrote:
> Commit 78f86a2b7 added a new test, but forgot to exclude the built
> binary from version control.
CC Fam
I wonder if the patchew test system could be made to report an error
if git identifies built files that are not ignored.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] tests: Ignore another built executable
2017-04-28 8:54 ` Daniel P. Berrange
@ 2017-05-05 6:55 ` Fam Zheng
-1 siblings, 0 replies; 10+ messages in thread
From: Fam Zheng @ 2017-05-05 6:55 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: Eric Blake, qemu-devel, qemu-trivial, thuth, dgilbert
On Fri, 04/28 09:54, Daniel P. Berrange wrote:
> On Thu, Apr 27, 2017 at 09:23:29PM -0500, Eric Blake wrote:
> > Commit 78f86a2b7 added a new test, but forgot to exclude the built
> > binary from version control.
>
> CC Fam
>
> I wonder if the patchew test system could be made to report an error
> if git identifies built files that are not ignored.
>
If we had .git in the docker tests that patchew uses, it would be easy. That's
an unfortunate dependency for a number of other features, I'll see what I can
do.
Fam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: Ignore another built executable
@ 2017-05-05 6:55 ` Fam Zheng
0 siblings, 0 replies; 10+ messages in thread
From: Fam Zheng @ 2017-05-05 6:55 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: Eric Blake, qemu-devel, qemu-trivial, thuth, dgilbert
On Fri, 04/28 09:54, Daniel P. Berrange wrote:
> On Thu, Apr 27, 2017 at 09:23:29PM -0500, Eric Blake wrote:
> > Commit 78f86a2b7 added a new test, but forgot to exclude the built
> > binary from version control.
>
> CC Fam
>
> I wonder if the patchew test system could be made to report an error
> if git identifies built files that are not ignored.
>
If we had .git in the docker tests that patchew uses, it would be easy. That's
an unfortunate dependency for a number of other features, I'll see what I can
do.
Fam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] tests: Ignore another built executable
2017-04-28 2:23 ` [Qemu-devel] " Eric Blake
@ 2017-05-05 6:18 ` Michael Tokarev
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2017-05-05 6:18 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: qemu-trivial, thuth, dgilbert
28.04.2017 05:23, Eric Blake wrote:
> Commit 78f86a2b7 added a new test, but forgot to exclude the built
> binary from version control.
Applied to -trivial (adding mention of test-hmp to subject), thanks!
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread