All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Kaehlcke <mka@chromium.org>
To: Daniel Vetter <daniel.vetter@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	David Airlie <airlied@linux.ie>
Cc: Grant Grundler <grundler@chromium.org>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Greg Hackmann <ghackmann@google.com>,
	Michael Davidson <md@google.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches
Date: Fri, 5 May 2017 10:26:36 -0700	[thread overview]
Message-ID: <20170505172636.GA128305@google.com> (raw)
In-Reply-To: <20170420215605.176722-1-mka@chromium.org>

El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit:

> In several instances the driver passes an 'enum pipe' value to a
> function expecting an 'enum transcoder' and viceversa. Since PIPE_x and
> TRANSCODER_x have the same values this doesn't cause functional
> problems. Still it is incorrect and causes clang to generate warnings
> like this:
> 
> drivers/gpu/drm/i915/intel_display.c:1844:34: warning: implicit
>   conversion from enumeration type 'enum transcoder' to different
>   enumeration type 'enum pipe' [-Wenum-conversion]
>     assert_fdi_rx_enabled(dev_priv, TRANSCODER_A);
> 
> Change the code to pass values of the type expected by the callee.
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 4 ++--
>  drivers/gpu/drm/i915/intel_dp.c      | 6 ++++--
>  drivers/gpu/drm/i915/intel_hdmi.c    | 6 ++++--
>  drivers/gpu/drm/i915/intel_sdvo.c    | 6 ++++--
>  4 files changed, 14 insertions(+), 8 deletions(-)

Ping, any comments on this patch?

(also excuses for the unintended use of the RESEND tag)

Cheers

Matthias
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Daniel Vetter <daniel.vetter@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	David Airlie <airlied@linux.ie>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Grant Grundler <grundler@chromium.org>,
	Greg Hackmann <ghackmann@google.com>,
	Michael Davidson <md@google.com>
Subject: Re: [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches
Date: Fri, 5 May 2017 10:26:36 -0700	[thread overview]
Message-ID: <20170505172636.GA128305@google.com> (raw)
In-Reply-To: <20170420215605.176722-1-mka@chromium.org>

El Thu, Apr 20, 2017 at 02:56:05PM -0700 Matthias Kaehlcke ha dit:

> In several instances the driver passes an 'enum pipe' value to a
> function expecting an 'enum transcoder' and viceversa. Since PIPE_x and
> TRANSCODER_x have the same values this doesn't cause functional
> problems. Still it is incorrect and causes clang to generate warnings
> like this:
> 
> drivers/gpu/drm/i915/intel_display.c:1844:34: warning: implicit
>   conversion from enumeration type 'enum transcoder' to different
>   enumeration type 'enum pipe' [-Wenum-conversion]
>     assert_fdi_rx_enabled(dev_priv, TRANSCODER_A);
> 
> Change the code to pass values of the type expected by the callee.
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 4 ++--
>  drivers/gpu/drm/i915/intel_dp.c      | 6 ++++--
>  drivers/gpu/drm/i915/intel_hdmi.c    | 6 ++++--
>  drivers/gpu/drm/i915/intel_sdvo.c    | 6 ++++--
>  4 files changed, 14 insertions(+), 8 deletions(-)

Ping, any comments on this patch?

(also excuses for the unintended use of the RESEND tag)

Cheers

Matthias

  parent reply	other threads:[~2017-05-05 17:26 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20 21:56 [PATCH RESEND] drm/i915: Fix pipe/transcoder enum mismatches Matthias Kaehlcke
2017-04-20 21:56 ` Matthias Kaehlcke
2017-04-20 22:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-05-05 17:26 ` Matthias Kaehlcke [this message]
2017-05-05 17:26   ` [PATCH RESEND] " Matthias Kaehlcke
2017-05-05 17:40   ` [Intel-gfx] " Ville Syrjälä
2017-05-05 17:40     ` Ville Syrjälä
2017-05-05 19:12     ` Grant Grundler
2017-05-05 19:12       ` [Intel-gfx] " Grant Grundler
2017-05-05 20:08       ` Ville Syrjälä
2017-05-05 20:08         ` Ville Syrjälä
2017-05-05 20:29         ` Grant Grundler
2017-05-05 20:29           ` [Intel-gfx] " Grant Grundler
2017-05-05 21:37           ` Matthias Kaehlcke
2017-05-05 21:37             ` [Intel-gfx] " Matthias Kaehlcke
2017-05-08  7:21     ` Daniel Vetter
2017-05-08  7:21       ` Daniel Vetter
2017-05-08  8:17       ` Jani Nikula
2017-05-08  8:17         ` [Intel-gfx] " Jani Nikula
2017-07-13  2:28     ` Stéphane Marchesin
2017-07-13  2:28       ` [Intel-gfx] " Stéphane Marchesin
2017-07-13 10:13       ` Ville Syrjälä
2017-07-13 12:24         ` Daniel Vetter
2017-07-13 12:24           ` [Intel-gfx] " Daniel Vetter
2017-07-13 16:23         ` Stéphane Marchesin
2017-07-13 16:23           ` [Intel-gfx] " Stéphane Marchesin
2017-07-13 17:42           ` Ville Syrjälä
2017-07-13 17:42             ` [Intel-gfx] " Ville Syrjälä
2017-07-13 19:58             ` Stéphane Marchesin
2017-07-13 19:58               ` [Intel-gfx] " Stéphane Marchesin
2017-07-14  9:11               ` Jani Nikula
2017-07-14  9:11                 ` Jani Nikula
2017-07-14 17:32                 ` Grant Grundler
2017-07-14 21:35                   ` Daniel Vetter
2017-07-14 22:43                     ` Grant Grundler
2017-07-14 22:43                       ` [Intel-gfx] " Grant Grundler
2017-07-14 23:38                       ` Matthias Kaehlcke
2017-07-14 23:38                         ` [Intel-gfx] " Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170505172636.GA128305@google.com \
    --to=mka@chromium.org \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ghackmann@google.com \
    --cc=grundler@chromium.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=md@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.