From: Andrew Lunn <andrew@lunn.ch>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net: dsa: loop: Check for memory allocation failure
Date: Sat, 06 May 2017 14:45:19 +0000 [thread overview]
Message-ID: <20170506144519.GA23180@lunn.ch> (raw)
In-Reply-To: <20170506052945.2639-1-christophe.jaillet@wanadoo.fr>
On Sat, May 06, 2017 at 07:29:45AM +0200, Christophe JAILLET wrote:
> If 'devm_kzalloc' fails, a NULL pointer will be dereferenced.
> Return -ENOMEM instead, as done for some other memory allocation just a
> few lines above.
>
> Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net: dsa: loop: Check for memory allocation failure
Date: Sat, 6 May 2017 16:45:19 +0200 [thread overview]
Message-ID: <20170506144519.GA23180@lunn.ch> (raw)
In-Reply-To: <20170506052945.2639-1-christophe.jaillet@wanadoo.fr>
On Sat, May 06, 2017 at 07:29:45AM +0200, Christophe JAILLET wrote:
> If 'devm_kzalloc' fails, a NULL pointer will be dereferenced.
> Return -ENOMEM instead, as done for some other memory allocation just a
> few lines above.
>
> Fixes: 98cd1552ea27 ("net: dsa: Mock-up driver")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-05-06 14:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 5:29 [PATCH] net: dsa: loop: Check for memory allocation failure Christophe JAILLET
2017-05-06 5:29 ` Christophe JAILLET
2017-05-06 14:45 ` Andrew Lunn [this message]
2017-05-06 14:45 ` Andrew Lunn
2017-05-07 23:22 ` Florian Fainelli
2017-05-07 23:22 ` Florian Fainelli
2017-05-08 12:05 ` David Laight
2017-05-08 12:05 ` David Laight
2017-05-08 12:32 ` Julia Lawall
2017-05-08 12:32 ` Julia Lawall
2017-05-08 17:44 ` Joe Perches
2017-05-08 17:44 ` Joe Perches
2017-05-08 23:46 ` Julia Lawall
2017-05-08 23:46 ` Julia Lawall
2017-05-09 0:35 ` Florian Fainelli
2017-05-09 0:35 ` Florian Fainelli
2017-05-09 0:39 ` Julia Lawall
2017-05-09 0:39 ` Julia Lawall
2017-05-09 15:18 ` Joe Perches
2017-05-09 15:18 ` Joe Perches
2017-05-10 4:38 ` Christophe JAILLET
2017-05-10 4:38 ` Christophe JAILLET
2017-05-10 4:46 ` Julia Lawall
2017-05-10 4:46 ` Julia Lawall
2017-05-10 4:54 ` Marion & Christophe JAILLET
2017-05-10 4:54 ` Marion & Christophe JAILLET
2017-05-08 19:01 ` David Miller
2017-05-08 19:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170506144519.GA23180@lunn.ch \
--to=andrew@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.