All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	Jan Kara <jack@suse.com>,
	linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] filesystem-dax: fix broken __dax_zero_page_range() conversion
Date: Thu, 11 May 2017 09:36:52 -0600	[thread overview]
Message-ID: <20170511153652.GB22811@linux.intel.com> (raw)
In-Reply-To: <149447098770.22897.1499086717635335664.stgit@dwillia2-desk3.amr.corp.intel.com>

On Wed, May 10, 2017 at 07:49:47PM -0700, Dan Williams wrote:
> The conversion of __dax_zero_page_range() to 'struct dax_operations'
> caused it to frequently fail. The mistake was treating the @size
> parameter as a dax mapping length rather than just a length of the
> clear_pmem() operation. The dax mapping length is assumed to be hard
> coded as PAGE_SIZE.
> 
> Without this fix any page unaligned zeroing request will trigger a
> -EINVAL return from bdev_dax_pgoff().
> 
> Cc: Jan Kara <jack@suse.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Reported-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Yep, this solves the issue for me.  Thanks!

Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>

> Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()")
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  fs/dax.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/dax.c b/fs/dax.c
> index ce9dc9c3e829..5ee1d212d81f 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -971,12 +971,12 @@ int __dax_zero_page_range(struct block_device *bdev,
>  		void *kaddr;
>  		pfn_t pfn;
>  
> -		rc = bdev_dax_pgoff(bdev, sector, size, &pgoff);
> +		rc = bdev_dax_pgoff(bdev, sector, PAGE_SIZE, &pgoff);
>  		if (rc)
>  			return rc;
>  
>  		id = dax_read_lock();
> -		rc = dax_direct_access(dax_dev, pgoff, PHYS_PFN(size), &kaddr,
> +		rc = dax_direct_access(dax_dev, pgoff, 1, &kaddr,
>  				&pfn);
>  		if (rc < 0) {
>  			dax_read_unlock(id);
> 
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.com>
Subject: Re: [PATCH] filesystem-dax: fix broken __dax_zero_page_range() conversion
Date: Thu, 11 May 2017 09:36:52 -0600	[thread overview]
Message-ID: <20170511153652.GB22811@linux.intel.com> (raw)
In-Reply-To: <149447098770.22897.1499086717635335664.stgit@dwillia2-desk3.amr.corp.intel.com>

On Wed, May 10, 2017 at 07:49:47PM -0700, Dan Williams wrote:
> The conversion of __dax_zero_page_range() to 'struct dax_operations'
> caused it to frequently fail. The mistake was treating the @size
> parameter as a dax mapping length rather than just a length of the
> clear_pmem() operation. The dax mapping length is assumed to be hard
> coded as PAGE_SIZE.
> 
> Without this fix any page unaligned zeroing request will trigger a
> -EINVAL return from bdev_dax_pgoff().
> 
> Cc: Jan Kara <jack@suse.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Reported-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Yep, this solves the issue for me.  Thanks!

Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>

> Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()")
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  fs/dax.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/dax.c b/fs/dax.c
> index ce9dc9c3e829..5ee1d212d81f 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -971,12 +971,12 @@ int __dax_zero_page_range(struct block_device *bdev,
>  		void *kaddr;
>  		pfn_t pfn;
>  
> -		rc = bdev_dax_pgoff(bdev, sector, size, &pgoff);
> +		rc = bdev_dax_pgoff(bdev, sector, PAGE_SIZE, &pgoff);
>  		if (rc)
>  			return rc;
>  
>  		id = dax_read_lock();
> -		rc = dax_direct_access(dax_dev, pgoff, PHYS_PFN(size), &kaddr,
> +		rc = dax_direct_access(dax_dev, pgoff, 1, &kaddr,
>  				&pfn);
>  		if (rc < 0) {
>  			dax_read_unlock(id);
> 

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.com>
Subject: Re: [PATCH] filesystem-dax: fix broken __dax_zero_page_range() conversion
Date: Thu, 11 May 2017 09:36:52 -0600	[thread overview]
Message-ID: <20170511153652.GB22811@linux.intel.com> (raw)
In-Reply-To: <149447098770.22897.1499086717635335664.stgit@dwillia2-desk3.amr.corp.intel.com>

On Wed, May 10, 2017 at 07:49:47PM -0700, Dan Williams wrote:
> The conversion of __dax_zero_page_range() to 'struct dax_operations'
> caused it to frequently fail. The mistake was treating the @size
> parameter as a dax mapping length rather than just a length of the
> clear_pmem() operation. The dax mapping length is assumed to be hard
> coded as PAGE_SIZE.
> 
> Without this fix any page unaligned zeroing request will trigger a
> -EINVAL return from bdev_dax_pgoff().
> 
> Cc: Jan Kara <jack@suse.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Reported-by: Ross Zwisler <ross.zwisler@linux.intel.com>

Yep, this solves the issue for me.  Thanks!

Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>

> Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()")
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  fs/dax.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/dax.c b/fs/dax.c
> index ce9dc9c3e829..5ee1d212d81f 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -971,12 +971,12 @@ int __dax_zero_page_range(struct block_device *bdev,
>  		void *kaddr;
>  		pfn_t pfn;
>  
> -		rc = bdev_dax_pgoff(bdev, sector, size, &pgoff);
> +		rc = bdev_dax_pgoff(bdev, sector, PAGE_SIZE, &pgoff);
>  		if (rc)
>  			return rc;
>  
>  		id = dax_read_lock();
> -		rc = dax_direct_access(dax_dev, pgoff, PHYS_PFN(size), &kaddr,
> +		rc = dax_direct_access(dax_dev, pgoff, 1, &kaddr,
>  				&pfn);
>  		if (rc < 0) {
>  			dax_read_unlock(id);
> 

  reply	other threads:[~2017-05-11 15:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11  2:49 [PATCH] filesystem-dax: fix broken __dax_zero_page_range() conversion Dan Williams
2017-05-11  2:49 ` Dan Williams
2017-05-11  2:49 ` Dan Williams
2017-05-11 15:36 ` Ross Zwisler [this message]
2017-05-11 15:36   ` Ross Zwisler
2017-05-11 15:36   ` Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170511153652.GB22811@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=hch@lst.de \
    --cc=jack@suse.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.