From: Brian Norris <briannorris@chromium.org>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: linux-kernel@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include
Date: Fri, 12 May 2017 17:53:36 -0700 [thread overview]
Message-ID: <20170513005335.GB23103@google.com> (raw)
In-Reply-To: <20170512235357.19486-1-ijc@hellion.org.uk>
On Sat, May 13, 2017 at 12:53:57AM +0100, Ian Campbell wrote:
> It not necessary and counter to how all the other files are done.
>
> It also happens to break the build in the split device tree repo
> https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Brian Norris <briannorris@chromium.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> index 658bb9dc9dfd..7bd31066399b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> @@ -44,7 +44,7 @@
>
> /dts-v1/;
> #include "rk3399-gru.dtsi"
> -#include <include/dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/input/linux-event-codes.h>
Whoops, didn't catch that when porting this to mainline. Thanks!
Reviewed-by: Brian Norris <briannorris@chromium.org>
>
> /*
> * Kevin-specific things
> --
> 2.11.0
>
WARNING: multiple messages have this Message-ID (diff)
From: briannorris@chromium.org (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include
Date: Fri, 12 May 2017 17:53:36 -0700 [thread overview]
Message-ID: <20170513005335.GB23103@google.com> (raw)
In-Reply-To: <20170512235357.19486-1-ijc@hellion.org.uk>
On Sat, May 13, 2017 at 12:53:57AM +0100, Ian Campbell wrote:
> It not necessary and counter to how all the other files are done.
>
> It also happens to break the build in the split device tree repo
> https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Brian Norris <briannorris@chromium.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-rockchip at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> ---
> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> index 658bb9dc9dfd..7bd31066399b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
> @@ -44,7 +44,7 @@
>
> /dts-v1/;
> #include "rk3399-gru.dtsi"
> -#include <include/dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/input/linux-event-codes.h>
Whoops, didn't catch that when porting this to mainline. Thanks!
Reviewed-by: Brian Norris <briannorris@chromium.org>
>
> /*
> * Kevin-specific things
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-05-13 0:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 23:53 [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include Ian Campbell
2017-05-12 23:53 ` Ian Campbell
2017-05-12 23:53 ` Ian Campbell
2017-05-13 0:53 ` Brian Norris [this message]
2017-05-13 0:53 ` Brian Norris
2017-05-13 15:43 ` Heiko Stuebner
2017-05-13 15:43 ` Heiko Stuebner
2017-05-13 15:43 ` Heiko Stuebner
2017-05-17 1:13 ` Ian Campbell
2017-05-17 1:13 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170513005335.GB23103@google.com \
--to=briannorris@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=heiko@sntech.de \
--cc=ijc@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.