From: Heiko Stuebner <heiko@sntech.de>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Brian Norris <briannorris@chromium.org>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include
Date: Sat, 13 May 2017 17:43:40 +0200 [thread overview]
Message-ID: <3956756.APWK7IdRuP@phil> (raw)
In-Reply-To: <20170512235357.19486-1-ijc@hellion.org.uk>
Hi Ian,
Am Samstag, 13. Mai 2017, 00:53:57 CEST schrieb Ian Campbell:
> It not necessary and counter to how all the other files are done.
>
> It also happens to break the build in the split device tree repo
> https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Brian Norris <briannorris@chromium.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
that glitch also breaks Olof's patch [0] fixing a depmod symlink
recursion in that it creates
../arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:47:57: fatal error: include/dt-bindings/input/linux-event-codes.h: File or directory not found
#include <include/dt-bindings/input/linux-event-codes.h>
with only Olof's patch applied. So I guess both patches should go
together with this one in front, so to be on the safe side, if some else
is going to apply both:
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
[0] https://www.spinics.net/lists/arm-kernel/msg580846.html
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include
Date: Sat, 13 May 2017 17:43:40 +0200 [thread overview]
Message-ID: <3956756.APWK7IdRuP@phil> (raw)
In-Reply-To: <20170512235357.19486-1-ijc@hellion.org.uk>
Hi Ian,
Am Samstag, 13. Mai 2017, 00:53:57 CEST schrieb Ian Campbell:
> It not necessary and counter to how all the other files are done.
>
> It also happens to break the build in the split device tree repo
> https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Brian Norris <briannorris@chromium.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-rockchip at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
that glitch also breaks Olof's patch [0] fixing a depmod symlink
recursion in that it creates
../arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:47:57: fatal error: include/dt-bindings/input/linux-event-codes.h: File or directory not found
#include <include/dt-bindings/input/linux-event-codes.h>
with only Olof's patch applied. So I guess both patches should go
together with this one in front, so to be on the safe side, if some else
is going to apply both:
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
[0] https://www.spinics.net/lists/arm-kernel/msg580846.html
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: linux-kernel@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include
Date: Sat, 13 May 2017 17:43:40 +0200 [thread overview]
Message-ID: <3956756.APWK7IdRuP@phil> (raw)
In-Reply-To: <20170512235357.19486-1-ijc@hellion.org.uk>
Hi Ian,
Am Samstag, 13. Mai 2017, 00:53:57 CEST schrieb Ian Campbell:
> It not necessary and counter to how all the other files are done.
>
> It also happens to break the build in the split device tree repo
> https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Brian Norris <briannorris@chromium.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
that glitch also breaks Olof's patch [0] fixing a depmod symlink
recursion in that it creates
../arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:47:57: fatal error: include/dt-bindings/input/linux-event-codes.h: File or directory not found
#include <include/dt-bindings/input/linux-event-codes.h>
with only Olof's patch applied. So I guess both patches should go
together with this one in front, so to be on the safe side, if some else
is going to apply both:
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
[0] https://www.spinics.net/lists/arm-kernel/msg580846.html
next prev parent reply other threads:[~2017-05-13 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 23:53 [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include Ian Campbell
2017-05-12 23:53 ` Ian Campbell
2017-05-12 23:53 ` Ian Campbell
2017-05-13 0:53 ` Brian Norris
2017-05-13 0:53 ` Brian Norris
2017-05-13 15:43 ` Heiko Stuebner [this message]
2017-05-13 15:43 ` Heiko Stuebner
2017-05-13 15:43 ` Heiko Stuebner
2017-05-17 1:13 ` Ian Campbell
2017-05-17 1:13 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3956756.APWK7IdRuP@phil \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=ijc@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.