All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pushkar Jambhlekar <pushkar.iit@gmail.com>
Cc: devel@driverdev.osuosl.org,
	driverdev-devel@linuxdriverproject.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/ccree: Fixing coding guideline errors
Date: Tue, 16 May 2017 10:16:29 +0200	[thread overview]
Message-ID: <20170516081629.GA5631@kroah.com> (raw)
In-Reply-To: <1494921952-8384-1-git-send-email-pushkar.iit@gmail.com>

On Tue, May 16, 2017 at 01:35:52PM +0530, Pushkar Jambhlekar wrote:
> Fixing coding guideline errors reported by 'checkpatch.pl'

That is very "vague", you are going to have to be specific here.

Also remember you can only do "one type of thing" per patch, and no,
"fix all warnings" is not one type of thing :)

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pushkar Jambhlekar <pushkar.iit@gmail.com>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
	devel@driverdev.osuosl.org,
	driverdev-devel@linuxdriverproject.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/ccree: Fixing coding guideline errors
Date: Tue, 16 May 2017 10:16:29 +0200	[thread overview]
Message-ID: <20170516081629.GA5631@kroah.com> (raw)
In-Reply-To: <1494921952-8384-1-git-send-email-pushkar.iit@gmail.com>

On Tue, May 16, 2017 at 01:35:52PM +0530, Pushkar Jambhlekar wrote:
> Fixing coding guideline errors reported by 'checkpatch.pl'

That is very "vague", you are going to have to be specific here.

Also remember you can only do "one type of thing" per patch, and no,
"fix all warnings" is not one type of thing :)

thanks,

greg k-h

  reply	other threads:[~2017-05-16  8:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16  8:05 [PATCH] drivers/staging/ccree: Fixing coding guideline errors Pushkar Jambhlekar
2017-05-16  8:05 ` Pushkar Jambhlekar
2017-05-16  8:16 ` Greg Kroah-Hartman [this message]
2017-05-16  8:16   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170516081629.GA5631@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pushkar.iit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.