All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: cpufeature: check translation granule size based on kernel config
Date: Thu, 18 May 2017 16:13:30 +0100	[thread overview]
Message-ID: <20170518151329.GF21359@arm.com> (raw)
In-Reply-To: <20170518142415.GA6425@leverpostej>

On Thu, May 18, 2017 at 03:24:15PM +0100, Mark Rutland wrote:
> On Thu, May 18, 2017 at 09:02:50PM +0800, Leo Yan wrote:
> > On Thu, May 18, 2017 at 01:41:15PM +0100, Mark Rutland wrote:
> > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> > > index 94b8f7f..1f53314 100644
> > > --- a/arch/arm64/kernel/cpufeature.c
> > > +++ b/arch/arm64/kernel/cpufeature.c
> > > @@ -639,8 +639,8 @@ void update_cpu_features(int cpu,
> > >          * Mismatched CPU features are a recipe for disaster. Don't even
> > >          * pretend to support them.
> > >          */
> > > -       WARN_TAINT_ONCE(taint, TAINT_CPU_OUT_OF_SPEC,
> > > -                       "Unsupported CPU feature variation.\n");
> > > +       pr_warn_once("Unsupported CPU feature variation detected.\n");
> > > +       add_taint(TAINT_CPU_OUT_OF_SPEC);
> > 
> > Should be add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK)?
> 
> Whoops; yes.

I've picked this up with the fix above.

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Leo Yan <leo.yan@linaro.org>,
	Suzuki K Poulose <Suzuki.Poulose@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	James Morse <james.morse@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Guodong Xu <guodong.xu@linaro.org>,
	Haojian Zhuang <haojian.zhuang@linaro.org>,
	Douglas Raillard <douglas.raillard@arm.com>
Subject: Re: [PATCH] arm64: cpufeature: check translation granule size based on kernel config
Date: Thu, 18 May 2017 16:13:30 +0100	[thread overview]
Message-ID: <20170518151329.GF21359@arm.com> (raw)
In-Reply-To: <20170518142415.GA6425@leverpostej>

On Thu, May 18, 2017 at 03:24:15PM +0100, Mark Rutland wrote:
> On Thu, May 18, 2017 at 09:02:50PM +0800, Leo Yan wrote:
> > On Thu, May 18, 2017 at 01:41:15PM +0100, Mark Rutland wrote:
> > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> > > index 94b8f7f..1f53314 100644
> > > --- a/arch/arm64/kernel/cpufeature.c
> > > +++ b/arch/arm64/kernel/cpufeature.c
> > > @@ -639,8 +639,8 @@ void update_cpu_features(int cpu,
> > >          * Mismatched CPU features are a recipe for disaster. Don't even
> > >          * pretend to support them.
> > >          */
> > > -       WARN_TAINT_ONCE(taint, TAINT_CPU_OUT_OF_SPEC,
> > > -                       "Unsupported CPU feature variation.\n");
> > > +       pr_warn_once("Unsupported CPU feature variation detected.\n");
> > > +       add_taint(TAINT_CPU_OUT_OF_SPEC);
> > 
> > Should be add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK)?
> 
> Whoops; yes.

I've picked this up with the fix above.

Will

  reply	other threads:[~2017-05-18 15:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 10:21 [PATCH] arm64: cpufeature: check translation granule size based on kernel config Leo Yan
2017-05-18 10:21 ` Leo Yan
2017-05-18 10:39 ` Suzuki K Poulose
2017-05-18 10:39   ` Suzuki K Poulose
2017-05-18 11:36   ` Leo Yan
2017-05-18 11:36     ` Leo Yan
2017-05-18 12:38     ` Will Deacon
2017-05-18 12:38       ` Will Deacon
2017-05-18 12:41       ` Mark Rutland
2017-05-18 12:41         ` Mark Rutland
2017-05-18 13:02         ` Leo Yan
2017-05-18 13:02           ` Leo Yan
2017-05-18 14:24           ` Mark Rutland
2017-05-18 14:24             ` Mark Rutland
2017-05-18 15:13             ` Will Deacon [this message]
2017-05-18 15:13               ` Will Deacon
2017-05-18 12:39     ` Suzuki K Poulose
2017-05-18 12:39       ` Suzuki K Poulose
2017-05-18 13:01       ` Leo Yan
2017-05-18 13:01         ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170518151329.GF21359@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.