All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
	Mike Turquette <mturquette@baylibre.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH v3 01/21] clk: divider: Make divider_round_rate take the parent clock
Date: Thu, 18 May 2017 18:54:30 -0700	[thread overview]
Message-ID: <20170519015430.GF20170@codeaurora.org> (raw)
In-Reply-To: <af976be0ecc2ea335cd9694a83fb29174d87e17d.1495006350.git-series.maxime.ripard@free-electrons.com>

On 05/17, Maxime Ripard wrote:
> So far, divider_round_rate only considers the parent clock returned by
> clk_hw_get_parent.
> 
> This works fine on clocks that have a single parents, this doesn't work on
> muxes, since we will only consider the first parent, while other parents
> may totally be able to provide a better combination.
> 
> Clocks in that case cannot use divider_round_rate, so would have to come up
> with a very similar logic to work around it. Instead of having to do
> something like this, and duplicate that logic everywhere, create a
> divider_round_rate parent to allow caller to give an additional parameter
> for the parent clock to consider.
> 
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

Acked-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/21] clk: divider: Make divider_round_rate take the parent clock
Date: Thu, 18 May 2017 18:54:30 -0700	[thread overview]
Message-ID: <20170519015430.GF20170@codeaurora.org> (raw)
In-Reply-To: <af976be0ecc2ea335cd9694a83fb29174d87e17d.1495006350.git-series.maxime.ripard@free-electrons.com>

On 05/17, Maxime Ripard wrote:
> So far, divider_round_rate only considers the parent clock returned by
> clk_hw_get_parent.
> 
> This works fine on clocks that have a single parents, this doesn't work on
> muxes, since we will only consider the first parent, while other parents
> may totally be able to provide a better combination.
> 
> Clocks in that case cannot use divider_round_rate, so would have to come up
> with a very similar logic to work around it. Instead of having to do
> something like this, and duplicate that logic everywhere, create a
> divider_round_rate parent to allow caller to give an additional parameter
> for the parent clock to consider.
> 
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

Acked-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	devicetree@vger.kernel.org,
	Mike Turquette <mturquette@baylibre.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Chen-Yu Tsai <wens@csie.org>,
	Daniel Vetter <daniel.vetter@intel.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 01/21] clk: divider: Make divider_round_rate take the parent clock
Date: Thu, 18 May 2017 18:54:30 -0700	[thread overview]
Message-ID: <20170519015430.GF20170@codeaurora.org> (raw)
In-Reply-To: <af976be0ecc2ea335cd9694a83fb29174d87e17d.1495006350.git-series.maxime.ripard@free-electrons.com>

On 05/17, Maxime Ripard wrote:
> So far, divider_round_rate only considers the parent clock returned by
> clk_hw_get_parent.
> 
> This works fine on clocks that have a single parents, this doesn't work on
> muxes, since we will only consider the first parent, while other parents
> may totally be able to provide a better combination.
> 
> Clocks in that case cannot use divider_round_rate, so would have to come up
> with a very similar logic to work around it. Instead of having to do
> something like this, and duplicate that logic everywhere, create a
> divider_round_rate parent to allow caller to give an additional parameter
> for the parent clock to consider.
> 
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---

Acked-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-05-19  1:54 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17  7:40 [PATCH v3 00/21] drm: sun4i: Add support for the HDMI controller Maxime Ripard
2017-05-17  7:40 ` Maxime Ripard
2017-05-17  7:40 ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 01/21] clk: divider: Make divider_round_rate take the parent clock Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-19  1:54   ` Stephen Boyd [this message]
2017-05-19  1:54     ` Stephen Boyd
2017-05-19  1:54     ` Stephen Boyd
2017-05-17  7:40 ` [PATCH v3 02/21] clk: sunxi-ng: Pass the parent and a pointer to the clocks round rate Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 03/21] clk: sunxi-ng: div: Switch to divider_round_rate Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 04/21] clk: sunxi-ng: mux: Don't just rely on the parent for CLK_SET_RATE_PARENT Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 05/21] clk: sunxi-ng: mux: split out the pre-divider computation code Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 06/21] clk: sunxi-ng: mux: Change pre-divider application function prototype Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 07/21] clk: sunxi-ng: mux: Re-adjust parent rate Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 08/21] clk: sunxi-ng: sun5i: Export video PLLs Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 09/21] drm/sun4i: tcon: Add channel debug Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 10/21] drm/sun4i: tcon: Move the muxing out of the mode set function Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 11/21] drm/sun4i: tcon: Switch mux on only for composite Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 12/21] drm/sun4i: tcon: Fix tcon channel 1 backporch calculation Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 13/21] drm/sun4i: tcon: Change vertical total size computation inconsistency Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 14/21] drm/sun4i: tcon: multiply the vtotal when not in interlace Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  9:50   ` Chen-Yu Tsai
2017-05-17  9:50     ` Chen-Yu Tsai
2017-05-17  9:50     ` Chen-Yu Tsai
2017-05-18  7:51     ` Maxime Ripard
2017-05-18  7:51       ` Maxime Ripard
2017-05-18  7:51       ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 15/21] drm/sun4i: Ignore the generic connectors for components Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  9:00   ` Chen-Yu Tsai
2017-05-17  9:00     ` Chen-Yu Tsai
2017-05-17  9:00     ` Chen-Yu Tsai
2017-05-17  7:40 ` [PATCH v3 16/21] dt-bindings: display: sun4i: Add HDMI display bindings Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 17/21] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Maxime Ripard
2017-05-17  7:40   ` [PATCH v3 17/21] dt-bindings: display: sun4i: Add allwinner, tcon-channel property Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 18/21] drm/sun4i: Add HDMI support Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 19/21] drm/sun4i: Add compatible for the A10s pipeline Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  9:00   ` Chen-Yu Tsai
2017-05-17  9:00     ` Chen-Yu Tsai
2017-05-23  0:33   ` Rob Herring
2017-05-23  0:33     ` Rob Herring
2017-05-17  7:40 ` [PATCH v3 20/21] ARM: sun5i: a10s: Add the HDMI controller node Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-17  7:40 ` [PATCH v3 21/21] ARM: sun5i: a10s-olinuxino: Enable HDMI Maxime Ripard
2017-05-17  7:40   ` Maxime Ripard
2017-05-19  7:34 ` [PATCH v3 00/21] drm: sun4i: Add support for the HDMI controller Chen-Yu Tsai
2017-05-19  7:34   ` Chen-Yu Tsai
2017-05-19  7:34   ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170519015430.GF20170@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mturquette@baylibre.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.