From: Tony Lindgren <tony@atomide.com>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"open list:IIO SUBSYSTEM AND..." <linux-iio@vger.kernel.org>,
linux-omap@vger.kernel.org, Marcel Partap <mpartap@gmx.net>,
Michael Scott <michael.scott@linaro.org>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 1/3] iio: adc: cpcap: Fix default register values and battery temperature
Date: Sat, 20 May 2017 09:02:40 -0700 [thread overview]
Message-ID: <20170520160240.GL10472@atomide.com> (raw)
In-Reply-To: <CAJCx=gm7t=2nuHiLCXUohLXR62gZ-ux62tWyEQXyNXMrhTutKg@mail.gmail.com>
* Matt Ranostay <matt.ranostay@konsulko.com> [170519 22:55]:
> On Thu, May 18, 2017 at 8:40 PM, Tony Lindgren <tony@atomide.com> wrote:
> > enum cpcap_adc_channel {
> > /* Bank0 channels */
> > - CPCAP_ADC_AD0_BATTDETB, /* Battery detection */
> > + CPCAP_ADC_AD0_BATTDETB, /* Battery temperature */
>
> Since this doesn't mean battery detection anymore I'd recommend
> renaming to CPCAP_ADC_AD0_BATTEMP or similar.
OK I'll change it to just CPCAP_ADC_AD0 as it seems it's use has
changed across revisions or products.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Matt Ranostay <matt.ranostay-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Peter Meerwald-Stadler
<pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
"open list:IIO SUBSYSTEM AND..."
<linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Marcel Partap <mpartap-hi6Y0CQ0nG0@public.gmane.org>,
Michael Scott
<michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 1/3] iio: adc: cpcap: Fix default register values and battery temperature
Date: Sat, 20 May 2017 09:02:40 -0700 [thread overview]
Message-ID: <20170520160240.GL10472@atomide.com> (raw)
In-Reply-To: <CAJCx=gm7t=2nuHiLCXUohLXR62gZ-ux62tWyEQXyNXMrhTutKg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
* Matt Ranostay <matt.ranostay-OWPKS81ov/FWk0Htik3J/w@public.gmane.org> [170519 22:55]:
> On Thu, May 18, 2017 at 8:40 PM, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:
> > enum cpcap_adc_channel {
> > /* Bank0 channels */
> > - CPCAP_ADC_AD0_BATTDETB, /* Battery detection */
> > + CPCAP_ADC_AD0_BATTDETB, /* Battery temperature */
>
> Since this doesn't mean battery detection anymore I'd recommend
> renaming to CPCAP_ADC_AD0_BATTEMP or similar.
OK I'll change it to just CPCAP_ADC_AD0 as it seems it's use has
changed across revisions or products.
Regards,
Tony
next prev parent reply other threads:[~2017-05-20 16:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 3:40 [PATCH 0/3] Few non-critical cpcap ADC fixes Tony Lindgren
2017-05-19 3:40 ` Tony Lindgren
2017-05-19 3:40 ` [PATCH 1/3] iio: adc: cpcap: Fix default register values and battery temperature Tony Lindgren
2017-05-19 3:40 ` Tony Lindgren
2017-05-20 5:52 ` Matt Ranostay
2017-05-20 5:52 ` Matt Ranostay
2017-05-20 15:51 ` Jonathan Cameron
2017-05-20 15:51 ` Jonathan Cameron
2017-05-20 16:02 ` Tony Lindgren [this message]
2017-05-20 16:02 ` Tony Lindgren
2017-05-19 3:40 ` [PATCH 2/3] iio: adc: cpcap: Fix die temperature Tony Lindgren
2017-05-19 3:40 ` Tony Lindgren
2017-05-20 15:55 ` Jonathan Cameron
2017-05-20 15:55 ` Jonathan Cameron
2017-05-20 16:35 ` Tony Lindgren
2017-05-20 16:35 ` Tony Lindgren
2017-05-20 16:39 ` Jonathan Cameron
2017-05-20 16:39 ` Jonathan Cameron
2017-05-19 3:40 ` [PATCH 3/3] iio: adc: cpcap: Remove hung interrupt quirk Tony Lindgren
2017-05-19 3:40 ` Tony Lindgren
2017-05-20 12:29 ` Sebastian Reichel
2017-05-20 12:29 ` Sebastian Reichel
2017-05-20 15:56 ` Jonathan Cameron
2017-05-20 15:56 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2017-05-23 0:51 [PATCHv2 0/3] Few non-critical cpcap ADC fixes Tony Lindgren
2017-05-23 0:51 ` [PATCH 1/3] iio: adc: cpcap: Fix default register values and battery temperature Tony Lindgren
2017-05-23 0:51 ` Tony Lindgren
2017-05-24 19:18 ` Jonathan Cameron
2017-05-24 19:18 ` Jonathan Cameron
2017-06-07 6:22 ` Tony Lindgren
2017-06-07 6:22 ` Tony Lindgren
2017-06-11 14:12 ` Jonathan Cameron
2017-06-11 14:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170520160240.GL10472@atomide.com \
--to=tony@atomide.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=michael.scott@linaro.org \
--cc=mpartap@gmx.net \
--cc=pmeerw@pmeerw.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.