From: Tony Lindgren <tony@atomide.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-omap@vger.kernel.org,
Marcel Partap <mpartap@gmx.net>,
Michael Scott <michael.scott@linaro.org>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 1/3] iio: adc: cpcap: Fix default register values and battery temperature
Date: Tue, 6 Jun 2017 23:22:00 -0700 [thread overview]
Message-ID: <20170607062200.GD3730@atomide.com> (raw)
In-Reply-To: <20170524201831.3504c42d@kernel.org>
* Jonathan Cameron <jic23@kernel.org> [170524 12:22]:
> On Mon, 22 May 2017 17:51:44 -0700
> Tony Lindgren <tony@atomide.com> wrote:
>
> > Looking at the register dumps from Android kernel on droid 4, I noticed
> > the values with the mainline kernel don't match. Let's fix this by
> > initializing the ADC registers to what Android does.
> >
> > For getting correct values from the battery thermistor, we need to
> > toggle the CPCAP_BIT_THERMBIAS_EN when measuring battery temperature
> > to get correct battery temperatures. And looks like we also need to
> > wait a little bit before reading the battery temperature as otherwise
> > the results are inaccurate.
> >
> > Cc: Marcel Partap <mpartap@gmx.net>
> > Cc: Michael Scott <michael.scott@linaro.org>
> > Cc: Sebastian Reichel <sre@kernel.org>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> Applied to the togreg branch of iio.git and will be shortly pushed
> out as testing for the autobuilders to play with it.
Not seeing these in your togreg brach or in next? The
branch I just checked is the one below, maybe I'm looking
at a wrong branch or something.
Regards,
Tony
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=togreg
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Peter Meerwald-Stadler
<pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Marcel Partap <mpartap-hi6Y0CQ0nG0@public.gmane.org>,
Michael Scott
<michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 1/3] iio: adc: cpcap: Fix default register values and battery temperature
Date: Tue, 6 Jun 2017 23:22:00 -0700 [thread overview]
Message-ID: <20170607062200.GD3730@atomide.com> (raw)
In-Reply-To: <20170524201831.3504c42d-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
* Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> [170524 12:22]:
> On Mon, 22 May 2017 17:51:44 -0700
> Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:
>
> > Looking at the register dumps from Android kernel on droid 4, I noticed
> > the values with the mainline kernel don't match. Let's fix this by
> > initializing the ADC registers to what Android does.
> >
> > For getting correct values from the battery thermistor, we need to
> > toggle the CPCAP_BIT_THERMBIAS_EN when measuring battery temperature
> > to get correct battery temperatures. And looks like we also need to
> > wait a little bit before reading the battery temperature as otherwise
> > the results are inaccurate.
> >
> > Cc: Marcel Partap <mpartap-hi6Y0CQ0nG0@public.gmane.org>
> > Cc: Michael Scott <michael.scott-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > Cc: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> Applied to the togreg branch of iio.git and will be shortly pushed
> out as testing for the autobuilders to play with it.
Not seeing these in your togreg brach or in next? The
branch I just checked is the one below, maybe I'm looking
at a wrong branch or something.
Regards,
Tony
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=togreg
next prev parent reply other threads:[~2017-06-07 6:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 0:51 [PATCHv2 0/3] Few non-critical cpcap ADC fixes Tony Lindgren
2017-05-23 0:51 ` Tony Lindgren
2017-05-23 0:51 ` [PATCH 1/3] iio: adc: cpcap: Fix default register values and battery temperature Tony Lindgren
2017-05-23 0:51 ` Tony Lindgren
2017-05-24 19:18 ` Jonathan Cameron
2017-05-24 19:18 ` Jonathan Cameron
2017-06-07 6:22 ` Tony Lindgren [this message]
2017-06-07 6:22 ` Tony Lindgren
2017-06-11 14:12 ` Jonathan Cameron
2017-06-11 14:12 ` Jonathan Cameron
2017-05-23 0:51 ` [PATCH 2/3] iio: adc: cpcap: Fix die temperature Tony Lindgren
2017-05-23 0:51 ` Tony Lindgren
2017-05-24 19:19 ` Jonathan Cameron
2017-05-24 19:19 ` Jonathan Cameron
2017-05-23 0:51 ` [PATCH 3/3] iio: adc: cpcap: Remove hung interrupt quirk Tony Lindgren
2017-05-23 0:51 ` Tony Lindgren
2017-05-24 19:24 ` Jonathan Cameron
2017-05-24 19:24 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2017-05-19 3:40 [PATCH 0/3] Few non-critical cpcap ADC fixes Tony Lindgren
2017-05-19 3:40 ` [PATCH 1/3] iio: adc: cpcap: Fix default register values and battery temperature Tony Lindgren
2017-05-19 3:40 ` Tony Lindgren
2017-05-20 5:52 ` Matt Ranostay
2017-05-20 5:52 ` Matt Ranostay
2017-05-20 15:51 ` Jonathan Cameron
2017-05-20 15:51 ` Jonathan Cameron
2017-05-20 16:02 ` Tony Lindgren
2017-05-20 16:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607062200.GD3730@atomide.com \
--to=tony@atomide.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michael.scott@linaro.org \
--cc=mpartap@gmx.net \
--cc=pmeerw@pmeerw.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.