From: Shawn Guo <shawnguo@kernel.org>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linus.walleij@linaro.org, stefan@agner.ch, ping.bai@nxp.com,
fugang.duan@nxp.com, kernel@pengutronix.de
Subject: Re: [PATCH V2 3/5] pinctrl: imx: add soc specific mux_mode mask and shift property
Date: Sun, 21 May 2017 17:28:05 +0800 [thread overview]
Message-ID: <20170521092804.GL26102@dragon> (raw)
In-Reply-To: <1495177545-23006-4-git-send-email-aisheng.dong@nxp.com>
On Fri, May 19, 2017 at 03:05:43PM +0800, Dong Aisheng wrote:
> MX7ULP MUX mode mask and shift bit is different from VF610.
> Let's make it a platform specific property for the later easy of
> adding MX7ULP support.
>
> One trick in exist code that Vybrid hardcoded the config part
> as 0xffff because its mux_config register BIT[15-0] are all configs
> part. But it's not true in ULP, so use mux_mask instead to address
> the difference.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stefan Agner <stefan@agner.ch>
> Cc: Bai Ping <ping.bai@nxp.com>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/5] pinctrl: imx: add soc specific mux_mode mask and shift property
Date: Sun, 21 May 2017 17:28:05 +0800 [thread overview]
Message-ID: <20170521092804.GL26102@dragon> (raw)
In-Reply-To: <1495177545-23006-4-git-send-email-aisheng.dong@nxp.com>
On Fri, May 19, 2017 at 03:05:43PM +0800, Dong Aisheng wrote:
> MX7ULP MUX mode mask and shift bit is different from VF610.
> Let's make it a platform specific property for the later easy of
> adding MX7ULP support.
>
> One trick in exist code that Vybrid hardcoded the config part
> as 0xffff because its mux_config register BIT[15-0] are all configs
> part. But it's not true in ULP, so use mux_mask instead to address
> the difference.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stefan Agner <stefan@agner.ch>
> Cc: Bai Ping <ping.bai@nxp.com>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
next prev parent reply other threads:[~2017-05-21 9:28 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 7:05 [PATCH V2 0/5] pinctrl: imx: add generic pin config and imx7ulp support Dong Aisheng
2017-05-19 7:05 ` Dong Aisheng
2017-05-19 7:05 ` [PATCH V2 1/5] pinctrl: imx: fix debug message for SHARE_MUX_CONF_REG case Dong Aisheng
2017-05-19 7:05 ` Dong Aisheng
2017-05-21 9:27 ` Shawn Guo
2017-05-21 9:27 ` Shawn Guo
2017-05-22 9:02 ` Linus Walleij
2017-05-22 9:02 ` Linus Walleij
2017-05-19 7:05 ` [PATCH V2 2/5] pinctrl: imx: add generic pin config core support Dong Aisheng
2017-05-19 7:05 ` Dong Aisheng
2017-05-21 9:27 ` Shawn Guo
2017-05-21 9:27 ` Shawn Guo
2017-05-22 9:04 ` Linus Walleij
2017-05-22 9:04 ` Linus Walleij
2017-05-19 7:05 ` [PATCH V2 3/5] pinctrl: imx: add soc specific mux_mode mask and shift property Dong Aisheng
2017-05-19 7:05 ` Dong Aisheng
2017-05-21 9:28 ` Shawn Guo [this message]
2017-05-21 9:28 ` Shawn Guo
2017-05-22 9:06 ` Linus Walleij
2017-05-22 9:06 ` Linus Walleij
2017-05-19 7:05 ` [PATCH V2 4/5] dt-bindings: pinctrl: add imx7ulp pinctrl binding doc Dong Aisheng
2017-05-19 7:05 ` Dong Aisheng
2017-05-22 9:27 ` Linus Walleij
2017-05-22 9:27 ` Linus Walleij
[not found] ` <CACRpkdb6B-f0uHUo9ecUmGCzY8GfFbCjNtJFeQJqtKEYwyB87A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-22 12:30 ` A.S. Dong
2017-05-22 12:30 ` A.S. Dong
[not found] ` <1495177545-23006-5-git-send-email-aisheng.dong-3arQi8VN3Tc@public.gmane.org>
2017-05-21 9:30 ` Shawn Guo
2017-05-21 9:30 ` Shawn Guo
2017-05-21 9:40 ` A.S. Dong
2017-05-21 9:40 ` A.S. Dong
[not found] ` <AM3PR04MB306654DEA7C2B7676D5C0EC80FB0-f56W/S9L6NSIzFHTN1kKrAfhPeD8jYilXA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2017-05-21 11:00 ` Shawn Guo
2017-05-21 11:00 ` Shawn Guo
2017-05-22 16:15 ` Stefan Agner
2017-05-22 16:15 ` Stefan Agner
2017-05-23 10:37 ` A.S. Dong
2017-05-23 10:37 ` A.S. Dong
2017-05-25 3:16 ` Shawn Guo
2017-05-25 3:16 ` Shawn Guo
2017-05-25 5:04 ` A.S. Dong
2017-05-25 5:04 ` A.S. Dong
[not found] ` <AM3PR04MB3068FA0B94C9B0D6269FC9C80FF0-f56W/S9L6NSIzFHTN1kKrAfhPeD8jYilXA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2017-05-25 6:23 ` Shawn Guo
2017-05-25 6:23 ` Shawn Guo
2017-05-25 6:48 ` Stefan Agner
2017-05-25 6:48 ` Stefan Agner
2017-05-19 7:05 ` [PATCH V2 5/5] pinctrl: imx: add imx7ulp driver Dong Aisheng
2017-05-19 7:05 ` Dong Aisheng
2017-05-21 9:31 ` Shawn Guo
2017-05-21 9:31 ` Shawn Guo
2017-05-23 7:41 ` [PATCH V2 0/5] pinctrl: imx: add generic pin config and imx7ulp support Linus Walleij
2017-05-23 7:41 ` Linus Walleij
2017-05-23 9:17 ` A.S. Dong
2017-05-23 9:17 ` A.S. Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521092804.GL26102@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.