[PATCH] intltool: Adds gettext as a DEPENDS

[PATCH] intltool: Adds gettext as a DEPENDS

[Alejandro Hernandez]

When setting USE_NLS="no" and building systemd-boot
(which DEPENDS on intltool), configure fails,
complaining about missing gettext:

configure: error: GNU gettext tools not found; required for intltool

This is caused because USE_NLS="no" makes the gettext class
add gettext-minimal-native to BASEDEPENDS instead of adding
gettext-native.

Since we still would like to set USE_NLS="no" and build systemd-boot,
we add gettext-native as a dependency to intltool-native, which makes it
available for the configure script of systemd-boot fixing the problem.

[YOCTO #11562]

Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
---
 meta/recipes-devtools/intltool/intltool_0.51.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/intltool/intltool_0.51.0.bb b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
index 551bdf0619a..ecff2faf253 100644
--- a/meta/recipes-devtools/intltool/intltool_0.51.0.bb
+++ b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
@@ -16,7 +16,7 @@ UPSTREAM_CHECK_URI = "https://launchpad.net/intltool/trunk/"
 
 DEPENDS = "libxml-parser-perl-native"
 RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"
-DEPENDS_class-native = "libxml-parser-perl-native"
+DEPENDS_class-native = "libxml-parser-perl-native gettext-native"
 
 inherit autotools pkgconfig perlnative
 
-- 
2.12.0

Re: [PATCH] intltool: Adds gettext as a DEPENDS

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1883 bytes --]

On Mon, May 22, 2017 at 3:25 PM Alejandro Hernandez <
alejandro.hernandez@linux.intel.com> wrote:

> When setting USE_NLS="no" and building systemd-boot
> (which DEPENDS on intltool), configure fails,
> complaining about missing gettext:
>
> configure: error: GNU gettext tools not found; required for intltool
>
> This is caused because USE_NLS="no" makes the gettext class
> add gettext-minimal-native to BASEDEPENDS instead of adding
> gettext-native.
>
> Since we still would like to set USE_NLS="no" and build systemd-boot,
> we add gettext-native as a dependency to intltool-native, which makes it
> available for the configure script of systemd-boot fixing the problem.
>
> [YOCTO #11562]
>
> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
> ---
>  meta/recipes-devtools/intltool/intltool_0.51.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/intltool/intltool_0.51.0.bb
> b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
> index 551bdf0619a..ecff2faf253 100644
> --- a/meta/recipes-devtools/intltool/intltool_0.51.0.bb
> +++ b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
> @@ -16,7 +16,7 @@ UPSTREAM_CHECK_URI = "
> https://launchpad.net/intltool/trunk/"
>
>  DEPENDS = "libxml-parser-perl-native"
>  RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"
> -DEPENDS_class-native = "libxml-parser-perl-native"
> +DEPENDS_class-native = "libxml-parser-perl-native gettext-native"


This will serialise the build I think it better to add the dep only when
NLS is down disabled

>
>
>  inherit autotools pkgconfig perlnative
>
> --
> 2.12.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3137 bytes --]

Re: [PATCH] intltool: Adds gettext as a DEPENDS

[Alejandro Hernandez]

[-- Attachment #1: Type: text/plain, Size: 2864 bytes --]

Hey Khem,


On 05/22/2017 05:41 PM, Khem Raj wrote:
>
> On Mon, May 22, 2017 at 3:25 PM Alejandro Hernandez 
> <alejandro.hernandez@linux.intel.com 
> <mailto:alejandro.hernandez@linux.intel.com>> wrote:
>
>     When setting USE_NLS="no" and building systemd-boot
>     (which DEPENDS on intltool), configure fails,
>     complaining about missing gettext:
>
>     configure: error: GNU gettext tools not found; required for intltool
>
>     This is caused because USE_NLS="no" makes the gettext class
>     add gettext-minimal-native to BASEDEPENDS instead of adding
>     gettext-native.
>
>     Since we still would like to set USE_NLS="no" and build systemd-boot,
>     we add gettext-native as a dependency to intltool-native, which
>     makes it
>     available for the configure script of systemd-boot fixing the problem.
>
>     [YOCTO #11562]
>
>     Signed-off-by: Alejandro Hernandez
>     <alejandro.hernandez@linux.intel.com
>     <mailto:alejandro.hernandez@linux.intel.com>>
>     ---
>      meta/recipes-devtools/intltool/intltool_0.51.0.bb
>     <http://intltool_0.51.0.bb> | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
>
>     diff --git a/meta/recipes-devtools/intltool/intltool_0.51.0.bb
>     <http://intltool_0.51.0.bb>
>     b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
>     <http://intltool_0.51.0.bb>
>     index 551bdf0619a..ecff2faf253 100644
>     --- a/meta/recipes-devtools/intltool/intltool_0.51.0.bb
>     <http://intltool_0.51.0.bb>
>     +++ b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
>     <http://intltool_0.51.0.bb>
>     @@ -16,7 +16,7 @@ UPSTREAM_CHECK_URI =
>     "https://launchpad.net/intltool/trunk/"
>
>      DEPENDS = "libxml-parser-perl-native"
>      RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"
>     -DEPENDS_class-native = "libxml-parser-perl-native"
>     +DEPENDS_class-native = "libxml-parser-perl-native gettext-native"
>
>
> This will serialise the build I think it better to add the dep only 
> when NLS is down disabled
I thought about doing so but I couldn't think of a clean way of doing it.

I can't get rid of it on the gettext.bbclass since it would mess up the 
work on b090fde5c184


What I can do, is set gettext-native as a DEPENDS to systemd-boot which 
is the one that is actually
complaining, this way we would keep returning gettext-minimal-native 
when USE_NLS="no", but we would
also fix the issue, what do you think?


>
>
>      inherit autotools pkgconfig perlnative
>
>     --
>     2.12.0
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>


[-- Attachment #2: Type: text/html, Size: 5527 bytes --]

Re: [PATCH] intltool: Adds gettext as a DEPENDS

[Khem Raj]

On Mon, May 22, 2017 at 4:08 PM, Alejandro Hernandez
<alejandro.hernandez@linux.intel.com> wrote:
> Hey Khem,
>
>
> On 05/22/2017 05:41 PM, Khem Raj wrote:
>
>
> On Mon, May 22, 2017 at 3:25 PM Alejandro Hernandez
> <alejandro.hernandez@linux.intel.com> wrote:
>>
>> When setting USE_NLS="no" and building systemd-boot
>> (which DEPENDS on intltool), configure fails,
>> complaining about missing gettext:
>>
>> configure: error: GNU gettext tools not found; required for intltool
>>
>> This is caused because USE_NLS="no" makes the gettext class
>> add gettext-minimal-native to BASEDEPENDS instead of adding
>> gettext-native.
>>
>> Since we still would like to set USE_NLS="no" and build systemd-boot,
>> we add gettext-native as a dependency to intltool-native, which makes it
>> available for the configure script of systemd-boot fixing the problem.
>>
>> [YOCTO #11562]
>>
>> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
>> ---
>>  meta/recipes-devtools/intltool/intltool_0.51.0.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/intltool/intltool_0.51.0.bb
>> b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
>> index 551bdf0619a..ecff2faf253 100644
>> --- a/meta/recipes-devtools/intltool/intltool_0.51.0.bb
>> +++ b/meta/recipes-devtools/intltool/intltool_0.51.0.bb
>> @@ -16,7 +16,7 @@ UPSTREAM_CHECK_URI =
>> "https://launchpad.net/intltool/trunk/"
>>
>>  DEPENDS = "libxml-parser-perl-native"
>>  RDEPENDS_${PN} = "gettext-dev libxml-parser-perl"
>> -DEPENDS_class-native = "libxml-parser-perl-native"
>> +DEPENDS_class-native = "libxml-parser-perl-native gettext-native"
>
>
> This will serialise the build I think it better to add the dep only when NLS
> is down disabled
>
> I thought about doing so but I couldn't think of a clean way of doing it.
>
> I can't get rid of it on the gettext.bbclass since it would mess up the work
> on b090fde5c184
>
>
> What I can do, is set gettext-native as a DEPENDS to systemd-boot which is
> the one that is actually
> complaining, this way we would keep returning gettext-minimal-native when
> USE_NLS="no", but we would
> also fix the issue, what do you think?

Looking  more closely, I realize this is right fix since all packages that need
intltool would invariably need gettext during configure