From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings
Date: Thu, 25 May 2017 18:58:44 +0200 [thread overview]
Message-ID: <20170525165844.GA8812@kroah.com> (raw)
In-Reply-To: <20170522120935.4119-2-laurentiu.tudor@nxp.com>
On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor at nxp.com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Your subject line is very odd, please use the 'v2' marking properly...
>
> Remove several unneeded #includes, forward
> declarations and fix several issues reported
> by checkpatch.pl --strict, such as:
> - kfree(NULL) is safe and check is not required
> - macro argument reuse may cause possible side effects
> - enclose macro params in parens to avoid precedence issues
> - coding style
These, as always, need to be broken up into one-patch-per-type-of-thing,
you have been in the staging tree long enough to know this :(
Please do this first, then we can consider the rest of the series...
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: laurentiu.tudor@nxp.com
Cc: stuyoder@gmail.com, devel@driverdev.osuosl.org, arnd@arndb.de,
roy.pledge@nxp.com, linux-kernel@vger.kernel.org, agraf@suse.de,
catalin.horghidan@nxp.com, ioana.ciornei@nxp.com,
leoyang.li@nxp.com, bharat.bhushan@nxp.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings
Date: Thu, 25 May 2017 18:58:44 +0200 [thread overview]
Message-ID: <20170525165844.GA8812@kroah.com> (raw)
In-Reply-To: <20170522120935.4119-2-laurentiu.tudor@nxp.com>
On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor@nxp.com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Your subject line is very odd, please use the 'v2' marking properly...
>
> Remove several unneeded #includes, forward
> declarations and fix several issues reported
> by checkpatch.pl --strict, such as:
> - kfree(NULL) is safe and check is not required
> - macro argument reuse may cause possible side effects
> - enclose macro params in parens to avoid precedence issues
> - coding style
These, as always, need to be broken up into one-patch-per-type-of-thing,
you have been in the staging tree long enough to know this :(
Please do this first, then we can consider the rest of the series...
thanks,
greg k-h
next prev parent reply other threads:[~2017-05-25 16:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 12:09 [PATCH 0/5][v5] staging: fsl-mc: move bus driver out of staging laurentiu.tudor at nxp.com
2017-05-22 12:09 ` laurentiu.tudor
2017-05-22 12:09 ` [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings laurentiu.tudor at nxp.com
2017-05-22 12:09 ` laurentiu.tudor
2017-05-25 16:58 ` Greg KH [this message]
2017-05-25 16:58 ` Greg KH
2017-05-26 13:19 ` Laurentiu Tudor
2017-05-26 13:19 ` Laurentiu Tudor
2017-05-22 12:09 ` [PATCH 2/5][v2] staging: fsl-mc: add binding path to MAINTAINERS laurentiu.tudor at nxp.com
2017-05-22 12:09 ` laurentiu.tudor
2017-05-25 16:59 ` Greg KH
2017-05-25 16:59 ` Greg KH
2017-05-25 16:59 ` Greg KH
2017-05-25 16:59 ` Greg KH
2017-05-22 12:09 ` [PATCH 3/5] staging: fsl-mc: drop reference to restool laurentiu.tudor at nxp.com
2017-05-22 12:09 ` laurentiu.tudor
2017-05-22 12:09 ` [PATCH 4/5] staging: fsl-mc: add reference to mc-bus DT binding laurentiu.tudor at nxp.com
2017-05-22 12:09 ` laurentiu.tudor
2017-05-22 12:09 ` [PATCH 5/5][v5] staging: fsl-mc: move bus driver out of staging laurentiu.tudor at nxp.com
2017-05-22 12:09 ` laurentiu.tudor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525165844.GA8812@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.