From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Bogdan Purcareata <bogdan.purcareata-3arQi8VN3Tc@public.gmane.org>
Cc: f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 2/2] dt-bindings: net: Add Cortina device tree bindings
Date: Fri, 26 May 2017 15:35:54 +0200 [thread overview]
Message-ID: <20170526133554.GD31389@lunn.ch> (raw)
In-Reply-To: <1495785519-1468-3-git-send-email-bogdan.purcareata-3arQi8VN3Tc@public.gmane.org>
> + cs4340_phy@1 {
> + compatible = "ethernet-phy-id13e5.1002";
> + reg = <0x10>;
The @1 and the reg value should be the same. Please change it to
cs4340_phy@10.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Bogdan Purcareata <bogdan.purcareata@nxp.com>
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: net: Add Cortina device tree bindings
Date: Fri, 26 May 2017 15:35:54 +0200 [thread overview]
Message-ID: <20170526133554.GD31389@lunn.ch> (raw)
In-Reply-To: <1495785519-1468-3-git-send-email-bogdan.purcareata@nxp.com>
> + cs4340_phy@1 {
> + compatible = "ethernet-phy-id13e5.1002";
> + reg = <0x10>;
The @1 and the reg value should be the same. Please change it to
cs4340_phy@10.
Andrew
next prev parent reply other threads:[~2017-05-26 13:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 7:58 [PATCH v3 0/2] net: phy: Support managed Cortina phys Bogdan Purcareata
2017-05-26 7:58 ` Bogdan Purcareata
2017-05-26 7:58 ` Bogdan Purcareata
2017-05-26 7:58 ` [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver Bogdan Purcareata
2017-05-26 7:58 ` Bogdan Purcareata
2017-05-26 7:58 ` [PATCH v3 2/2] dt-bindings: net: Add Cortina device tree bindings Bogdan Purcareata
2017-05-26 7:58 ` Bogdan Purcareata
[not found] ` <1495785519-1468-3-git-send-email-bogdan.purcareata-3arQi8VN3Tc@public.gmane.org>
2017-05-26 13:35 ` Andrew Lunn [this message]
2017-05-26 13:35 ` Andrew Lunn
2017-05-26 13:41 ` Bogdan Purcareata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526133554.GD31389@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=bogdan.purcareata-3arQi8VN3Tc@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.