All of lore.kernel.org
 help / color / mirror / Atom feed
From: leon@kernel.org (Leon Romanovsky)
Subject: [PATCH v2 2/2] IB/mlx5: set UMR wqe fence according to HCA cap
Date: Mon, 29 May 2017 13:05:04 +0300	[thread overview]
Message-ID: <20170529100504.GZ17751@mtr-leonro.local> (raw)
In-Reply-To: <19a1d347-91da-7e5f-8877-86772204a80a@mellanox.com>

On Sun, May 28, 2017@12:53:00PM +0300, Max Gurtovoy wrote:
>
>
> On 5/28/2017 12:07 PM, Christoph Hellwig wrote:
> > On Sun, May 28, 2017@10:53:11AM +0300, Max Gurtovoy wrote:
> > > Cache the needed umr_fence and set the wqe ctrl segmennt
> > > accordingly.
> >
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig <hch at lst.de>
>
> Thanks.
>
> >
> > But that whole fence logic looks awkward to me.  Does the following
> > patch to reorder it make sense to you?
> >
>
>
> Yes it make sense to me.
> Sagi/Leon, any comments ?

Max,

Do you see any performance impact for IB_WR_RDMA_READ, IB_WR_RDMA_WRITE
and IB_WR_RDMA_WRITE_WITH_IMM flows? They don't need fences and such
change can cause to performance losses.

Thanks


>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20170529/b2c6f7d0/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	shahar.salzman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	joseph.r.gruher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	mrybczyn-FNhOzJFKnXGHXe+LvDLADg@public.gmane.org,
	vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	oren-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v2 2/2] IB/mlx5: set UMR wqe fence according to HCA cap
Date: Mon, 29 May 2017 13:05:04 +0300	[thread overview]
Message-ID: <20170529100504.GZ17751@mtr-leonro.local> (raw)
In-Reply-To: <19a1d347-91da-7e5f-8877-86772204a80a-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On Sun, May 28, 2017 at 12:53:00PM +0300, Max Gurtovoy wrote:
>
>
> On 5/28/2017 12:07 PM, Christoph Hellwig wrote:
> > On Sun, May 28, 2017 at 10:53:11AM +0300, Max Gurtovoy wrote:
> > > Cache the needed umr_fence and set the wqe ctrl segmennt
> > > accordingly.
> >
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
>
> Thanks.
>
> >
> > But that whole fence logic looks awkward to me.  Does the following
> > patch to reorder it make sense to you?
> >
>
>
> Yes it make sense to me.
> Sagi/Leon, any comments ?

Max,

Do you see any performance impact for IB_WR_RDMA_READ, IB_WR_RDMA_WRITE
and IB_WR_RDMA_WRITE_WITH_IMM flows? They don't need fences and such
change can cause to performance losses.

Thanks


>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-05-29 10:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28  7:53 [PATCH v2 1/2] net/mlx5: Define interface bits for fencing UMR wqe Max Gurtovoy
2017-05-28  7:53 ` Max Gurtovoy
2017-05-28  7:53 ` [PATCH v2 2/2] IB/mlx5: set UMR wqe fence according to HCA cap Max Gurtovoy
2017-05-28  7:53   ` Max Gurtovoy
2017-05-28  9:07   ` Christoph Hellwig
2017-05-28  9:07     ` Christoph Hellwig
2017-05-28  9:53     ` Max Gurtovoy
2017-05-28  9:53       ` Max Gurtovoy
2017-05-29 10:05       ` Leon Romanovsky [this message]
2017-05-29 10:05         ` Leon Romanovsky
2017-05-29 12:21         ` Max Gurtovoy
2017-05-29 12:21           ` Max Gurtovoy
2017-05-29 16:06           ` Leon Romanovsky
2017-05-29 16:06             ` Leon Romanovsky
2017-05-30 10:51             ` Sagi Grimberg
2017-05-30 10:51               ` Sagi Grimberg
2017-05-30 17:15               ` Leon Romanovsky
2017-05-30 17:15                 ` Leon Romanovsky
2017-05-30 10:48   ` Sagi Grimberg
2017-05-30 10:48     ` Sagi Grimberg
2017-05-30 11:15     ` Max Gurtovoy
2017-05-30 11:15       ` Max Gurtovoy
2017-05-30 11:22       ` Sagi Grimberg
2017-05-30 11:22         ` Sagi Grimberg
2017-05-30 11:24         ` Max Gurtovoy
2017-05-30 11:24           ` Max Gurtovoy
2017-05-30 14:28           ` Sagi Grimberg
2017-05-30 14:28             ` Sagi Grimberg
2017-05-30 20:41             ` Max Gurtovoy
2017-05-30 20:41               ` Max Gurtovoy
2017-05-28  9:14 ` [PATCH v2 1/2] net/mlx5: Define interface bits for fencing UMR wqe Christoph Hellwig
2017-05-28  9:14   ` Christoph Hellwig
2017-06-01 22:51 ` Doug Ledford
2017-06-01 22:51   ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170529100504.GZ17751@mtr-leonro.local \
    --to=leon@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.