From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function
Date: Tue, 6 Jun 2017 15:51:48 +0200 [thread overview]
Message-ID: <20170606135148.GA22618@kwain.lan> (raw)
In-Reply-To: <20170606154535.3e87bafb@free-electrons.com>
Hello Thomas,
On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote:
> On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote:
> > The mvpp22_port_mii_set() function was added by 2697582144dd, but the
> > function directly returns without doing anything. This return was used
> > when debugging and wasn't removed before sending the patch. Fix this.
> >
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
>
> Please add:
>
> Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
>
> with this:
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
OK, will do.
> I am wondering if we shouldn't Cc: stable as well. I don't think we
> have seen issues on our side because U-Boot does the necessary
> initialization, but people using other bootloaders might have issues.
Yes, that might be safer to cc stable. I'll do this as well.
Thanks,
Antoine
--
Antoine T?nart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170606/c5161206/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
davem@davemloft.net, netdev@vger.kernel.org,
gregory.clement@free-electrons.com, mw@semihalf.com,
linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function
Date: Tue, 6 Jun 2017 15:51:48 +0200 [thread overview]
Message-ID: <20170606135148.GA22618@kwain.lan> (raw)
In-Reply-To: <20170606154535.3e87bafb@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
Hello Thomas,
On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote:
> On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote:
> > The mvpp22_port_mii_set() function was added by 2697582144dd, but the
> > function directly returns without doing anything. This return was used
> > when debugging and wasn't removed before sending the patch. Fix this.
> >
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
>
> Please add:
>
> Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
>
> with this:
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
OK, will do.
> I am wondering if we shouldn't Cc: stable as well. I don't think we
> have seen issues on our side because U-Boot does the necessary
> initialization, but people using other bootloaders might have issues.
Yes, that might be safer to cc stable. I'll do this as well.
Thanks,
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-06-06 13:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 13:36 [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function Antoine Tenart
2017-06-06 13:36 ` Antoine Tenart
2017-06-06 13:45 ` Thomas Petazzoni
2017-06-06 13:45 ` Thomas Petazzoni
2017-06-06 13:51 ` Antoine Tenart [this message]
2017-06-06 13:51 ` Antoine Tenart
2017-06-06 14:24 ` Florian Fainelli
2017-06-06 14:24 ` Florian Fainelli
2017-06-06 14:38 ` Antoine Tenart
2017-06-06 14:38 ` Antoine Tenart
2017-06-06 15:44 ` Sergei Shtylyov
2017-06-06 15:44 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606135148.GA22618@kwain.lan \
--to=antoine.tenart@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.