* [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function @ 2017-06-06 13:36 ` Antoine Tenart 0 siblings, 0 replies; 12+ messages in thread From: Antoine Tenart @ 2017-06-06 13:36 UTC (permalink / raw) To: linux-arm-kernel The mvpp22_port_mii_set() function was added by 2697582144dd, but the function directly returns without doing anything. This return was used when debugging and wasn't removed before sending the patch. Fix this. Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 9b875d776b29..70bca2a6fb02 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -4186,8 +4186,6 @@ static void mvpp22_port_mii_set(struct mvpp2_port *port) { u32 val; - return; - /* Only GOP port 0 has an XLG MAC */ if (port->gop_id == 0) { val = readl(port->base + MVPP22_XLG_CTRL3_REG); -- 2.9.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function @ 2017-06-06 13:36 ` Antoine Tenart 0 siblings, 0 replies; 12+ messages in thread From: Antoine Tenart @ 2017-06-06 13:36 UTC (permalink / raw) To: davem, netdev, thomas.petazzoni Cc: Antoine Tenart, gregory.clement, mw, linux, linux-arm-kernel The mvpp22_port_mii_set() function was added by 2697582144dd, but the function directly returns without doing anything. This return was used when debugging and wasn't removed before sending the patch. Fix this. Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 9b875d776b29..70bca2a6fb02 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -4186,8 +4186,6 @@ static void mvpp22_port_mii_set(struct mvpp2_port *port) { u32 val; - return; - /* Only GOP port 0 has an XLG MAC */ if (port->gop_id == 0) { val = readl(port->base + MVPP22_XLG_CTRL3_REG); -- 2.9.4 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function 2017-06-06 13:36 ` Antoine Tenart @ 2017-06-06 13:45 ` Thomas Petazzoni -1 siblings, 0 replies; 12+ messages in thread From: Thomas Petazzoni @ 2017-06-06 13:45 UTC (permalink / raw) To: linux-arm-kernel Hello, On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: > The mvpp22_port_mii_set() function was added by 2697582144dd, but the > function directly returns without doing anything. This return was used > when debugging and wasn't removed before sending the patch. Fix this. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> Please add: Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") with this: Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> I am wondering if we shouldn't Cc: stable as well. I don't think we have seen issues on our side because U-Boot does the necessary initialization, but people using other bootloaders might have issues. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function @ 2017-06-06 13:45 ` Thomas Petazzoni 0 siblings, 0 replies; 12+ messages in thread From: Thomas Petazzoni @ 2017-06-06 13:45 UTC (permalink / raw) To: Antoine Tenart Cc: davem, netdev, gregory.clement, mw, linux, linux-arm-kernel Hello, On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: > The mvpp22_port_mii_set() function was added by 2697582144dd, but the > function directly returns without doing anything. This return was used > when debugging and wasn't removed before sending the patch. Fix this. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> Please add: Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") with this: Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> I am wondering if we shouldn't Cc: stable as well. I don't think we have seen issues on our side because U-Boot does the necessary initialization, but people using other bootloaders might have issues. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function 2017-06-06 13:45 ` Thomas Petazzoni @ 2017-06-06 13:51 ` Antoine Tenart -1 siblings, 0 replies; 12+ messages in thread From: Antoine Tenart @ 2017-06-06 13:51 UTC (permalink / raw) To: linux-arm-kernel Hello Thomas, On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: > On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: > > The mvpp22_port_mii_set() function was added by 2697582144dd, but the > > function directly returns without doing anything. This return was used > > when debugging and wasn't removed before sending the patch. Fix this. > > > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > > Please add: > > Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") > > with this: > > Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> OK, will do. > I am wondering if we shouldn't Cc: stable as well. I don't think we > have seen issues on our side because U-Boot does the necessary > initialization, but people using other bootloaders might have issues. Yes, that might be safer to cc stable. I'll do this as well. Thanks, Antoine -- Antoine T?nart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170606/c5161206/attachment.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function @ 2017-06-06 13:51 ` Antoine Tenart 0 siblings, 0 replies; 12+ messages in thread From: Antoine Tenart @ 2017-06-06 13:51 UTC (permalink / raw) To: Thomas Petazzoni Cc: Antoine Tenart, davem, netdev, gregory.clement, mw, linux, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 1055 bytes --] Hello Thomas, On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: > On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: > > The mvpp22_port_mii_set() function was added by 2697582144dd, but the > > function directly returns without doing anything. This return was used > > when debugging and wasn't removed before sending the patch. Fix this. > > > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > > Please add: > > Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") > > with this: > > Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> OK, will do. > I am wondering if we shouldn't Cc: stable as well. I don't think we > have seen issues on our side because U-Boot does the necessary > initialization, but people using other bootloaders might have issues. Yes, that might be safer to cc stable. I'll do this as well. Thanks, Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function 2017-06-06 13:51 ` Antoine Tenart @ 2017-06-06 14:24 ` Florian Fainelli -1 siblings, 0 replies; 12+ messages in thread From: Florian Fainelli @ 2017-06-06 14:24 UTC (permalink / raw) To: linux-arm-kernel On 06/06/2017 06:51 AM, Antoine Tenart wrote: > Hello Thomas, > > On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: >> On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: >>> The mvpp22_port_mii_set() function was added by 2697582144dd, but the >>> function directly returns without doing anything. This return was used >>> when debugging and wasn't removed before sending the patch. Fix this. >>> >>> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> >> >> Please add: >> >> Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") >> >> with this: >> >> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > OK, will do. > >> I am wondering if we shouldn't Cc: stable as well. I don't think we >> have seen issues on our side because U-Boot does the necessary >> initialization, but people using other bootloaders might have issues. > > Yes, that might be safer to cc stable. I'll do this as well. David queues network patches for stable provided that you submit those against his "net" tree [1] and there is an appropriate Fixes tag (which Thomas provided). [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n114 -- Florian ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function @ 2017-06-06 14:24 ` Florian Fainelli 0 siblings, 0 replies; 12+ messages in thread From: Florian Fainelli @ 2017-06-06 14:24 UTC (permalink / raw) To: Antoine Tenart, Thomas Petazzoni Cc: netdev, linux, gregory.clement, mw, davem, linux-arm-kernel On 06/06/2017 06:51 AM, Antoine Tenart wrote: > Hello Thomas, > > On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: >> On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: >>> The mvpp22_port_mii_set() function was added by 2697582144dd, but the >>> function directly returns without doing anything. This return was used >>> when debugging and wasn't removed before sending the patch. Fix this. >>> >>> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> >> >> Please add: >> >> Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") >> >> with this: >> >> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > OK, will do. > >> I am wondering if we shouldn't Cc: stable as well. I don't think we >> have seen issues on our side because U-Boot does the necessary >> initialization, but people using other bootloaders might have issues. > > Yes, that might be safer to cc stable. I'll do this as well. David queues network patches for stable provided that you submit those against his "net" tree [1] and there is an appropriate Fixes tag (which Thomas provided). [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n114 -- Florian ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function 2017-06-06 14:24 ` Florian Fainelli @ 2017-06-06 14:38 ` Antoine Tenart -1 siblings, 0 replies; 12+ messages in thread From: Antoine Tenart @ 2017-06-06 14:38 UTC (permalink / raw) To: linux-arm-kernel Hi Florian, On Tue, Jun 06, 2017 at 07:24:35AM -0700, Florian Fainelli wrote: > On 06/06/2017 06:51 AM, Antoine Tenart wrote: > > On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: > > > >> I am wondering if we shouldn't Cc: stable as well. I don't think we > >> have seen issues on our side because U-Boot does the necessary > >> initialization, but people using other bootloaders might have issues. > > > > Yes, that might be safer to cc stable. I'll do this as well. > > David queues network patches for stable provided that you submit those > against his "net" tree [1] and there is an appropriate Fixes tag (which > Thomas provided). > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n114 That's good to know! Thanks, Antoine -- Antoine T?nart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170606/282ee4c6/attachment-0001.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function @ 2017-06-06 14:38 ` Antoine Tenart 0 siblings, 0 replies; 12+ messages in thread From: Antoine Tenart @ 2017-06-06 14:38 UTC (permalink / raw) To: Florian Fainelli Cc: Antoine Tenart, Thomas Petazzoni, netdev, linux, gregory.clement, mw, davem, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 954 bytes --] Hi Florian, On Tue, Jun 06, 2017 at 07:24:35AM -0700, Florian Fainelli wrote: > On 06/06/2017 06:51 AM, Antoine Tenart wrote: > > On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: > > > >> I am wondering if we shouldn't Cc: stable as well. I don't think we > >> have seen issues on our side because U-Boot does the necessary > >> initialization, but people using other bootloaders might have issues. > > > > Yes, that might be safer to cc stable. I'll do this as well. > > David queues network patches for stable provided that you submit those > against his "net" tree [1] and there is an appropriate Fixes tag (which > Thomas provided). > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n114 That's good to know! Thanks, Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function 2017-06-06 13:36 ` Antoine Tenart @ 2017-06-06 15:44 ` Sergei Shtylyov -1 siblings, 0 replies; 12+ messages in thread From: Sergei Shtylyov @ 2017-06-06 15:44 UTC (permalink / raw) To: linux-arm-kernel Hello! On 06/06/2017 04:36 PM, Antoine Tenart wrote: > The mvpp22_port_mii_set() function was added by 2697582144dd, but the Need to also specify the commit summary line enclosed in (""). > function directly returns without doing anything. This return was used > when debugging and wasn't removed before sending the patch. Fix this. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> [...] MBR, Sergei ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function @ 2017-06-06 15:44 ` Sergei Shtylyov 0 siblings, 0 replies; 12+ messages in thread From: Sergei Shtylyov @ 2017-06-06 15:44 UTC (permalink / raw) To: Antoine Tenart, davem, netdev, thomas.petazzoni Cc: gregory.clement, mw, linux, linux-arm-kernel Hello! On 06/06/2017 04:36 PM, Antoine Tenart wrote: > The mvpp22_port_mii_set() function was added by 2697582144dd, but the Need to also specify the commit summary line enclosed in (""). > function directly returns without doing anything. This return was used > when debugging and wasn't removed before sending the patch. Fix this. > > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> [...] MBR, Sergei ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-06-06 15:44 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-06-06 13:36 [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function Antoine Tenart 2017-06-06 13:36 ` Antoine Tenart 2017-06-06 13:45 ` Thomas Petazzoni 2017-06-06 13:45 ` Thomas Petazzoni 2017-06-06 13:51 ` Antoine Tenart 2017-06-06 13:51 ` Antoine Tenart 2017-06-06 14:24 ` Florian Fainelli 2017-06-06 14:24 ` Florian Fainelli 2017-06-06 14:38 ` Antoine Tenart 2017-06-06 14:38 ` Antoine Tenart 2017-06-06 15:44 ` Sergei Shtylyov 2017-06-06 15:44 ` Sergei Shtylyov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.