All of lore.kernel.org
 help / color / mirror / Atom feed
From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] net: mvmdio: add xmdio support
Date: Wed, 7 Jun 2017 16:42:32 +0200	[thread overview]
Message-ID: <20170607144232.GA4173@kwain> (raw)
In-Reply-To: <20170607121205.GC1271@lunn.ch>

Hi Andrew,

On Wed, Jun 07, 2017 at 02:12:05PM +0200, Andrew Lunn wrote:
> On Wed, Jun 07, 2017 at 10:38:08AM +0200, Antoine Tenart wrote:
> > This patch adds the xMDIO interface support in the mvmdio driver. This
> > interface is used in Ethernet controllers on Marvell 370, 7k and 8k (as
> > of now). The xSMI interface supported by this driver complies with the
> > IEEE 802.3 clause 45 (while the SMI interface complies with the clause
> > 22). The xSMI interface is used by 10GbE devices.
> 
> I've only take a quick look, but i don't see anywhere you look at the
> register address and see if it has MII_ADDR_C45 to determine if a C45
> transaction should be done, or a C22. The MDIO bus can have a mix of
> C45 and C22 devices on it, and you need to use the correct transaction
> type depending on the target device/address.

So this could be dynamic and not based on the compatible. I'll try this
and see if it can work.

Thanks!

-- 
Antoine T?nart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170607/a008eb2c/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: thomas.petazzoni@free-electrons.com, f.fainelli@gmail.com,
	jason@lakedaemon.net, netdev@vger.kernel.org,
	Antoine Tenart <antoine.tenart@free-electrons.com>,
	linux@armlinux.org.uk, gregory.clement@free-electrons.com,
	mw@semihalf.com, davem@davemloft.net,
	linux-arm-kernel@lists.infradead.org,
	sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH 7/9] net: mvmdio: add xmdio support
Date: Wed, 7 Jun 2017 16:42:32 +0200	[thread overview]
Message-ID: <20170607144232.GA4173@kwain> (raw)
In-Reply-To: <20170607121205.GC1271@lunn.ch>


[-- Attachment #1.1: Type: text/plain, Size: 1063 bytes --]

Hi Andrew,

On Wed, Jun 07, 2017 at 02:12:05PM +0200, Andrew Lunn wrote:
> On Wed, Jun 07, 2017 at 10:38:08AM +0200, Antoine Tenart wrote:
> > This patch adds the xMDIO interface support in the mvmdio driver. This
> > interface is used in Ethernet controllers on Marvell 370, 7k and 8k (as
> > of now). The xSMI interface supported by this driver complies with the
> > IEEE 802.3 clause 45 (while the SMI interface complies with the clause
> > 22). The xSMI interface is used by 10GbE devices.
> 
> I've only take a quick look, but i don't see anywhere you look at the
> register address and see if it has MII_ADDR_C45 to determine if a C45
> transaction should be done, or a C22. The MDIO bus can have a mix of
> C45 and C22 devices on it, and you need to use the correct transaction
> type depending on the target device/address.

So this could be dynamic and not based on the compatible. I'll try this
and see if it can work.

Thanks!

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2017-06-07 14:42 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07  8:38 [PATCH 0/9] net: mvmdio: add xSMI support Antoine Tenart
2017-06-07  8:38 ` Antoine Tenart
2017-06-07  8:38 ` [PATCH 1/9] net: mvmdio: reorder headers alphabetically Antoine Tenart
2017-06-07  8:38   ` Antoine Tenart
2017-06-07 19:24   ` Florian Fainelli
2017-06-07 19:24     ` Florian Fainelli
2017-06-07  8:38 ` [PATCH 2/9] net: mvmdio: use tabs for defines Antoine Tenart
2017-06-07  8:38   ` Antoine Tenart
2017-06-07 19:24   ` Florian Fainelli
2017-06-07 19:24     ` Florian Fainelli
2017-06-07  8:38 ` [PATCH 3/9] net: mvmdio: use GENMASK for masks Antoine Tenart
2017-06-07  8:38   ` Antoine Tenart
2017-06-07 19:24   ` Florian Fainelli
2017-06-07 19:24     ` Florian Fainelli
2017-06-07  8:38 ` [PATCH 4/9] net: mvmdio: move the read valid check into its own function Antoine Tenart
2017-06-07  8:38   ` Antoine Tenart
2017-06-07 10:00   ` Sergei Shtylyov
2017-06-07 10:00     ` Sergei Shtylyov
2017-06-07 14:43     ` Antoine Tenart
2017-06-07 14:43       ` Antoine Tenart
2017-06-07  8:38 ` [PATCH 5/9] net: mvmdio: introduce an ops structure Antoine Tenart
2017-06-07  8:38   ` Antoine Tenart
2017-06-07 19:28   ` Florian Fainelli
2017-06-07 19:28     ` Florian Fainelli
2017-06-07  8:38 ` [PATCH 6/9] net: mvmdio: put the poll intervals in the private structure Antoine Tenart
2017-06-07  8:38   ` Antoine Tenart
2017-06-07 19:25   ` Florian Fainelli
2017-06-07 19:25     ` Florian Fainelli
2017-06-07  8:38 ` [PATCH 7/9] net: mvmdio: add xmdio support Antoine Tenart
2017-06-07  8:38   ` Antoine Tenart
2017-06-07 12:12   ` Andrew Lunn
2017-06-07 12:12     ` Andrew Lunn
2017-06-07 14:42     ` Antoine Tenart [this message]
2017-06-07 14:42       ` Antoine Tenart
2017-06-07 15:48   ` Florian Fainelli
2017-06-07 15:48     ` Florian Fainelli
2017-06-07 15:56     ` Russell King - ARM Linux
2017-06-07 15:56       ` Russell King - ARM Linux
2017-06-07 16:13     ` Antoine Tenart
2017-06-07 16:13       ` Antoine Tenart
2017-06-07  8:38 ` [PATCH 8/9] dt-bindings: orion-mdio: document the new xmdio compatible Antoine Tenart
2017-06-07  8:38   ` Antoine Tenart
2017-06-07  8:38 ` [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k Antoine Tenart
2017-06-07  8:38   ` Antoine Tenart
2017-06-07  8:43   ` Gregory CLEMENT
2017-06-07  8:43     ` Gregory CLEMENT
2017-06-07 19:09     ` David Miller
2017-06-07 19:09       ` David Miller
2017-06-08  8:45   ` Antoine Tenart
2017-06-08  8:45     ` Antoine Tenart
2017-06-08  8:51     ` Antoine Tenart
2017-06-08  8:51       ` Antoine Tenart
2017-06-08  8:55     ` Gregory CLEMENT
2017-06-08  8:55       ` Gregory CLEMENT
2017-06-08  9:03       ` Antoine Tenart
2017-06-08  9:03         ` Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607144232.GA4173@kwain \
    --to=antoine.tenart@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.