From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k
Date: Thu, 08 Jun 2017 10:55:01 +0200 [thread overview]
Message-ID: <8737barh96.fsf@free-electrons.com> (raw)
In-Reply-To: <20170608084515.GA12385@kwain> (Antoine Tenart's message of "Thu, 8 Jun 2017 10:45:15 +0200")
Hi Antoine,
On jeu., juin 08 2017, Antoine Tenart <antoine.tenart@free-electrons.com> wrote:
> Hi Gregory,
>
> On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote:
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> index 2a99ff8fca2a..594356243ddb 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> @@ -103,6 +103,13 @@
>> clocks = <&cps_syscon0 1 9>, <&cps_syscon0 1 5>;
>> };
>>
>> + cps_xmdio: mdio at 12a600 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "marvell,xmdio";
>> + reg = <0x12a600 0x10>;
>> + };
>> +
>
> Russell pointed out on IRC the mdio/xmdio interfaces aren't wired to
> anything on the mcbin. We could either disable these interfaces by
> default, or add explicit disables in the mcbin device tree.
>
> What's your thoughts on this?
I prefer that we disable it by default and only enable it on the boards
using it.
Thanks,
Gregory
>
> Thanks!
> Antoine
>
> --
> Antoine T?nart, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: davem@davemloft.net, jason@lakedaemon.net, andrew@lunn.ch,
sebastian.hesselbarth@gmail.com, f.fainelli@gmail.com,
thomas.petazzoni@free-electrons.com, mw@semihalf.com,
linux@armlinux.org.uk, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k
Date: Thu, 08 Jun 2017 10:55:01 +0200 [thread overview]
Message-ID: <8737barh96.fsf@free-electrons.com> (raw)
In-Reply-To: <20170608084515.GA12385@kwain> (Antoine Tenart's message of "Thu, 8 Jun 2017 10:45:15 +0200")
Hi Antoine,
On jeu., juin 08 2017, Antoine Tenart <antoine.tenart@free-electrons.com> wrote:
> Hi Gregory,
>
> On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote:
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> index 2a99ff8fca2a..594356243ddb 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi
>> @@ -103,6 +103,13 @@
>> clocks = <&cps_syscon0 1 9>, <&cps_syscon0 1 5>;
>> };
>>
>> + cps_xmdio: mdio@12a600 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "marvell,xmdio";
>> + reg = <0x12a600 0x10>;
>> + };
>> +
>
> Russell pointed out on IRC the mdio/xmdio interfaces aren't wired to
> anything on the mcbin. We could either disable these interfaces by
> default, or add explicit disables in the mcbin device tree.
>
> What's your thoughts on this?
I prefer that we disable it by default and only enable it on the boards
using it.
Thanks,
Gregory
>
> Thanks!
> Antoine
>
> --
> Antoine Ténart, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-06-08 8:55 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 8:38 [PATCH 0/9] net: mvmdio: add xSMI support Antoine Tenart
2017-06-07 8:38 ` Antoine Tenart
2017-06-07 8:38 ` [PATCH 1/9] net: mvmdio: reorder headers alphabetically Antoine Tenart
2017-06-07 8:38 ` Antoine Tenart
2017-06-07 19:24 ` Florian Fainelli
2017-06-07 19:24 ` Florian Fainelli
2017-06-07 8:38 ` [PATCH 2/9] net: mvmdio: use tabs for defines Antoine Tenart
2017-06-07 8:38 ` Antoine Tenart
2017-06-07 19:24 ` Florian Fainelli
2017-06-07 19:24 ` Florian Fainelli
2017-06-07 8:38 ` [PATCH 3/9] net: mvmdio: use GENMASK for masks Antoine Tenart
2017-06-07 8:38 ` Antoine Tenart
2017-06-07 19:24 ` Florian Fainelli
2017-06-07 19:24 ` Florian Fainelli
2017-06-07 8:38 ` [PATCH 4/9] net: mvmdio: move the read valid check into its own function Antoine Tenart
2017-06-07 8:38 ` Antoine Tenart
2017-06-07 10:00 ` Sergei Shtylyov
2017-06-07 10:00 ` Sergei Shtylyov
2017-06-07 14:43 ` Antoine Tenart
2017-06-07 14:43 ` Antoine Tenart
2017-06-07 8:38 ` [PATCH 5/9] net: mvmdio: introduce an ops structure Antoine Tenart
2017-06-07 8:38 ` Antoine Tenart
2017-06-07 19:28 ` Florian Fainelli
2017-06-07 19:28 ` Florian Fainelli
2017-06-07 8:38 ` [PATCH 6/9] net: mvmdio: put the poll intervals in the private structure Antoine Tenart
2017-06-07 8:38 ` Antoine Tenart
2017-06-07 19:25 ` Florian Fainelli
2017-06-07 19:25 ` Florian Fainelli
2017-06-07 8:38 ` [PATCH 7/9] net: mvmdio: add xmdio support Antoine Tenart
2017-06-07 8:38 ` Antoine Tenart
2017-06-07 12:12 ` Andrew Lunn
2017-06-07 12:12 ` Andrew Lunn
2017-06-07 14:42 ` Antoine Tenart
2017-06-07 14:42 ` Antoine Tenart
2017-06-07 15:48 ` Florian Fainelli
2017-06-07 15:48 ` Florian Fainelli
2017-06-07 15:56 ` Russell King - ARM Linux
2017-06-07 15:56 ` Russell King - ARM Linux
2017-06-07 16:13 ` Antoine Tenart
2017-06-07 16:13 ` Antoine Tenart
2017-06-07 8:38 ` [PATCH 8/9] dt-bindings: orion-mdio: document the new xmdio compatible Antoine Tenart
2017-06-07 8:38 ` Antoine Tenart
2017-06-07 8:38 ` [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k Antoine Tenart
2017-06-07 8:38 ` Antoine Tenart
2017-06-07 8:43 ` Gregory CLEMENT
2017-06-07 8:43 ` Gregory CLEMENT
2017-06-07 19:09 ` David Miller
2017-06-07 19:09 ` David Miller
2017-06-08 8:45 ` Antoine Tenart
2017-06-08 8:45 ` Antoine Tenart
2017-06-08 8:51 ` Antoine Tenart
2017-06-08 8:51 ` Antoine Tenart
2017-06-08 8:55 ` Gregory CLEMENT [this message]
2017-06-08 8:55 ` Gregory CLEMENT
2017-06-08 9:03 ` Antoine Tenart
2017-06-08 9:03 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737barh96.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.