From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/8] net: mvmdio: add xmdio support
Date: Thu, 8 Jun 2017 18:03:31 +0200 [thread overview]
Message-ID: <20170608160331.GA20216@lunn.ch> (raw)
In-Reply-To: <20170608092653.25221-8-antoine.tenart@free-electrons.com>
On Thu, Jun 08, 2017 at 11:26:52AM +0200, Antoine Tenart wrote:
> +#define MVMDIO_XSMI_MGNT_REG 0x0
> +#define MVMDIO_XSMI_READ_VALID BIT(29)
> +#define MVMDIO_XSMI_BUSY BIT(30)
> +#define MVMDIO_XSMI_ADDR_REG 0x8
> +#define MVMDIO_XSMI_PHYADDR_SHIFT 16
> +#define MVMDIO_XSMI_DEVADDR_SHIFT 21
> +#define MVMDIO_XSMI_READ_OPERATION (0x7 << 26)
> +#define MVMDIO_XSMI_WRITE_OPERATION (0x5 << 27)
Hi Antoine
These two operations seem odd. Generally ops have the same shift.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: davem@davemloft.net, jason@lakedaemon.net,
gregory.clement@free-electrons.com,
sebastian.hesselbarth@gmail.com, f.fainelli@gmail.com,
thomas.petazzoni@free-electrons.com, mw@semihalf.com,
linux@armlinux.org.uk, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 7/8] net: mvmdio: add xmdio support
Date: Thu, 8 Jun 2017 18:03:31 +0200 [thread overview]
Message-ID: <20170608160331.GA20216@lunn.ch> (raw)
In-Reply-To: <20170608092653.25221-8-antoine.tenart@free-electrons.com>
On Thu, Jun 08, 2017 at 11:26:52AM +0200, Antoine Tenart wrote:
> +#define MVMDIO_XSMI_MGNT_REG 0x0
> +#define MVMDIO_XSMI_READ_VALID BIT(29)
> +#define MVMDIO_XSMI_BUSY BIT(30)
> +#define MVMDIO_XSMI_ADDR_REG 0x8
> +#define MVMDIO_XSMI_PHYADDR_SHIFT 16
> +#define MVMDIO_XSMI_DEVADDR_SHIFT 21
> +#define MVMDIO_XSMI_READ_OPERATION (0x7 << 26)
> +#define MVMDIO_XSMI_WRITE_OPERATION (0x5 << 27)
Hi Antoine
These two operations seem odd. Generally ops have the same shift.
Andrew
next prev parent reply other threads:[~2017-06-08 16:03 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 9:26 [PATCH v2 0/8] net: mvmdio: add xSMI support Antoine Tenart
2017-06-08 9:26 ` Antoine Tenart
2017-06-08 9:26 ` [PATCH v2 1/8] net: mvmdio: reorder headers alphabetically Antoine Tenart
2017-06-08 9:26 ` Antoine Tenart
2017-06-08 9:26 ` [PATCH v2 2/8] net: mvmdio: use tabs for defines Antoine Tenart
2017-06-08 9:26 ` Antoine Tenart
2017-06-08 9:26 ` [PATCH v2 3/8] net: mvmdio: use GENMASK for masks Antoine Tenart
2017-06-08 9:26 ` Antoine Tenart
2017-06-08 10:35 ` Sergei Shtylyov
2017-06-08 10:35 ` Sergei Shtylyov
2017-06-08 9:26 ` [PATCH v2 4/8] net: mvmdio: move the read valid check into its own function Antoine Tenart
2017-06-08 9:26 ` Antoine Tenart
2017-06-08 9:26 ` [PATCH v2 5/8] net: mvmdio: introduce an ops structure Antoine Tenart
2017-06-08 9:26 ` Antoine Tenart
2017-06-08 9:26 ` [PATCH v2 6/8] net: mvmdio: put the poll intervals in the " Antoine Tenart
2017-06-08 9:26 ` Antoine Tenart
2017-06-08 9:26 ` [PATCH v2 7/8] net: mvmdio: add xmdio support Antoine Tenart
2017-06-08 9:26 ` Antoine Tenart
2017-06-08 16:03 ` Andrew Lunn [this message]
2017-06-08 16:03 ` Andrew Lunn
2017-06-09 6:40 ` Antoine Tenart
2017-06-09 6:40 ` Antoine Tenart
2017-06-09 20:00 ` Russell King - ARM Linux
2017-06-09 20:00 ` Russell King - ARM Linux
2017-06-08 16:42 ` Florian Fainelli
2017-06-08 16:42 ` Florian Fainelli
2017-06-08 16:55 ` Andrew Lunn
2017-06-08 16:55 ` Andrew Lunn
2017-06-09 6:39 ` Antoine Tenart
2017-06-09 6:39 ` Antoine Tenart
2017-06-09 8:25 ` Antoine Tenart
2017-06-09 8:25 ` Antoine Tenart
2017-06-09 13:26 ` Andrew Lunn
2017-06-09 13:26 ` Andrew Lunn
2017-06-09 14:09 ` Antoine Tenart
2017-06-09 14:09 ` Antoine Tenart
2017-06-09 14:49 ` Andrew Lunn
2017-06-09 14:49 ` Andrew Lunn
2017-06-09 14:56 ` Antoine Tenart
2017-06-09 14:56 ` Antoine Tenart
2017-06-09 15:03 ` Andrew Lunn
2017-06-09 15:03 ` Andrew Lunn
2017-06-09 16:22 ` Antoine Tenart
2017-06-09 16:22 ` Antoine Tenart
2017-06-09 19:56 ` Russell King - ARM Linux
2017-06-09 19:56 ` Russell King - ARM Linux
2017-06-09 19:51 ` Russell King - ARM Linux
2017-06-09 19:51 ` Russell King - ARM Linux
2017-06-08 9:26 ` [PATCH v2 8/8] arm64: marvell: dts: add xmdio nodes for 7k/8k Antoine Tenart
2017-06-08 9:26 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170608160331.GA20216@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.