[lustre-devel] [PATCH] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one

[lustre-devel] [PATCH] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one

[Roman Storozhenko]

Replaces S_IRWXUGO with 0007. The reason is that symbolic permissions
considered harmful:
https://lwn.net/Articles/696229/

Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
---
 drivers/staging/lustre/lustre/llite/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c
index 13b3592..de5b4bf 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -1141,7 +1141,7 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 		}
 
 #if OBD_OCD_VERSION(2, 9, 50, 0) > LUSTRE_VERSION_CODE
-		mode = data->ioc_type != 0 ? data->ioc_type : S_IRWXUGO;
+		mode = data->ioc_type != 0 ? data->ioc_type : 0777;
 #else
 		mode = data->ioc_type;
 #endif
-- 
2.7.4

[lustre-devel] [PATCH] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one

[Cory Spitz]

Roman,
You have ?0007? in the description vs. ?0777? in the patch.
-Cory


On 6/8/17, 12:25 PM, "lustre-devel on behalf of Roman Storozhenko" <lustre-devel-bounces at lists.lustre.org on behalf of romeusmeister@gmail.com> wrote:

    Replaces S_IRWXUGO with 0007. The reason is that symbolic permissions


+		mode = data->ioc_type != 0 ? data->ioc_type : 0777;
 

[lustre-devel] [PATCH] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one

[Roman Storozhenko]

On Fri, Jun 09, 2017 at 08:13:49PM +0000, Cory Spitz wrote:
> Roman,
> You have ?0007? in the description vs. ?0777? in the patch.
> -Cory
> 
> 
> On 6/8/17, 12:25 PM, "lustre-devel on behalf of Roman Storozhenko" <lustre-devel-bounces at lists.lustre.org on behalf of romeusmeister@gmail.com> wrote:
> 
>     Replaces S_IRWXUGO with 0007. The reason is that symbolic permissions
> 
> 
> +		mode = data->ioc_type != 0 ? data->ioc_type : 0777;
>  
> 

Thanks that you pointed out that error. I have published the second
version of the patch here:
http://lists.lustre.org/pipermail/lustre-devel-lustre.org/2017-June/005727.html

[lustre-devel] [PATCH v2] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one

[Greg KH]

On Sat, Jun 10, 2017 at 02:48:34PM +0300, Roman Storozhenko wrote:
> Replaces S_IRWXUGO with 0777. The reason is that symbolic permissions
> considered harmful:
> https://lwn.net/Articles/696229/
> 
> The second version of that patch fixes the mistype in the first version.
> There were "0007" in the description instead of correct "0777" value.
> Thanks to Cory Spitz, who pointed out this error here:
> http://lists.lustre.org/pipermail/lustre-devel-lustre.org/2017-June/005726.html

This info doesn't need to be in the patch itself, it should go below the
--- line.

Please fix up and resend.

And also don't make your v3 of the patch with the same exact message-id
of the previous ones.  That's ripe for getting automatically deleted by
mail filters and email clients.

thanks,

greg k-h