From: "Emilio G. Cota" <cota@braap.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>,
peter.maydell@linaro.org, pbonzini@redhat.com,
edgar.iglesias@xilinx.com, qemu-devel@nongnu.org,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
"open list:ARM" <qemu-arm@nongnu.org>
Subject: [PATCH] target/aarch64: exit to main loop after handling MSR
Date: Tue, 13 Jun 2017 18:53:52 -0400 [thread overview]
Message-ID: <20170613225352.GA26288@flamenco> (raw)
In-Reply-To: <20170611050730.GA12317@flamenco>
The appended fixes it for me. Can you please test?
[ apply with `git am --scissors' ]
Thanks,
Emilio
---- 8< ----
Commit e75449a3 ("target/aarch64: optimize indirect branches") causes
a regression by which aarch64 guests freeze under TCG with -smp > 1,
even with `-accel accel=tcg,thread=single' (i.e. MTTCG disabled).
I isolated the problem to the MSR handler. This patch forces an exit
after the handler is executed, which fixes the regression.
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
target/arm/translate-a64.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 860e279..5a609a0 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -1422,7 +1422,7 @@ static void handle_msr_i(DisasContext *s, uint32_t insn,
gen_helper_msr_i_pstate(cpu_env, tcg_op, tcg_imm);
tcg_temp_free_i32(tcg_imm);
tcg_temp_free_i32(tcg_op);
- s->is_jmp = DISAS_UPDATE;
+ s->is_jmp = DISAS_EXIT;
break;
}
default:
@@ -11362,6 +11362,10 @@ void gen_intermediate_code_a64(ARMCPU *cpu, TranslationBlock *tb)
case DISAS_NEXT:
gen_goto_tb(dc, 1, dc->pc);
break;
+ case DISAS_EXIT:
+ gen_a64_set_pc_im(dc->pc);
+ tcg_gen_exit_tb(0);
+ break;
default:
case DISAS_UPDATE:
gen_a64_set_pc_im(dc->pc);
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: "Emilio G. Cota" <cota@braap.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>,
peter.maydell@linaro.org, pbonzini@redhat.com,
edgar.iglesias@xilinx.com, qemu-devel@nongnu.org,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
"open list:ARM" <qemu-arm@nongnu.org>
Subject: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR
Date: Tue, 13 Jun 2017 18:53:52 -0400 [thread overview]
Message-ID: <20170613225352.GA26288@flamenco> (raw)
In-Reply-To: <20170611050730.GA12317@flamenco>
The appended fixes it for me. Can you please test?
[ apply with `git am --scissors' ]
Thanks,
Emilio
---- 8< ----
Commit e75449a3 ("target/aarch64: optimize indirect branches") causes
a regression by which aarch64 guests freeze under TCG with -smp > 1,
even with `-accel accel=tcg,thread=single' (i.e. MTTCG disabled).
I isolated the problem to the MSR handler. This patch forces an exit
after the handler is executed, which fixes the regression.
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
target/arm/translate-a64.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 860e279..5a609a0 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -1422,7 +1422,7 @@ static void handle_msr_i(DisasContext *s, uint32_t insn,
gen_helper_msr_i_pstate(cpu_env, tcg_op, tcg_imm);
tcg_temp_free_i32(tcg_imm);
tcg_temp_free_i32(tcg_op);
- s->is_jmp = DISAS_UPDATE;
+ s->is_jmp = DISAS_EXIT;
break;
}
default:
@@ -11362,6 +11362,10 @@ void gen_intermediate_code_a64(ARMCPU *cpu, TranslationBlock *tb)
case DISAS_NEXT:
gen_goto_tb(dc, 1, dc->pc);
break;
+ case DISAS_EXIT:
+ gen_a64_set_pc_im(dc->pc);
+ tcg_gen_exit_tb(0);
+ break;
default:
case DISAS_UPDATE:
gen_a64_set_pc_im(dc->pc);
--
2.7.4
next prev parent reply other threads:[~2017-06-13 22:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 17:00 [Qemu-devel] [RFC DEBUG PATCH 0/3] debug patch for lookup-ptr hang Alex Bennée
2017-06-09 17:00 ` [Qemu-devel] [RFC DEBUG PATCH 1/3] vl: Fix broken thread=xxx option of the --accel parameter Alex Bennée
2017-06-09 17:00 ` [Qemu-devel] [RFC DEBUG PATCH 2/3] tcg-runtime: light re-factor of lookup_tb_ptr Alex Bennée
2017-06-09 17:01 ` [RFC DEBUG PATCH 3/3] translate-a64: fix lookup_tb_ptr hang (DEBUG!) Alex Bennée
2017-06-09 17:01 ` [Qemu-devel] " Alex Bennée
2017-06-10 2:29 ` Richard Henderson
2017-06-10 2:29 ` [Qemu-devel] " Richard Henderson
2017-06-10 8:51 ` Alex Bennée
2017-06-10 8:51 ` [Qemu-devel] " Alex Bennée
2017-06-10 16:59 ` Richard Henderson
2017-06-10 16:59 ` [Qemu-devel] " Richard Henderson
2017-06-11 5:07 ` Emilio G. Cota
2017-06-11 5:07 ` [Qemu-devel] " Emilio G. Cota
2017-06-12 10:31 ` Alex Bennée
2017-06-12 10:31 ` [Qemu-devel] " Alex Bennée
2017-06-13 22:53 ` Emilio G. Cota [this message]
2017-06-13 22:53 ` [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR Emilio G. Cota
2017-06-13 23:01 ` no-reply
2017-06-14 4:48 ` Richard Henderson
2017-06-14 4:48 ` [Qemu-devel] " Richard Henderson
2017-06-14 10:46 ` Paolo Bonzini
2017-06-14 10:46 ` [Qemu-devel] " Paolo Bonzini
2017-06-14 11:45 ` Alex Bennée
2017-06-14 11:45 ` [Qemu-devel] " Alex Bennée
2017-06-14 12:02 ` Paolo Bonzini
2017-06-14 12:02 ` [Qemu-devel] " Paolo Bonzini
2017-06-14 12:14 ` Alex Bennée
2017-06-14 12:14 ` [Qemu-devel] " Alex Bennée
2017-06-14 12:16 ` Paolo Bonzini
2017-06-14 12:16 ` [Qemu-devel] " Paolo Bonzini
2017-06-14 12:35 ` Alex Bennée
2017-06-14 12:35 ` [Qemu-devel] " Alex Bennée
2017-06-14 12:43 ` Paolo Bonzini
2017-06-14 12:43 ` [Qemu-devel] " Paolo Bonzini
2017-06-14 10:38 ` Alex Bennée
2017-06-14 10:38 ` [Qemu-devel] " Alex Bennée
2017-06-09 21:11 ` [Qemu-devel] [RFC DEBUG PATCH 0/3] debug patch for lookup-ptr hang no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613225352.GA26288@flamenco \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=crosthwaite.peter@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.