From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node
Date: Thu, 15 Jun 2017 15:51:01 +0800 [thread overview]
Message-ID: <20170615075059.GD5902@dragon> (raw)
In-Reply-To: <CAMty3ZCwkP=EaFcSdA--yQNN9ebjE9JptfwWjQpceXqDq-xkyA@mail.gmail.com>
On Thu, Jun 15, 2017 at 01:01:22PM +0530, Jagan Teki wrote:
> > I feel the abstraction is wrong from the beginning. Ideally, we should
> > have something like below.
> >
> > - imx6ul-isiot.dtsi
> > - imx6ul-isiot-kit.dts and imx6ul-isiot-carrier.dts
> >
> > The -isiot should have everything on SoM and common stuff between -kit
> > and -carrier boards, while -kit and -carrier include -isiot and contains
> > the base-board specific things. The -isiot can have both emmc and nand
> > devices with "disabled" status, and let firmware turn device on per SoM
> > it boots. In that case, the abstraction level can be less and clearer.
> >
> > Thoughts?
>
> So,even the common stuff (lcdif, ts and etc) should be in -isiot.dtsi
Yes, anything common can be in -isiot.dtsi.
> and make it "disabled" and let them enabled on respective dts. this
> what you mentioned here?
It doesn't matter. If the lcd/touch is same on -kit and -carrier, you
can even have them enabled by default in -isiot.dtsi. The -kit.dts and
-carrier.dts are there to accommodate base-board specific differences.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Cc: Jagan Teki <jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
Matteo Lisi <matteo.lisi-4s7YQHO/iPVBDgjK7y7TUQ@public.gmane.org>,
Michael Trimarchi
<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node
Date: Thu, 15 Jun 2017 15:51:01 +0800 [thread overview]
Message-ID: <20170615075059.GD5902@dragon> (raw)
In-Reply-To: <CAMty3ZCwkP=EaFcSdA--yQNN9ebjE9JptfwWjQpceXqDq-xkyA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Jun 15, 2017 at 01:01:22PM +0530, Jagan Teki wrote:
> > I feel the abstraction is wrong from the beginning. Ideally, we should
> > have something like below.
> >
> > - imx6ul-isiot.dtsi
> > - imx6ul-isiot-kit.dts and imx6ul-isiot-carrier.dts
> >
> > The -isiot should have everything on SoM and common stuff between -kit
> > and -carrier boards, while -kit and -carrier include -isiot and contains
> > the base-board specific things. The -isiot can have both emmc and nand
> > devices with "disabled" status, and let firmware turn device on per SoM
> > it boots. In that case, the abstraction level can be less and clearer.
> >
> > Thoughts?
>
> So,even the common stuff (lcdif, ts and etc) should be in -isiot.dtsi
Yes, anything common can be in -isiot.dtsi.
> and make it "disabled" and let them enabled on respective dts. this
> what you mentioned here?
It doesn't matter. If the lcd/touch is same on -kit and -carrier, you
can even have them enabled by default in -isiot.dtsi. The -kit.dts and
-carrier.dts are there to accommodate base-board specific differences.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Jagan Teki <jagan@openedev.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Matteo Lisi <matteo.lisi@engicam.com>,
Michael Trimarchi <michael@amarulasolutions.com>
Subject: Re: [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node
Date: Thu, 15 Jun 2017 15:51:01 +0800 [thread overview]
Message-ID: <20170615075059.GD5902@dragon> (raw)
In-Reply-To: <CAMty3ZCwkP=EaFcSdA--yQNN9ebjE9JptfwWjQpceXqDq-xkyA@mail.gmail.com>
On Thu, Jun 15, 2017 at 01:01:22PM +0530, Jagan Teki wrote:
> > I feel the abstraction is wrong from the beginning. Ideally, we should
> > have something like below.
> >
> > - imx6ul-isiot.dtsi
> > - imx6ul-isiot-kit.dts and imx6ul-isiot-carrier.dts
> >
> > The -isiot should have everything on SoM and common stuff between -kit
> > and -carrier boards, while -kit and -carrier include -isiot and contains
> > the base-board specific things. The -isiot can have both emmc and nand
> > devices with "disabled" status, and let firmware turn device on per SoM
> > it boots. In that case, the abstraction level can be less and clearer.
> >
> > Thoughts?
>
> So,even the common stuff (lcdif, ts and etc) should be in -isiot.dtsi
Yes, anything common can be in -isiot.dtsi.
> and make it "disabled" and let them enabled on respective dts. this
> what you mentioned here?
It doesn't matter. If the lcd/touch is same on -kit and -carrier, you
can even have them enabled by default in -isiot.dtsi. The -kit.dts and
-carrier.dts are there to accommodate base-board specific differences.
Shawn
next prev parent reply other threads:[~2017-06-15 7:51 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 18:02 [PATCH v3 0/9] ARM: dts: i.MX6: Add lcdif/sound nodes on Engicam SOMs Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` [PATCH v3 1/9] ARM: dts: imx6ul-isiot: Add Sound card with codec node Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-07 13:16 ` Shawn Guo
2017-04-07 13:16 ` Shawn Guo
2017-04-07 13:16 ` Shawn Guo
2017-06-14 14:47 ` Jagan Teki
2017-06-14 14:47 ` Jagan Teki
2017-06-14 14:47 ` Jagan Teki
2017-06-15 2:20 ` Shawn Guo
2017-06-15 2:20 ` Shawn Guo
2017-06-15 2:20 ` Shawn Guo
2017-06-15 4:51 ` Jagan Teki
2017-06-15 4:51 ` Jagan Teki
2017-06-15 7:15 ` Shawn Guo
2017-06-15 7:15 ` Shawn Guo
2017-06-15 7:31 ` Jagan Teki
2017-06-15 7:31 ` Jagan Teki
2017-06-15 7:51 ` Shawn Guo [this message]
2017-06-15 7:51 ` Shawn Guo
2017-06-15 7:51 ` Shawn Guo
2017-06-15 13:15 ` Jagan Teki
2017-06-15 13:15 ` Jagan Teki
2017-06-15 13:15 ` Jagan Teki
2017-04-06 18:02 ` [PATCH v3 2/9] ARM: dts: imx6ul-geam: " Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-07 13:19 ` Shawn Guo
2017-04-07 13:19 ` Shawn Guo
2017-04-07 13:19 ` Shawn Guo
2017-04-06 18:02 ` [PATCH v3 3/9] ARM: dts: imx6qdl-icore: " Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-07 13:23 ` Shawn Guo
2017-04-07 13:23 ` Shawn Guo
2017-04-07 13:23 ` Shawn Guo
2017-04-06 18:02 ` [PATCH v3 4/9] ARM: dts: imx6dl-icore-rqs: Add sgtl5000 " Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` [PATCH v3 5/9] ARM: dts: imx6qdl-icore-rqs: Replace to use simple-audio-card Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` [PATCH v3 6/9] ARM: dts: imx6dl-icore: Add LVDS support Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` [PATCH v3 7/9] ARM: dts: imx6dl-icore: Add touchscreen node Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` [PATCH v3 8/9] ARM: dts: imx6qdl-icore-rqs: Add CAN nodes Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` [PATCH v3 9/9] ARM: dts: imx6ul-isiot: Add FEC node support Jagan Teki
2017-04-06 18:02 ` Jagan Teki
2017-04-06 18:02 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615075059.GD5902@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.