From: Stephen Boyd <sboyd@codeaurora.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Guodong Xu <guodong.xu@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>
Subject: Re: [PATCH v3 1/2] clk: Hi3660: register fixed_rate_clks with CLK_OF_DECLARE_DRIVER
Date: Mon, 19 Jun 2017 16:36:55 -0700 [thread overview]
Message-ID: <20170619233655.GR20170@codeaurora.org> (raw)
In-Reply-To: <1495428748-11153-2-git-send-email-leo.yan@linaro.org>
On 05/22, Leo Yan wrote:
> The timer will register into system at very early phase at kernel boot;
> if timer needs to use clock, the clock should be get ready in function
> of_clk_init() so later the timer driver probe can retrieve clock
> successfully. This is finished in below flow on arm64:
>
> start_kernel()
> `-> time_init()
> `-> of_clk_init(NULL) => register timer's clock
> `-> clocksource_probe() => register timer
>
> On Hi3660 the sp804 timer uses clock "osc32k", this clock is registered
> as platform driver rather than CLK_OF_DECLARE_DRIVER method. As result,
> sp804 timer probe returns failure due if cannot bind clock properly.
>
> To fix the failure, this patch is to split crgctrl clocks into two
> subsets. One part is for fixed_rate_clks which includes pre-defined
> fixed rate clocks, and "osc32k" clock is in this category; So we change
> their registration to CLK_OF_DECLARE_DRIVER method, as result the clocks
> can be registered ahead with function of_clk_init() and timer driver can
> bind timer clock successfully; the rest of the crgctrl clocks are still
> registered by the probe of the platform driver.
>
> This patch also adds checking for all crgctrl clocks registration and
> print out log if any clock has failure.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] clk: Hi3660: register fixed_rate_clks with CLK_OF_DECLARE_DRIVER
Date: Mon, 19 Jun 2017 16:36:55 -0700 [thread overview]
Message-ID: <20170619233655.GR20170@codeaurora.org> (raw)
In-Reply-To: <1495428748-11153-2-git-send-email-leo.yan@linaro.org>
On 05/22, Leo Yan wrote:
> The timer will register into system at very early phase at kernel boot;
> if timer needs to use clock, the clock should be get ready in function
> of_clk_init() so later the timer driver probe can retrieve clock
> successfully. This is finished in below flow on arm64:
>
> start_kernel()
> `-> time_init()
> `-> of_clk_init(NULL) => register timer's clock
> `-> clocksource_probe() => register timer
>
> On Hi3660 the sp804 timer uses clock "osc32k", this clock is registered
> as platform driver rather than CLK_OF_DECLARE_DRIVER method. As result,
> sp804 timer probe returns failure due if cannot bind clock properly.
>
> To fix the failure, this patch is to split crgctrl clocks into two
> subsets. One part is for fixed_rate_clks which includes pre-defined
> fixed rate clocks, and "osc32k" clock is in this category; So we change
> their registration to CLK_OF_DECLARE_DRIVER method, as result the clocks
> can be registered ahead with function of_clk_init() and timer driver can
> bind timer clock successfully; the rest of the crgctrl clocks are still
> registered by the probe of the platform driver.
>
> This patch also adds checking for all crgctrl clocks registration and
> print out log if any clock has failure.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Guodong Xu <guodong.xu@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Wei Xu <xuwei5@hisilicon.com>,
Rob Herring <robh+dt@kernel.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] clk: Hi3660: register fixed_rate_clks with CLK_OF_DECLARE_DRIVER
Date: Mon, 19 Jun 2017 16:36:55 -0700 [thread overview]
Message-ID: <20170619233655.GR20170@codeaurora.org> (raw)
In-Reply-To: <1495428748-11153-2-git-send-email-leo.yan@linaro.org>
On 05/22, Leo Yan wrote:
> The timer will register into system at very early phase at kernel boot;
> if timer needs to use clock, the clock should be get ready in function
> of_clk_init() so later the timer driver probe can retrieve clock
> successfully. This is finished in below flow on arm64:
>
> start_kernel()
> `-> time_init()
> `-> of_clk_init(NULL) => register timer's clock
> `-> clocksource_probe() => register timer
>
> On Hi3660 the sp804 timer uses clock "osc32k", this clock is registered
> as platform driver rather than CLK_OF_DECLARE_DRIVER method. As result,
> sp804 timer probe returns failure due if cannot bind clock properly.
>
> To fix the failure, this patch is to split crgctrl clocks into two
> subsets. One part is for fixed_rate_clks which includes pre-defined
> fixed rate clocks, and "osc32k" clock is in this category; So we change
> their registration to CLK_OF_DECLARE_DRIVER method, as result the clocks
> can be registered ahead with function of_clk_init() and timer driver can
> bind timer clock successfully; the rest of the crgctrl clocks are still
> registered by the probe of the platform driver.
>
> This patch also adds checking for all crgctrl clocks registration and
> print out log if any clock has failure.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-06-19 23:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 4:52 [PATCH v3 0/2] Hi3660: enable sp804 timer Leo Yan
2017-05-22 4:52 ` Leo Yan
2017-05-22 4:52 ` [PATCH v3 1/2] clk: Hi3660: register fixed_rate_clks with CLK_OF_DECLARE_DRIVER Leo Yan
2017-05-22 4:52 ` Leo Yan
2017-06-19 23:36 ` Stephen Boyd [this message]
2017-06-19 23:36 ` Stephen Boyd
2017-06-19 23:36 ` Stephen Boyd
2017-06-20 0:09 ` Leo Yan
2017-06-20 0:09 ` Leo Yan
2017-06-20 0:09 ` Leo Yan
2017-05-22 4:52 ` [PATCH v3 2/2] arm64: dts: add sp804 timer node for Hi3660 Leo Yan
2017-05-22 4:52 ` Leo Yan
2017-06-15 20:00 ` Wei Xu
2017-06-15 20:00 ` Wei Xu
2017-06-15 20:00 ` Wei Xu
2017-06-15 23:59 ` Leo Yan
2017-06-15 23:59 ` Leo Yan
2017-06-15 23:59 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619233655.GR20170@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=guodong.xu@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.