From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][tpm-next] tpm_tis: make ilb_base_addr static
Date: Tue, 20 Jun 2017 15:06:52 +0000 [thread overview]
Message-ID: <20170620150652.s5hrk4mffm2vmuek@linux.intel.com> (raw)
In-Reply-To: <20170620102202.7132-1-colin.king@canonical.com>
On Tue, Jun 20, 2017 at 11:22:02AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer ilb_base_addr does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'ilb_base_addr' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks Colin.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 506e62ca3576..c915d65c1909 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev)
> #define LPC_CNTRL_REG_OFFSET 0x84
> #define LPC_CLKRUN_EN (1 << 2)
>
> -void __iomem *ilb_base_addr;
> +static void __iomem *ilb_base_addr;
>
> static inline bool is_bsw(void)
> {
> --
> 2.11.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Colin King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH][tpm-next] tpm_tis: make ilb_base_addr static
Date: Tue, 20 Jun 2017 17:06:52 +0200 [thread overview]
Message-ID: <20170620150652.s5hrk4mffm2vmuek@linux.intel.com> (raw)
In-Reply-To: <20170620102202.7132-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
On Tue, Jun 20, 2017 at 11:22:02AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
>
> The pointer ilb_base_addr does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'ilb_base_addr' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Thanks Colin.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
/Jarkko
> ---
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 506e62ca3576..c915d65c1909 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev)
> #define LPC_CNTRL_REG_OFFSET 0x84
> #define LPC_CLKRUN_EN (1 << 2)
>
> -void __iomem *ilb_base_addr;
> +static void __iomem *ilb_base_addr;
>
> static inline bool is_bsw(void)
> {
> --
> 2.11.0
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][tpm-next] tpm_tis: make ilb_base_addr static
Date: Tue, 20 Jun 2017 17:06:52 +0200 [thread overview]
Message-ID: <20170620150652.s5hrk4mffm2vmuek@linux.intel.com> (raw)
In-Reply-To: <20170620102202.7132-1-colin.king@canonical.com>
On Tue, Jun 20, 2017 at 11:22:02AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer ilb_base_addr does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'ilb_base_addr' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks Colin.
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
> ---
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 506e62ca3576..c915d65c1909 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev)
> #define LPC_CNTRL_REG_OFFSET 0x84
> #define LPC_CLKRUN_EN (1 << 2)
>
> -void __iomem *ilb_base_addr;
> +static void __iomem *ilb_base_addr;
>
> static inline bool is_bsw(void)
> {
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-06-20 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 10:22 [PATCH][tpm-next] tpm_tis: make ilb_base_addr static Colin King
2017-06-20 10:22 ` Colin King
2017-06-20 15:06 ` Jarkko Sakkinen [this message]
2017-06-20 15:06 ` Jarkko Sakkinen
2017-06-20 15:06 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620150652.s5hrk4mffm2vmuek@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.