All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Eric Anholt <eric@anholt.net>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/vc4: Remove dead vc4_event_pending().
Date: Wed, 21 Jun 2017 21:54:56 +0200	[thread overview]
Message-ID: <20170621215456.2cab5525@bbrezillon> (raw)
In-Reply-To: <20170621185002.28563-4-eric@anholt.net>

Le Wed, 21 Jun 2017 11:50:02 -0700,
Eric Anholt <eric@anholt.net> a écrit :

> It is no longer used as of commit 34c8ea400ff6 ("drm/vc4: Mimic
> drm_atomic_helper_commit() behavior")
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  drivers/gpu/drm/vc4/vc4_crtc.c | 8 --------
>  drivers/gpu/drm/vc4/vc4_drv.h  | 1 -
>  2 files changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
> index 30a1df11e063..f20c01759c0d 100644
> --- a/drivers/gpu/drm/vc4/vc4_crtc.c
> +++ b/drivers/gpu/drm/vc4/vc4_crtc.c
> @@ -674,14 +674,6 @@ static void vc4_disable_vblank(struct drm_crtc *crtc)
>  	CRTC_WRITE(PV_INTEN, 0);
>  }
>  
> -/* Must be called with the event lock held */
> -bool vc4_event_pending(struct drm_crtc *crtc)
> -{
> -	struct vc4_crtc *vc4_crtc = to_vc4_crtc(crtc);
> -
> -	return !!vc4_crtc->event;
> -}
> -
>  static void vc4_crtc_handle_page_flip(struct vc4_crtc *vc4_crtc)
>  {
>  	struct drm_crtc *crtc = &vc4_crtc->base;
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
> index df22698d62ee..1047953216a8 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.h
> +++ b/drivers/gpu/drm/vc4/vc4_drv.h
> @@ -491,7 +491,6 @@ int vc4_bo_stats_debugfs(struct seq_file *m, void *arg);
>  
>  /* vc4_crtc.c */
>  extern struct platform_driver vc4_crtc_driver;
> -bool vc4_event_pending(struct drm_crtc *crtc);
>  int vc4_crtc_debugfs_regs(struct seq_file *m, void *arg);
>  bool vc4_crtc_get_scanoutpos(struct drm_device *dev, unsigned int crtc_id,
>  			     bool in_vblank_irq, int *vpos, int *hpos,

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drm/vc4: Remove dead vc4_event_pending().
Date: Wed, 21 Jun 2017 21:54:56 +0200	[thread overview]
Message-ID: <20170621215456.2cab5525@bbrezillon> (raw)
In-Reply-To: <20170621185002.28563-4-eric@anholt.net>

Le Wed, 21 Jun 2017 11:50:02 -0700,
Eric Anholt <eric@anholt.net> a écrit :

> It is no longer used as of commit 34c8ea400ff6 ("drm/vc4: Mimic
> drm_atomic_helper_commit() behavior")
> 
> Signed-off-by: Eric Anholt <eric@anholt.net>

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  drivers/gpu/drm/vc4/vc4_crtc.c | 8 --------
>  drivers/gpu/drm/vc4/vc4_drv.h  | 1 -
>  2 files changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
> index 30a1df11e063..f20c01759c0d 100644
> --- a/drivers/gpu/drm/vc4/vc4_crtc.c
> +++ b/drivers/gpu/drm/vc4/vc4_crtc.c
> @@ -674,14 +674,6 @@ static void vc4_disable_vblank(struct drm_crtc *crtc)
>  	CRTC_WRITE(PV_INTEN, 0);
>  }
>  
> -/* Must be called with the event lock held */
> -bool vc4_event_pending(struct drm_crtc *crtc)
> -{
> -	struct vc4_crtc *vc4_crtc = to_vc4_crtc(crtc);
> -
> -	return !!vc4_crtc->event;
> -}
> -
>  static void vc4_crtc_handle_page_flip(struct vc4_crtc *vc4_crtc)
>  {
>  	struct drm_crtc *crtc = &vc4_crtc->base;
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
> index df22698d62ee..1047953216a8 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.h
> +++ b/drivers/gpu/drm/vc4/vc4_drv.h
> @@ -491,7 +491,6 @@ int vc4_bo_stats_debugfs(struct seq_file *m, void *arg);
>  
>  /* vc4_crtc.c */
>  extern struct platform_driver vc4_crtc_driver;
> -bool vc4_event_pending(struct drm_crtc *crtc);
>  int vc4_crtc_debugfs_regs(struct seq_file *m, void *arg);
>  bool vc4_crtc_get_scanoutpos(struct drm_device *dev, unsigned int crtc_id,
>  			     bool in_vblank_irq, int *vpos, int *hpos,

  reply	other threads:[~2017-06-21 19:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 18:49 [PATCH 1/4] drm/vc4: Hook up plane prepare_fb to lookup dma-buf reservations Eric Anholt
2017-06-21 18:50 ` [PATCH 2/4] drm/vc4: Wait for fences interruptibly in blocking mode Eric Anholt
2017-06-21 18:50   ` Eric Anholt
2017-06-22  7:22   ` Boris Brezillon
2017-06-22  7:22     ` Boris Brezillon
2017-06-21 18:50 ` [PATCH 3/4] drm/vc4: Use the atomic state's commit workqueue Eric Anholt
2017-06-21 18:50   ` Eric Anholt
2017-06-22  7:16   ` Daniel Vetter
2017-06-22  7:16     ` Daniel Vetter
2017-06-22 18:27     ` Eric Anholt
2017-06-22  8:06   ` Boris Brezillon
2017-06-22  8:06     ` Boris Brezillon
2017-06-21 18:50 ` [PATCH 4/4] drm/vc4: Remove dead vc4_event_pending() Eric Anholt
2017-06-21 18:50   ` Eric Anholt
2017-06-21 19:54   ` Boris Brezillon [this message]
2017-06-21 19:54     ` Boris Brezillon
2017-06-22  8:03 ` [PATCH 1/4] drm/vc4: Hook up plane prepare_fb to lookup dma-buf reservations Boris Brezillon
2017-06-22  8:03   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170621215456.2cab5525@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.