All of lore.kernel.org
 help / color / mirror / Atom feed
* [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange
@ 2017-06-26 17:43 Sam Nelson
  2017-06-26 17:43 ` [morty/master][PATCH v3 2/2] arago-tisdk-addons: Add big-data-ipc-demo for host linux Sam Nelson
  2017-06-26 18:46 ` [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange Denys Dmytriyenko
  0 siblings, 2 replies; 7+ messages in thread
From: Sam Nelson @ 2017-06-26 17:43 UTC (permalink / raw)
  To: meta-arago

Adds example with host running linux
Demonstrates transfer of Big data buffers between A15 host and DSP core

Signed-off-by: Sam Nelson <sam.nelson@ti.com>

---
Change from previous version of patch
- Expand to am57xx-evm to omap-a15
- Remove ti-staging.inc
---
---
 .../big-data-ipc-demo-linux_git.bb                 | 41 ++++++++++++++++++++++
 .../big-data-ipc-demo/big-data-ipc-demo.inc        | 39 ++++++++++++++++++++
 2 files changed, 80 insertions(+)
 create mode 100644 meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb
 create mode 100644 meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc

diff --git a/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb
new file mode 100644
index 0000000..0734177
--- /dev/null
+++ b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb
@@ -0,0 +1,41 @@
+SUMMARY = "TI Big data IPC: Host linux examples"
+
+require recipes-ti/includes/ti-paths.inc
+require big-data-ipc-demo.inc
+
+DEPENDS = "ti-ipc \
+           ti-xdctools \
+           ti-sysbios \
+           ti-ipc-rtos \
+           cmem \
+"
+
+EXTRA_OEMAKE = "\
+    PLATFORM=${PLATFORM} \
+    XDC_INSTALL_DIR="${XDC_INSTALL_DIR}" \
+    BIOS_INSTALL_DIR="${SYSBIOS_INSTALL_DIR}" \
+    IPC_INSTALL_DIR="${IPC_INSTALL_DIR}" \
+    LINUX_SYSROOT_DIR="${STAGING_INCDIR}" \
+    ${IPC_TARGETS} \
+    JOBS="${PARALLEL_MAKE}" \
+"
+
+do_create_srcipk_prepend() {
+  rm -rf host_bios
+}
+
+do_compile() {
+  if [  "${PLATFORM}" != "UNKNOWN" ]; then
+      oe_runmake host_linux
+  fi
+}
+
+do_install() {
+  if [  "${PLATFORM}" != "UNKNOWN" ]; then
+    oe_runmake EXEC_DIR="${D}${bindir}" install_linux_bin
+  fi
+}
+
+PACKAGES =+ "${PN}-firmware"
+FILES_${PN}-firmware += "${bindir}/simple_buffer_example/release/server_dsp.xe66"
+INSANE_SKIP_${PN}-firmware += "arch"
diff --git a/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc
new file mode 100644
index 0000000..c3f8f38
--- /dev/null
+++ b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc
@@ -0,0 +1,39 @@
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://makefile;beginline=1;endline=31;md5=2f2ea348b98d5cc7807ece7adcc2c43a"
+
+COMPATIBLE_MACHINE = "omap-a15|keystone"
+PACKAGE_ARCH = "${MACHINE_ARCH}"
+
+BIG_DATA_IPC_GIT_URI = "git://git.ti.com/processor-sdk/big-data-ipc-examples.git"
+BIG_DATA_IPC_GIT_PROTOCOL = "git"
+BIG_DATA_IPC_GIT_BRANCH = "master"
+
+# Below commit ID corresponds to "DEV.BIG_DATA_IPC.01.01.00.00"
+BIG_DATA_IPC_SRCREV = "5907bff5a29fe2ba8719ae8c3c5d62b20b7b6bc9"
+
+BRANCH = "${BIG_DATA_IPC_GIT_BRANCH}"
+SRC_URI = "${BIG_DATA_IPC_GIT_URI};protocol=${BIG_DATA_IPC_GIT_PROTOCOL};branch=${BRANCH}"
+
+SRCREV = "${BIG_DATA_IPC_SRCREV}"
+PV = "01.01.00.00"
+
+S = "${WORKDIR}/git"
+
+PLATFORM = "UNKNOWN"
+PLATFORM_omap-a15 = "DRA7XX"
+PLATFORM_k2hk-evm = "TCI6636"
+PLATFORM_k2l-evm = "TCI6630"
+PLATFORM_k2e = "66AK2E"
+PLATFORM_k2g = "66AK2G"
+
+IPC_TARGETS = ""
+IPC_TARGETS_omap-a15 = "\
+    gnu.targets.arm.A15F="${GCC_ARM_NONE_TOOLCHAIN}" \
+    ti.targets.elf.C66="${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x" \
+    ti.targets.arm.elf.M4="${M4_TOOLCHAIN_INSTALL_DIR}" \
+"
+
+IPC_TARGETS_keystone = " \
+    gnu.targets.arm.A15F="${GCC_ARM_NONE_TOOLCHAIN}" \
+    ti.targets.elf.C66="${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x" \
+"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [morty/master][PATCH v3 2/2] arago-tisdk-addons: Add big-data-ipc-demo for host linux
  2017-06-26 17:43 [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange Sam Nelson
@ 2017-06-26 17:43 ` Sam Nelson
  2017-06-26 18:47   ` Denys Dmytriyenko
  2017-06-26 18:46 ` [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange Denys Dmytriyenko
  1 sibling, 1 reply; 7+ messages in thread
From: Sam Nelson @ 2017-06-26 17:43 UTC (permalink / raw)
  To: meta-arago

Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
 .../recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
index c623b37..360890b 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
@@ -1,6 +1,6 @@
 DESCRIPTION = "Task to install additional utilities/demos for SDKs"
 LICENSE = "MIT"
-PR = "r60"
+PR = "r61"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
@@ -119,7 +119,10 @@ EXTRA_PACKAGES_omapl138 = " \
 
 EXTRA_PACKAGES_append_ti33x = " voxelsdk"
 EXTRA_PACKAGES_append_ti43x = " voxelsdk"
-EXTRA_PACKAGES_append_omap-a15 = " voxelsdk"
+EXTRA_PACKAGES_append_omap-a15 = " voxelsdk \
+                                   big-data-ipc-demo-linux \
+                                   big-data-ipc-demo-linux-firmware \
+"
 
 EXTRA_PACKAGES_append_omap-a15 = " ti-ipc-examples-linux"
 EXTRA_PACKAGES_append_keystone = " ti-ipc-examples-linux"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange
  2017-06-26 17:43 [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange Sam Nelson
  2017-06-26 17:43 ` [morty/master][PATCH v3 2/2] arago-tisdk-addons: Add big-data-ipc-demo for host linux Sam Nelson
@ 2017-06-26 18:46 ` Denys Dmytriyenko
  2017-06-26 18:59   ` Nelson, Sam
  1 sibling, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2017-06-26 18:46 UTC (permalink / raw)
  To: Sam Nelson; +Cc: meta-arago

Thanks, Sam, looks reasonable.

Few non-critical comments - let me know if you want to fix them and re-submit, 
or I can merge as is and if needed, address them later as a follow up.


On Mon, Jun 26, 2017 at 01:43:16PM -0400, Sam Nelson wrote:
> Adds example with host running linux
> Demonstrates transfer of Big data buffers between A15 host and DSP core
> 
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> 
> ---
> Change from previous version of patch
> - Expand to am57xx-evm to omap-a15
> - Remove ti-staging.inc
> ---
> ---
>  .../big-data-ipc-demo-linux_git.bb                 | 41 ++++++++++++++++++++++
>  .../big-data-ipc-demo/big-data-ipc-demo.inc        | 39 ++++++++++++++++++++
>  2 files changed, 80 insertions(+)
>  create mode 100644 meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb
>  create mode 100644 meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc
> 
> diff --git a/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb
> new file mode 100644
> index 0000000..0734177
> --- /dev/null
> +++ b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo-linux_git.bb
> @@ -0,0 +1,41 @@
> +SUMMARY = "TI Big data IPC: Host linux examples"
> +
> +require recipes-ti/includes/ti-paths.inc
> +require big-data-ipc-demo.inc
> +
> +DEPENDS = "ti-ipc \
> +           ti-xdctools \
> +           ti-sysbios \
> +           ti-ipc-rtos \
> +           cmem \
> +"
> +
> +EXTRA_OEMAKE = "\
> +    PLATFORM=${PLATFORM} \
> +    XDC_INSTALL_DIR="${XDC_INSTALL_DIR}" \
> +    BIOS_INSTALL_DIR="${SYSBIOS_INSTALL_DIR}" \
> +    IPC_INSTALL_DIR="${IPC_INSTALL_DIR}" \
> +    LINUX_SYSROOT_DIR="${STAGING_INCDIR}" \
> +    ${IPC_TARGETS} \
> +    JOBS="${PARALLEL_MAKE}" \
> +"
> +
> +do_create_srcipk_prepend() {
> +  rm -rf host_bios
> +}
> +
> +do_compile() {
> +  if [  "${PLATFORM}" != "UNKNOWN" ]; then
> +      oe_runmake host_linux
> +  fi
> +}

I don't think checking PLATFORM above and below is necessary - you set strict 
COMPATIBLE_MACHINE filter and set all possible variants of PLATFORM var below. 
Even if something is not defined, let if fail with UNKNOWN setting, instead of 
succeeding and not building anything...


> +do_install() {
> +  if [  "${PLATFORM}" != "UNKNOWN" ]; then
> +    oe_runmake EXEC_DIR="${D}${bindir}" install_linux_bin
> +  fi
> +}
> +
> +PACKAGES =+ "${PN}-firmware"
> +FILES_${PN}-firmware += "${bindir}/simple_buffer_example/release/server_dsp.xe66"
> +INSANE_SKIP_${PN}-firmware += "arch"
> diff --git a/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc
> new file mode 100644
> index 0000000..c3f8f38
> --- /dev/null
> +++ b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-demo.inc
> @@ -0,0 +1,39 @@
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://makefile;beginline=1;endline=31;md5=2f2ea348b98d5cc7807ece7adcc2c43a"
> +
> +COMPATIBLE_MACHINE = "omap-a15|keystone"
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +BIG_DATA_IPC_GIT_URI = "git://git.ti.com/processor-sdk/big-data-ipc-examples.git"
> +BIG_DATA_IPC_GIT_PROTOCOL = "git"
> +BIG_DATA_IPC_GIT_BRANCH = "master"
> +
> +# Below commit ID corresponds to "DEV.BIG_DATA_IPC.01.01.00.00"
> +BIG_DATA_IPC_SRCREV = "5907bff5a29fe2ba8719ae8c3c5d62b20b7b6bc9"
> +
> +BRANCH = "${BIG_DATA_IPC_GIT_BRANCH}"
> +SRC_URI = "${BIG_DATA_IPC_GIT_URI};protocol=${BIG_DATA_IPC_GIT_PROTOCOL};branch=${BRANCH}"
> +
> +SRCREV = "${BIG_DATA_IPC_SRCREV}"
> +PV = "01.01.00.00"

Kind of strange split - usually common pieces are in .inc and version-specific 
are in .bb file. Here you set SRCREV and PV in .inc file... Any reason?


> +S = "${WORKDIR}/git"
> +
> +PLATFORM = "UNKNOWN"
> +PLATFORM_omap-a15 = "DRA7XX"
> +PLATFORM_k2hk-evm = "TCI6636"
> +PLATFORM_k2l-evm = "TCI6630"
> +PLATFORM_k2e = "66AK2E"
> +PLATFORM_k2g = "66AK2G"
> +
> +IPC_TARGETS = ""
> +IPC_TARGETS_omap-a15 = "\
> +    gnu.targets.arm.A15F="${GCC_ARM_NONE_TOOLCHAIN}" \
> +    ti.targets.elf.C66="${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x" \
> +    ti.targets.arm.elf.M4="${M4_TOOLCHAIN_INSTALL_DIR}" \
> +"
> +
> +IPC_TARGETS_keystone = " \
> +    gnu.targets.arm.A15F="${GCC_ARM_NONE_TOOLCHAIN}" \
> +    ti.targets.elf.C66="${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x" \
> +"
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [morty/master][PATCH v3 2/2] arago-tisdk-addons: Add big-data-ipc-demo for host linux
  2017-06-26 17:43 ` [morty/master][PATCH v3 2/2] arago-tisdk-addons: Add big-data-ipc-demo for host linux Sam Nelson
@ 2017-06-26 18:47   ` Denys Dmytriyenko
  2017-06-26 19:00     ` Nelson, Sam
  0 siblings, 1 reply; 7+ messages in thread
From: Denys Dmytriyenko @ 2017-06-26 18:47 UTC (permalink / raw)
  To: Sam Nelson; +Cc: meta-arago

On Mon, Jun 26, 2017 at 01:43:17PM -0400, Sam Nelson wrote:
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>  .../recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb  | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
> index c623b37..360890b 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb
> @@ -1,6 +1,6 @@
>  DESCRIPTION = "Task to install additional utilities/demos for SDKs"
>  LICENSE = "MIT"
> -PR = "r60"
> +PR = "r61"
>  
>  PACKAGE_ARCH = "${MACHINE_ARCH}"
>  
> @@ -119,7 +119,10 @@ EXTRA_PACKAGES_omapl138 = " \
>  
>  EXTRA_PACKAGES_append_ti33x = " voxelsdk"
>  EXTRA_PACKAGES_append_ti43x = " voxelsdk"
> -EXTRA_PACKAGES_append_omap-a15 = " voxelsdk"
> +EXTRA_PACKAGES_append_omap-a15 = " voxelsdk \
> +                                   big-data-ipc-demo-linux \
> +                                   big-data-ipc-demo-linux-firmware \
> +"

I only see you are adding it for omap-a15, but not keystone - on purpose?


>  EXTRA_PACKAGES_append_omap-a15 = " ti-ipc-examples-linux"
>  EXTRA_PACKAGES_append_keystone = " ti-ipc-examples-linux"
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange
  2017-06-26 18:46 ` [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange Denys Dmytriyenko
@ 2017-06-26 18:59   ` Nelson, Sam
  2017-06-26 19:05     ` Denys Dmytriyenko
  0 siblings, 1 reply; 7+ messages in thread
From: Nelson, Sam @ 2017-06-26 18:59 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org



> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Monday, June 26, 2017 2:47 PM
> To: Nelson, Sam
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [morty/master][PATCH v3 1/2] big-data-ipc-demo:
> Add ipc examples for big data buffer exchange
> 
> Thanks, Sam, looks reasonable.
> 
> Few non-critical comments - let me know if you want to fix them and re-
> submit, or I can merge as is and if needed, address them later as a follow up.
> 
> 
> On Mon, Jun 26, 2017 at 01:43:16PM -0400, Sam Nelson wrote:
> > Adds example with host running linux
> > Demonstrates transfer of Big data buffers between A15 host and DSP core
> >
> > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> >
> > ---
> > Change from previous version of patch
> > - Expand to am57xx-evm to omap-a15
> > - Remove ti-staging.inc
> > ---
> > ---
> >  .../big-data-ipc-demo-linux_git.bb                 | 41
> ++++++++++++++++++++++
> >  .../big-data-ipc-demo/big-data-ipc-demo.inc        | 39
> ++++++++++++++++++++
> >  2 files changed, 80 insertions(+)
> >  create mode 100644 meta-arago-extras/recipes-apps/big-data-ipc-
> demo/big-data-ipc-demo-linux_git.bb
> >  create mode 100644 meta-arago-extras/recipes-apps/big-data-ipc-
> demo/big-data-ipc-demo.inc
> >
> > diff --git a/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-
> demo-linux_git.bb b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-
> data-ipc-demo-linux_git.bb
> > new file mode 100644
> > index 0000000..0734177
> > --- /dev/null
> > +++ b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-
> demo-linux_git.bb
> > @@ -0,0 +1,41 @@
> > +SUMMARY = "TI Big data IPC: Host linux examples"
> > +
> > +require recipes-ti/includes/ti-paths.inc
> > +require big-data-ipc-demo.inc
> > +
> > +DEPENDS = "ti-ipc \
> > +           ti-xdctools \
> > +           ti-sysbios \
> > +           ti-ipc-rtos \
> > +           cmem \
> > +"
> > +
> > +EXTRA_OEMAKE = "\
> > +    PLATFORM=${PLATFORM} \
> > +    XDC_INSTALL_DIR="${XDC_INSTALL_DIR}" \
> > +    BIOS_INSTALL_DIR="${SYSBIOS_INSTALL_DIR}" \
> > +    IPC_INSTALL_DIR="${IPC_INSTALL_DIR}" \
> > +    LINUX_SYSROOT_DIR="${STAGING_INCDIR}" \
> > +    ${IPC_TARGETS} \
> > +    JOBS="${PARALLEL_MAKE}" \
> > +"
> > +
> > +do_create_srcipk_prepend() {
> > +  rm -rf host_bios
> > +}
> > +
> > +do_compile() {
> > +  if [  "${PLATFORM}" != "UNKNOWN" ]; then
> > +      oe_runmake host_linux
> > +  fi
> > +}
> 
> I don't think checking PLATFORM above and below is necessary - you set strict
> COMPATIBLE_MACHINE filter and set all possible variants of PLATFORM var
> below.
> Even if something is not defined, let if fail with UNKNOWN setting, instead of
> succeeding and not building anything...
>

Ok. I can remote PLATFORM check and handle using COMPATIBLE MACHINE.
I will send updated patch.
 
> 
> > +do_install() {
> > +  if [  "${PLATFORM}" != "UNKNOWN" ]; then
> > +    oe_runmake EXEC_DIR="${D}${bindir}" install_linux_bin
> > +  fi
> > +}
> > +
> > +PACKAGES =+ "${PN}-firmware"
> > +FILES_${PN}-firmware +=
> "${bindir}/simple_buffer_example/release/server_dsp.xe66"
> > +INSANE_SKIP_${PN}-firmware += "arch"
> > diff --git a/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-
> demo.inc b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-
> demo.inc
> > new file mode 100644
> > index 0000000..c3f8f38
> > --- /dev/null
> > +++ b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-
> demo.inc
> > @@ -0,0 +1,39 @@
> > +LICENSE = "BSD-3-Clause"
> > +LIC_FILES_CHKSUM =
> "file://makefile;beginline=1;endline=31;md5=2f2ea348b98d5cc7807ece7ad
> cc2c43a"
> > +
> > +COMPATIBLE_MACHINE = "omap-a15|keystone"
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > +
> > +BIG_DATA_IPC_GIT_URI = "git://git.ti.com/processor-sdk/big-data-ipc-
> examples.git"
> > +BIG_DATA_IPC_GIT_PROTOCOL = "git"
> > +BIG_DATA_IPC_GIT_BRANCH = "master"
> > +
> > +# Below commit ID corresponds to "DEV.BIG_DATA_IPC.01.01.00.00"
> > +BIG_DATA_IPC_SRCREV =
> "5907bff5a29fe2ba8719ae8c3c5d62b20b7b6bc9"
> > +
> > +BRANCH = "${BIG_DATA_IPC_GIT_BRANCH}"
> > +SRC_URI =
> "${BIG_DATA_IPC_GIT_URI};protocol=${BIG_DATA_IPC_GIT_PROTOCOL};bran
> ch=${BRANCH}"
> > +
> > +SRCREV = "${BIG_DATA_IPC_SRCREV}"
> > +PV = "01.01.00.00"
> 
> Kind of strange split - usually common pieces are in .inc and version-specific
> are in .bb file. Here you set SRCREV and PV in .inc file... Any reason?

This is in anticipation of a  big-data-ipc-demo-bios package from same git repo coming up soon.
(Waiting for some dependencies to be upstream first)

> 
> 
> > +S = "${WORKDIR}/git"
> > +
> > +PLATFORM = "UNKNOWN"
> > +PLATFORM_omap-a15 = "DRA7XX"
> > +PLATFORM_k2hk-evm = "TCI6636"
> > +PLATFORM_k2l-evm = "TCI6630"
> > +PLATFORM_k2e = "66AK2E"
> > +PLATFORM_k2g = "66AK2G"
> > +
> > +IPC_TARGETS = ""
> > +IPC_TARGETS_omap-a15 = "\
> > +    gnu.targets.arm.A15F="${GCC_ARM_NONE_TOOLCHAIN}" \
> > +    ti.targets.elf.C66="${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x" \
> > +    ti.targets.arm.elf.M4="${M4_TOOLCHAIN_INSTALL_DIR}" \
> > +"
> > +
> > +IPC_TARGETS_keystone = " \
> > +    gnu.targets.arm.A15F="${GCC_ARM_NONE_TOOLCHAIN}" \
> > +    ti.targets.elf.C66="${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x" \
> > +"
> > --
> > 1.9.1
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [morty/master][PATCH v3 2/2] arago-tisdk-addons: Add big-data-ipc-demo for host linux
  2017-06-26 18:47   ` Denys Dmytriyenko
@ 2017-06-26 19:00     ` Nelson, Sam
  0 siblings, 0 replies; 7+ messages in thread
From: Nelson, Sam @ 2017-06-26 19:00 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org



> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Monday, June 26, 2017 2:47 PM
> To: Nelson, Sam
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [morty/master][PATCH v3 2/2] arago-tisdk-addons:
> Add big-data-ipc-demo for host linux
> 
> On Mon, Jun 26, 2017 at 01:43:17PM -0400, Sam Nelson wrote:
> > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > ---
> >  .../recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb  |
> > 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
> > k-addons.bb
> > b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
> > k-addons.bb
> > index c623b37..360890b 100644
> > ---
> > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisd
> > k-addons.bb
> > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> > +++ tisdk-addons.bb
> > @@ -1,6 +1,6 @@
> >  DESCRIPTION = "Task to install additional utilities/demos for SDKs"
> >  LICENSE = "MIT"
> > -PR = "r60"
> > +PR = "r61"
> >
> >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> >
> > @@ -119,7 +119,10 @@ EXTRA_PACKAGES_omapl138 = " \
> >
> >  EXTRA_PACKAGES_append_ti33x = " voxelsdk"
> >  EXTRA_PACKAGES_append_ti43x = " voxelsdk"
> > -EXTRA_PACKAGES_append_omap-a15 = " voxelsdk"
> > +EXTRA_PACKAGES_append_omap-a15 = " voxelsdk \
> > +                                   big-data-ipc-demo-linux \
> > +                                   big-data-ipc-demo-linux-firmware \
> > +"
> 
> I only see you are adding it for omap-a15, but not keystone - on purpose?

Yes. Currently the support is only for omap-a15.  Keystone will be added soon.

> 
> 
> >  EXTRA_PACKAGES_append_omap-a15 = " ti-ipc-examples-linux"
> >  EXTRA_PACKAGES_append_keystone = " ti-ipc-examples-linux"
> > --
> > 1.9.1
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange
  2017-06-26 18:59   ` Nelson, Sam
@ 2017-06-26 19:05     ` Denys Dmytriyenko
  0 siblings, 0 replies; 7+ messages in thread
From: Denys Dmytriyenko @ 2017-06-26 19:05 UTC (permalink / raw)
  To: Nelson, Sam; +Cc: meta-arago@arago-project.org

On Mon, Jun 26, 2017 at 02:59:58PM -0400, Nelson, Sam wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Monday, June 26, 2017 2:47 PM
> > To: Nelson, Sam
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [morty/master][PATCH v3 1/2] big-data-ipc-demo:
> > Add ipc examples for big data buffer exchange
> > 
> > Thanks, Sam, looks reasonable.
> > 
> > Few non-critical comments - let me know if you want to fix them and re-
> > submit, or I can merge as is and if needed, address them later as a follow up.
> > 
> > 
> > On Mon, Jun 26, 2017 at 01:43:16PM -0400, Sam Nelson wrote:
> > > Adds example with host running linux
> > > Demonstrates transfer of Big data buffers between A15 host and DSP core
> > >
> > > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > >
> > > ---
> > > Change from previous version of patch
> > > - Expand to am57xx-evm to omap-a15
> > > - Remove ti-staging.inc
> > > ---
> > > ---
> > >  .../big-data-ipc-demo-linux_git.bb                 | 41
> > ++++++++++++++++++++++
> > >  .../big-data-ipc-demo/big-data-ipc-demo.inc        | 39
> > ++++++++++++++++++++
> > >  2 files changed, 80 insertions(+)
> > >  create mode 100644 meta-arago-extras/recipes-apps/big-data-ipc-
> > demo/big-data-ipc-demo-linux_git.bb
> > >  create mode 100644 meta-arago-extras/recipes-apps/big-data-ipc-
> > demo/big-data-ipc-demo.inc
> > >
> > > diff --git a/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-
> > demo-linux_git.bb b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-
> > data-ipc-demo-linux_git.bb
> > > new file mode 100644
> > > index 0000000..0734177
> > > --- /dev/null
> > > +++ b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-
> > demo-linux_git.bb
> > > @@ -0,0 +1,41 @@
> > > +SUMMARY = "TI Big data IPC: Host linux examples"
> > > +
> > > +require recipes-ti/includes/ti-paths.inc
> > > +require big-data-ipc-demo.inc
> > > +
> > > +DEPENDS = "ti-ipc \
> > > +           ti-xdctools \
> > > +           ti-sysbios \
> > > +           ti-ipc-rtos \
> > > +           cmem \
> > > +"
> > > +
> > > +EXTRA_OEMAKE = "\
> > > +    PLATFORM=${PLATFORM} \
> > > +    XDC_INSTALL_DIR="${XDC_INSTALL_DIR}" \
> > > +    BIOS_INSTALL_DIR="${SYSBIOS_INSTALL_DIR}" \
> > > +    IPC_INSTALL_DIR="${IPC_INSTALL_DIR}" \
> > > +    LINUX_SYSROOT_DIR="${STAGING_INCDIR}" \
> > > +    ${IPC_TARGETS} \
> > > +    JOBS="${PARALLEL_MAKE}" \
> > > +"
> > > +
> > > +do_create_srcipk_prepend() {
> > > +  rm -rf host_bios
> > > +}
> > > +
> > > +do_compile() {
> > > +  if [  "${PLATFORM}" != "UNKNOWN" ]; then
> > > +      oe_runmake host_linux
> > > +  fi
> > > +}
> > 
> > I don't think checking PLATFORM above and below is necessary - you set strict
> > COMPATIBLE_MACHINE filter and set all possible variants of PLATFORM var
> > below.
> > Even if something is not defined, let if fail with UNKNOWN setting, instead of
> > succeeding and not building anything...
> >
> 
> Ok. I can remote PLATFORM check and handle using COMPATIBLE MACHINE.
> I will send updated patch.

Thanks, Sam. I'm currently queueing up patches for morty-next I'm about to 
start, so since this is the only minor thing needing change, I'll merge it as 
is and you can update do_compile() and do_install() here later, when you 
follow up with bios/keystone updates.


> > > +do_install() {
> > > +  if [  "${PLATFORM}" != "UNKNOWN" ]; then
> > > +    oe_runmake EXEC_DIR="${D}${bindir}" install_linux_bin
> > > +  fi
> > > +}
> > > +
> > > +PACKAGES =+ "${PN}-firmware"
> > > +FILES_${PN}-firmware +=
> > "${bindir}/simple_buffer_example/release/server_dsp.xe66"
> > > +INSANE_SKIP_${PN}-firmware += "arch"
> > > diff --git a/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-
> > demo.inc b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-
> > demo.inc
> > > new file mode 100644
> > > index 0000000..c3f8f38
> > > --- /dev/null
> > > +++ b/meta-arago-extras/recipes-apps/big-data-ipc-demo/big-data-ipc-
> > demo.inc
> > > @@ -0,0 +1,39 @@
> > > +LICENSE = "BSD-3-Clause"
> > > +LIC_FILES_CHKSUM =
> > "file://makefile;beginline=1;endline=31;md5=2f2ea348b98d5cc7807ece7ad
> > cc2c43a"
> > > +
> > > +COMPATIBLE_MACHINE = "omap-a15|keystone"
> > > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> > > +
> > > +BIG_DATA_IPC_GIT_URI = "git://git.ti.com/processor-sdk/big-data-ipc-
> > examples.git"
> > > +BIG_DATA_IPC_GIT_PROTOCOL = "git"
> > > +BIG_DATA_IPC_GIT_BRANCH = "master"
> > > +
> > > +# Below commit ID corresponds to "DEV.BIG_DATA_IPC.01.01.00.00"
> > > +BIG_DATA_IPC_SRCREV =
> > "5907bff5a29fe2ba8719ae8c3c5d62b20b7b6bc9"
> > > +
> > > +BRANCH = "${BIG_DATA_IPC_GIT_BRANCH}"
> > > +SRC_URI =
> > "${BIG_DATA_IPC_GIT_URI};protocol=${BIG_DATA_IPC_GIT_PROTOCOL};bran
> > ch=${BRANCH}"
> > > +
> > > +SRCREV = "${BIG_DATA_IPC_SRCREV}"
> > > +PV = "01.01.00.00"
> > 
> > Kind of strange split - usually common pieces are in .inc and version-specific
> > are in .bb file. Here you set SRCREV and PV in .inc file... Any reason?
> 
> This is in anticipation of a  big-data-ipc-demo-bios package from same git repo coming up soon.
> (Waiting for some dependencies to be upstream first)
> 
> > 
> > 
> > > +S = "${WORKDIR}/git"
> > > +
> > > +PLATFORM = "UNKNOWN"
> > > +PLATFORM_omap-a15 = "DRA7XX"
> > > +PLATFORM_k2hk-evm = "TCI6636"
> > > +PLATFORM_k2l-evm = "TCI6630"
> > > +PLATFORM_k2e = "66AK2E"
> > > +PLATFORM_k2g = "66AK2G"
> > > +
> > > +IPC_TARGETS = ""
> > > +IPC_TARGETS_omap-a15 = "\
> > > +    gnu.targets.arm.A15F="${GCC_ARM_NONE_TOOLCHAIN}" \
> > > +    ti.targets.elf.C66="${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x" \
> > > +    ti.targets.arm.elf.M4="${M4_TOOLCHAIN_INSTALL_DIR}" \
> > > +"
> > > +
> > > +IPC_TARGETS_keystone = " \
> > > +    gnu.targets.arm.A15F="${GCC_ARM_NONE_TOOLCHAIN}" \
> > > +    ti.targets.elf.C66="${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x" \
> > > +"
> > > --
> > > 1.9.1
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-06-26 19:05 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-26 17:43 [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange Sam Nelson
2017-06-26 17:43 ` [morty/master][PATCH v3 2/2] arago-tisdk-addons: Add big-data-ipc-demo for host linux Sam Nelson
2017-06-26 18:47   ` Denys Dmytriyenko
2017-06-26 19:00     ` Nelson, Sam
2017-06-26 18:46 ` [morty/master][PATCH v3 1/2] big-data-ipc-demo: Add ipc examples for big data buffer exchange Denys Dmytriyenko
2017-06-26 18:59   ` Nelson, Sam
2017-06-26 19:05     ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.