All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linu Cherian <linuc.decode@gmail.com>
To: Will Deacon <will.deacon@arm.com>
Cc: salil.mehta@huawei.com, sunil.goutham@cavium.com,
	thunder.leizhen@huawei.com, joro@8bytes.org,
	john.garry@huawei.com, iommu@lists.linux-foundation.org,
	wangzhou1@hisilicon.com, ray.jui@broadcom.com,
	nwatters@codeaurora.org, Linu Cherian <linu.cherian@cavium.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/8] iommu/io-pgtable-arm: Support lockless operation
Date: Tue, 27 Jun 2017 14:38:24 +0530	[thread overview]
Message-ID: <20170627090824.GA2758@virtx40> (raw)
In-Reply-To: <20170627083912.GA5759@arm.com>

On Tue Jun 27, 2017 at 09:39:13AM +0100, Will Deacon wrote:
> On Tue, Jun 27, 2017 at 10:41:55AM +0530, Linu Cherian wrote:
> > On Fri Jun 23, 2017 at 05:04:05PM +0530, Linu Cherian wrote:
> > > On Fri Jun 23, 2017 at 11:35:25AM +0100, Robin Murphy wrote:
> > > > Note that on a coherent platform like ThunderX that's as good as just
> > > > deleting it, because you'll never execute the case below. However, on
> > > > reflection I think it can at least safely be downgraded to dma_wmb()
> > > > (i.e. DMB) rather than a full DSB - would you be able to test what
> > > > difference that makes?
> > > 
> > > The testing was done on Thunderx 1, which has a non coherent page table walk.
> > > Yes, downgrading to dma_wmb() helps. With this change, performance is back to v1.
> > > 
> > 
> > Should i send a patch for this ?
> 
> I already did it:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/commit/?h=for-joerg/arm-smmu/updates&id=77f3445866c39d8866b31d8d9fa47c7c20938e05
> 
> Will
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Thanks Will.

-- 
Linu cherian

WARNING: multiple messages have this Message-ID (diff)
From: linuc.decode@gmail.com (Linu Cherian)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/8] iommu/io-pgtable-arm: Support lockless operation
Date: Tue, 27 Jun 2017 14:38:24 +0530	[thread overview]
Message-ID: <20170627090824.GA2758@virtx40> (raw)
In-Reply-To: <20170627083912.GA5759@arm.com>

On Tue Jun 27, 2017 at 09:39:13AM +0100, Will Deacon wrote:
> On Tue, Jun 27, 2017 at 10:41:55AM +0530, Linu Cherian wrote:
> > On Fri Jun 23, 2017 at 05:04:05PM +0530, Linu Cherian wrote:
> > > On Fri Jun 23, 2017 at 11:35:25AM +0100, Robin Murphy wrote:
> > > > Note that on a coherent platform like ThunderX that's as good as just
> > > > deleting it, because you'll never execute the case below. However, on
> > > > reflection I think it can at least safely be downgraded to dma_wmb()
> > > > (i.e. DMB) rather than a full DSB - would you be able to test what
> > > > difference that makes?
> > > 
> > > The testing was done on Thunderx 1, which has a non coherent page table walk.
> > > Yes, downgrading to dma_wmb() helps. With this change, performance is back to v1.
> > > 
> > 
> > Should i send a patch for this ?
> 
> I already did it:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/commit/?h=for-joerg/arm-smmu/updates&id=77f3445866c39d8866b31d8d9fa47c7c20938e05
> 
> Will
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Thanks Will.

-- 
Linu cherian

  reply	other threads:[~2017-06-27  9:08 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 15:53 [PATCH v2 0/8] io-pgtable lock removal Robin Murphy
2017-06-22 15:53 ` Robin Murphy
     [not found] ` <cover.1498145008.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2017-06-22 15:53   ` [PATCH v2 1/8] iommu/io-pgtable-arm-v7s: Check table PTEs more precisely Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 2/8] iommu/io-pgtable-arm: Improve split_blk_unmap Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 3/8] iommu/io-pgtable-arm-v7s: Refactor split_blk_unmap Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 4/8] iommu/io-pgtable: Introduce explicit coherency Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 5/8] iommu/io-pgtable-arm: Support lockless operation Robin Murphy
2017-06-22 15:53     ` Robin Murphy
     [not found]     ` <af61929e3984a31588cab08ed84a237602b5263e.1498145008.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2017-06-23  5:53       ` Linu Cherian
2017-06-23  5:53         ` Linu Cherian
2017-06-23  8:56         ` Linu Cherian
2017-06-23  8:56           ` Linu Cherian
2017-06-23 10:35           ` Robin Murphy
2017-06-23 10:35             ` Robin Murphy
     [not found]             ` <7a8da378-19e2-2f35-877a-cc6ce389301a-5wv7dgnIgG8@public.gmane.org>
2017-06-23 11:34               ` Linu Cherian
2017-06-23 11:34                 ` Linu Cherian
2017-06-27  5:11                 ` Linu Cherian
2017-06-27  5:11                   ` Linu Cherian
2017-06-27  8:39                   ` Will Deacon
2017-06-27  8:39                     ` Will Deacon
2017-06-27  9:08                     ` Linu Cherian [this message]
2017-06-27  9:08                       ` Linu Cherian
2017-06-22 15:53   ` [PATCH v2 6/8] iommu/io-pgtable-arm-v7s: " Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 7/8] iommu/arm-smmu: Remove io-pgtable spinlock Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 8/8] iommu/arm-smmu-v3: " Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-23  8:47   ` [PATCH v2 0/8] io-pgtable lock removal John Garry
2017-06-23  8:47     ` John Garry
     [not found]     ` <61b7b953-5bf4-eb45-c3e8-b4491e8fdca7-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-06-23  9:58       ` Robin Murphy
2017-06-23  9:58         ` Robin Murphy
2017-06-26 11:35         ` John Garry
2017-06-26 11:35           ` John Garry
     [not found]           ` <9bbf18c7-34ba-6e94-53bd-3f75059c1bb2-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-06-26 12:31             ` Robin Murphy
2017-06-26 12:31               ` Robin Murphy
2017-06-26 13:12               ` John Garry
2017-06-26 13:12                 ` John Garry
     [not found]                 ` <15e7ce0a-bf4b-cc77-3600-c37ed865a4d7-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-06-26 13:19                   ` Leizhen (ThunderTown)
2017-06-26 13:19                     ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170627090824.GA2758@virtx40 \
    --to=linuc.decode@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=john.garry@huawei.com \
    --cc=joro@8bytes.org \
    --cc=linu.cherian@cavium.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=nwatters@codeaurora.org \
    --cc=ray.jui@broadcom.com \
    --cc=robin.murphy@arm.com \
    --cc=salil.mehta@huawei.com \
    --cc=sunil.goutham@cavium.com \
    --cc=thunder.leizhen@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.