All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Leizhen (ThunderTown)" <thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: John Garry <john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org
Cc: sunil.goutham-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
	linu.cherian-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
	Linuxarm <linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	Shameerali Kolothum Thodi
	<shameerali.kolothum.thodi-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	ray.jui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	Hanjun Guo <guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 0/8] io-pgtable lock removal
Date: Mon, 26 Jun 2017 21:19:40 +0800	[thread overview]
Message-ID: <595109EC.5000201@huawei.com> (raw)
In-Reply-To: <15e7ce0a-bf4b-cc77-3600-c37ed865a4d7-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>



On 2017/6/26 21:12, John Garry wrote:
> 
>>>
>>> I saw Will has already sent the pull request. But, FWIW, we are seeing
>>> roughly the same performance as v1 patchset. For PCI NIC, Zhou again
>>> found performance drop goes from ~15->8% with SMMU enabled, and for
>>> integrated storage controller [platform device], we still see a drop of
>>> about 50%, depending on datarates (Leizhen has been working on fixing
>>> this).
>>
>> Thanks for confirming. Following Joerg's suggestion that the storage
>> workloads may still depend on rbtree performance - it had slipped my
>> mind that even with small block sizes those could well be grouped into
>> scatterlists large enough to trigger a >64-page IOVA allocation - I've
>> taken the liberty of cooking up a simplified version of Leizhen's rbtree
>> optimisation series in the iommu/iova branch of my tree. I'll follow up
>> on that after the merge window, but if anyone wants to play with it in
>> the meantime feel free.
The main problem is lock confliction of cmd queue. I have prepared my patchset,
I will send it later.

> 
> Just a reminder that we did also see poor performance with our integrated NIC on your v1 patchset also (I can push for v2 patchset testing, but expect the same).
> 
> We might be able to now include a LSI 3108 PCI SAS card in our testing also to give a broader set of results.
> 
> John
> 
>>
>> Robin.
>>
>> .
>>
> 
> 
> 
> .
> 

-- 
Thanks!
BestRegards

WARNING: multiple messages have this Message-ID (diff)
From: thunder.leizhen@huawei.com (Leizhen (ThunderTown))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/8] io-pgtable lock removal
Date: Mon, 26 Jun 2017 21:19:40 +0800	[thread overview]
Message-ID: <595109EC.5000201@huawei.com> (raw)
In-Reply-To: <15e7ce0a-bf4b-cc77-3600-c37ed865a4d7@huawei.com>



On 2017/6/26 21:12, John Garry wrote:
> 
>>>
>>> I saw Will has already sent the pull request. But, FWIW, we are seeing
>>> roughly the same performance as v1 patchset. For PCI NIC, Zhou again
>>> found performance drop goes from ~15->8% with SMMU enabled, and for
>>> integrated storage controller [platform device], we still see a drop of
>>> about 50%, depending on datarates (Leizhen has been working on fixing
>>> this).
>>
>> Thanks for confirming. Following Joerg's suggestion that the storage
>> workloads may still depend on rbtree performance - it had slipped my
>> mind that even with small block sizes those could well be grouped into
>> scatterlists large enough to trigger a >64-page IOVA allocation - I've
>> taken the liberty of cooking up a simplified version of Leizhen's rbtree
>> optimisation series in the iommu/iova branch of my tree. I'll follow up
>> on that after the merge window, but if anyone wants to play with it in
>> the meantime feel free.
The main problem is lock confliction of cmd queue. I have prepared my patchset,
I will send it later.

> 
> Just a reminder that we did also see poor performance with our integrated NIC on your v1 patchset also (I can push for v2 patchset testing, but expect the same).
> 
> We might be able to now include a LSI 3108 PCI SAS card in our testing also to give a broader set of results.
> 
> John
> 
>>
>> Robin.
>>
>> .
>>
> 
> 
> 
> .
> 

-- 
Thanks!
BestRegards

  parent reply	other threads:[~2017-06-26 13:19 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 15:53 [PATCH v2 0/8] io-pgtable lock removal Robin Murphy
2017-06-22 15:53 ` Robin Murphy
     [not found] ` <cover.1498145008.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2017-06-22 15:53   ` [PATCH v2 1/8] iommu/io-pgtable-arm-v7s: Check table PTEs more precisely Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 2/8] iommu/io-pgtable-arm: Improve split_blk_unmap Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 3/8] iommu/io-pgtable-arm-v7s: Refactor split_blk_unmap Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 4/8] iommu/io-pgtable: Introduce explicit coherency Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 5/8] iommu/io-pgtable-arm: Support lockless operation Robin Murphy
2017-06-22 15:53     ` Robin Murphy
     [not found]     ` <af61929e3984a31588cab08ed84a237602b5263e.1498145008.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2017-06-23  5:53       ` Linu Cherian
2017-06-23  5:53         ` Linu Cherian
2017-06-23  8:56         ` Linu Cherian
2017-06-23  8:56           ` Linu Cherian
2017-06-23 10:35           ` Robin Murphy
2017-06-23 10:35             ` Robin Murphy
     [not found]             ` <7a8da378-19e2-2f35-877a-cc6ce389301a-5wv7dgnIgG8@public.gmane.org>
2017-06-23 11:34               ` Linu Cherian
2017-06-23 11:34                 ` Linu Cherian
2017-06-27  5:11                 ` Linu Cherian
2017-06-27  5:11                   ` Linu Cherian
2017-06-27  8:39                   ` Will Deacon
2017-06-27  8:39                     ` Will Deacon
2017-06-27  9:08                     ` Linu Cherian
2017-06-27  9:08                       ` Linu Cherian
2017-06-22 15:53   ` [PATCH v2 6/8] iommu/io-pgtable-arm-v7s: " Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 7/8] iommu/arm-smmu: Remove io-pgtable spinlock Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-22 15:53   ` [PATCH v2 8/8] iommu/arm-smmu-v3: " Robin Murphy
2017-06-22 15:53     ` Robin Murphy
2017-06-23  8:47   ` [PATCH v2 0/8] io-pgtable lock removal John Garry
2017-06-23  8:47     ` John Garry
     [not found]     ` <61b7b953-5bf4-eb45-c3e8-b4491e8fdca7-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-06-23  9:58       ` Robin Murphy
2017-06-23  9:58         ` Robin Murphy
2017-06-26 11:35         ` John Garry
2017-06-26 11:35           ` John Garry
     [not found]           ` <9bbf18c7-34ba-6e94-53bd-3f75059c1bb2-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-06-26 12:31             ` Robin Murphy
2017-06-26 12:31               ` Robin Murphy
2017-06-26 13:12               ` John Garry
2017-06-26 13:12                 ` John Garry
     [not found]                 ` <15e7ce0a-bf4b-cc77-3600-c37ed865a4d7-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-06-26 13:19                   ` Leizhen (ThunderTown) [this message]
2017-06-26 13:19                     ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=595109EC.5000201@huawei.com \
    --to=thunder.leizhen-hv44wf8li93qt0dzr+alfa@public.gmane.org \
    --cc=guohanjun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=john.garry-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=linu.cherian-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=ray.jui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
    --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
    --cc=shameerali.kolothum.thodi-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=sunil.goutham-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
    --cc=wangzhou1-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.