From: clabbe.montjoie@gmail.com (Corentin Labbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] net: stmmac: support future possible different internal phy mode
Date: Thu, 29 Jun 2017 19:02:38 +0200 [thread overview]
Message-ID: <20170629170238.GA2606@Red> (raw)
In-Reply-To: <20170629.122349.2265868886957558079.davem@davemloft.net>
On Thu, Jun 29, 2017 at 12:23:49PM -0400, David Miller wrote:
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
> Date: Tue, 27 Jun 2017 11:28:01 +0200
>
> > The current way to find if the phy is internal is to compare DT phy-mode
> > and emac_variant/internal_phy.
> > But it will negate a possible future SoC where an external PHY use the
> > same phy mode than the internal one.
> >
> > By using phy-mode = "internal" we permit to have an external PHY with
> > the same mode than the internal one.
> >
> > Reported-by: Andr? Przywara <andre.przywara@arm.com>
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Series applied.
>
> Please provide a proper "[PATCH 0/n] " header posting next time.
Sorry could you wait for applying, there are a parallel thread (http://www.spinics.net/lists/devicetree/msg183520.html) and it seems finaly that internal could not be the good way to do it.
Regards
Sorry again, I should have sent a comment for waiting.
WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org,
peppe.cavallaro-qxv4g6HH51o@public.gmane.org,
alexandre.torgue-qxv4g6HH51o@public.gmane.org,
andre.przywara-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode
Date: Thu, 29 Jun 2017 19:02:38 +0200 [thread overview]
Message-ID: <20170629170238.GA2606@Red> (raw)
In-Reply-To: <20170629.122349.2265868886957558079.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On Thu, Jun 29, 2017 at 12:23:49PM -0400, David Miller wrote:
> From: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date: Tue, 27 Jun 2017 11:28:01 +0200
>
> > The current way to find if the phy is internal is to compare DT phy-mode
> > and emac_variant/internal_phy.
> > But it will negate a possible future SoC where an external PHY use the
> > same phy mode than the internal one.
> >
> > By using phy-mode = "internal" we permit to have an external PHY with
> > the same mode than the internal one.
> >
> > Reported-by: André Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>
> > Signed-off-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Series applied.
>
> Please provide a proper "[PATCH 0/n] " header posting next time.
Sorry could you wait for applying, there are a parallel thread (http://www.spinics.net/lists/devicetree/msg183520.html) and it seems finaly that internal could not be the good way to do it.
Regards
Sorry again, I should have sent a comment for waiting.
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
maxime.ripard@free-electrons.com, wens@csie.org,
peppe.cavallaro@st.com, alexandre.torgue@st.com,
andre.przywara@arm.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode
Date: Thu, 29 Jun 2017 19:02:38 +0200 [thread overview]
Message-ID: <20170629170238.GA2606@Red> (raw)
In-Reply-To: <20170629.122349.2265868886957558079.davem@davemloft.net>
On Thu, Jun 29, 2017 at 12:23:49PM -0400, David Miller wrote:
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
> Date: Tue, 27 Jun 2017 11:28:01 +0200
>
> > The current way to find if the phy is internal is to compare DT phy-mode
> > and emac_variant/internal_phy.
> > But it will negate a possible future SoC where an external PHY use the
> > same phy mode than the internal one.
> >
> > By using phy-mode = "internal" we permit to have an external PHY with
> > the same mode than the internal one.
> >
> > Reported-by: André Przywara <andre.przywara@arm.com>
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> Series applied.
>
> Please provide a proper "[PATCH 0/n] " header posting next time.
Sorry could you wait for applying, there are a parallel thread (http://www.spinics.net/lists/devicetree/msg183520.html) and it seems finaly that internal could not be the good way to do it.
Regards
Sorry again, I should have sent a comment for waiting.
next prev parent reply other threads:[~2017-06-29 17:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 9:28 [PATCH 1/6] net: stmmac: support future possible different internal phy mode Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` [PATCH 2/6] arm: sun8i: orangepipc: use internal phy-mode Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` [PATCH 3/6] arm: sun8i: orangepi-zero: " Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` [PATCH 4/6] arm: sun8i: orangepi-one: " Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` [PATCH 5/6] arm: sun8i: nanopi-neo: " Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` [PATCH 6/6] arm: sun8i: orangepi-2: " Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-27 9:28 ` Corentin Labbe
2017-06-29 16:23 ` [PATCH 1/6] net: stmmac: support future possible different internal phy mode David Miller
2017-06-29 16:23 ` David Miller
2017-06-29 16:46 ` [linux-sunxi] " icenowy at aosc.io
2017-06-29 16:46 ` icenowy
2017-06-29 16:46 ` icenowy-h8G6r0blFSE
2017-06-29 17:02 ` Corentin Labbe [this message]
2017-06-29 17:02 ` Corentin Labbe
2017-06-29 17:02 ` Corentin Labbe
2017-06-29 20:05 ` David Miller
2017-06-29 20:05 ` David Miller
2017-06-29 20:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629170238.GA2606@Red \
--to=clabbe.montjoie@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.