* [PATCH] Remove redundant memclear
@ 2017-06-30 3:56 coypu
2017-07-07 12:34 ` Eric Engestrom
0 siblings, 1 reply; 2+ messages in thread
From: coypu @ 2017-06-30 3:56 UTC (permalink / raw)
To: dri-devel
drmMalloc will zero out the memory for us
---
xf86drm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/xf86drm.c b/xf86drm.c
index 2ac3f26..879f85b 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -866,8 +866,6 @@ drmVersionPtr drmGetVersion(int fd)
drmVersionPtr retval;
drm_version_t *version = drmMalloc(sizeof(*version));
- memclear(*version);
-
if (drmIoctl(fd, DRM_IOCTL_VERSION, version)) {
drmFreeKernelVersion(version);
return NULL;
--
2.13.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove redundant memclear
2017-06-30 3:56 [PATCH] Remove redundant memclear coypu
@ 2017-07-07 12:34 ` Eric Engestrom
0 siblings, 0 replies; 2+ messages in thread
From: Eric Engestrom @ 2017-07-07 12:34 UTC (permalink / raw)
To: coypu; +Cc: dri-devel
On Friday, 2017-06-30 03:56:55 +0000, coypu wrote:
> drmMalloc will zero out the memory for us
Good catch, thanks!
R-b and pushed.
In the future, can you provide your real name, and add a Signed-off-by: line?
Cheers,
Eric
> ---
> xf86drm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/xf86drm.c b/xf86drm.c
> index 2ac3f26..879f85b 100644
> --- a/xf86drm.c
> +++ b/xf86drm.c
> @@ -866,8 +866,6 @@ drmVersionPtr drmGetVersion(int fd)
> drmVersionPtr retval;
> drm_version_t *version = drmMalloc(sizeof(*version));
>
> - memclear(*version);
> -
> if (drmIoctl(fd, DRM_IOCTL_VERSION, version)) {
> drmFreeKernelVersion(version);
> return NULL;
> --
> 2.13.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-07 12:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-30 3:56 [PATCH] Remove redundant memclear coypu
2017-07-07 12:34 ` Eric Engestrom
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.