[PATCH] Remove redundant memclear

[PATCH] Remove redundant memclear

[coypu]

drmMalloc will zero out the memory for us
---
 xf86drm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/xf86drm.c b/xf86drm.c
index 2ac3f26..879f85b 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -866,8 +866,6 @@ drmVersionPtr drmGetVersion(int fd)
     drmVersionPtr retval;
     drm_version_t *version = drmMalloc(sizeof(*version));
 
-    memclear(*version);
-
     if (drmIoctl(fd, DRM_IOCTL_VERSION, version)) {
         drmFreeKernelVersion(version);
         return NULL;
-- 
2.13.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] Remove redundant memclear

[Eric Engestrom]

On Friday, 2017-06-30 03:56:55 +0000, coypu wrote:
> drmMalloc will zero out the memory for us

Good catch, thanks!
R-b and pushed.

In the future, can you provide your real name, and add a Signed-off-by: line?

Cheers,
  Eric

> ---
>  xf86drm.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/xf86drm.c b/xf86drm.c
> index 2ac3f26..879f85b 100644
> --- a/xf86drm.c
> +++ b/xf86drm.c
> @@ -866,8 +866,6 @@ drmVersionPtr drmGetVersion(int fd)
>      drmVersionPtr retval;
>      drm_version_t *version = drmMalloc(sizeof(*version));
>  
> -    memclear(*version);
> -
>      if (drmIoctl(fd, DRM_IOCTL_VERSION, version)) {
>          drmFreeKernelVersion(version);
>          return NULL;
> -- 
> 2.13.1
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel