From: Peter Xu <peterx@redhat.com>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: qemu-devel@nongnu.org, xen-devel@lists.xensource.com,
kevin.tian@intel.com, sstabellini@kernel.org, mst@redhat.com,
anthony.perard@citrix.com, marcel@redhat.com,
Chao Gao <chao.gao@intel.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] i386/msi: Correct mask of destination ID in MSI address
Date: Tue, 4 Jul 2017 10:31:34 +0800 [thread overview]
Message-ID: <20170704023134.GE32003@pxdev.xzpeter.org> (raw)
In-Reply-To: <1498715394-16402-2-git-send-email-tianyu.lan@intel.com>
On Thu, Jun 29, 2017 at 01:49:52AM -0400, Lan Tianyu wrote:
> From: Chao Gao <chao.gao@intel.com>
>
> According to SDM 10.11.1, only [19:12] bits of MSI address are
> Destination ID, change the mask to avoid ambiguity for VT-d spec
> has used the bit 4 to indicate a remappable interrupt request.
>
> Signed-off-by: Chao Gao <chao.gao@intel.com>
> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
> include/hw/i386/apic-msidef.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h
> index 8b4d4cc..420b411 100644
> --- a/include/hw/i386/apic-msidef.h
> +++ b/include/hw/i386/apic-msidef.h
> @@ -26,6 +26,6 @@
>
> #define MSI_ADDR_DEST_ID_SHIFT 12
> #define MSI_ADDR_DEST_IDX_SHIFT 4
> -#define MSI_ADDR_DEST_ID_MASK 0x00ffff0
> +#define MSI_ADDR_DEST_ID_MASK 0x000ff000
>
> #endif /* HW_APIC_MSIDEF_H */
> --
> 1.8.3.1
>
>
--
Peter Xu
WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: kevin.tian@intel.com, xen-devel@lists.xensource.com,
mst@redhat.com, qemu-devel@nongnu.org, marcel@redhat.com,
sstabellini@kernel.org, anthony.perard@citrix.com,
Chao Gao <chao.gao@intel.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] i386/msi: Correct mask of destination ID in MSI address
Date: Tue, 4 Jul 2017 10:31:34 +0800 [thread overview]
Message-ID: <20170704023134.GE32003@pxdev.xzpeter.org> (raw)
In-Reply-To: <1498715394-16402-2-git-send-email-tianyu.lan@intel.com>
On Thu, Jun 29, 2017 at 01:49:52AM -0400, Lan Tianyu wrote:
> From: Chao Gao <chao.gao@intel.com>
>
> According to SDM 10.11.1, only [19:12] bits of MSI address are
> Destination ID, change the mask to avoid ambiguity for VT-d spec
> has used the bit 4 to indicate a remappable interrupt request.
>
> Signed-off-by: Chao Gao <chao.gao@intel.com>
> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
> include/hw/i386/apic-msidef.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/apic-msidef.h b/include/hw/i386/apic-msidef.h
> index 8b4d4cc..420b411 100644
> --- a/include/hw/i386/apic-msidef.h
> +++ b/include/hw/i386/apic-msidef.h
> @@ -26,6 +26,6 @@
>
> #define MSI_ADDR_DEST_ID_SHIFT 12
> #define MSI_ADDR_DEST_IDX_SHIFT 4
> -#define MSI_ADDR_DEST_ID_MASK 0x00ffff0
> +#define MSI_ADDR_DEST_ID_MASK 0x000ff000
>
> #endif /* HW_APIC_MSIDEF_H */
> --
> 1.8.3.1
>
>
--
Peter Xu
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-07-04 2:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 5:49 [Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support Lan Tianyu
2017-06-29 5:49 ` Lan Tianyu
2017-06-29 5:49 ` [Qemu-devel] [PATCH 1/3] i386/msi: Correct mask of destination ID in MSI address Lan Tianyu
2017-06-29 5:49 ` Lan Tianyu
2017-06-30 13:49 ` [Qemu-devel] " Anthony PERARD
2017-06-30 13:49 ` Anthony PERARD
2017-07-04 2:31 ` Peter Xu [this message]
2017-07-04 2:31 ` [Qemu-devel] " Peter Xu
2017-06-29 5:49 ` [Qemu-devel] [PATCH 2/3] xen-pt: bind/unbind interrupt remapping format MSI Lan Tianyu
2017-06-29 5:49 ` Lan Tianyu
2017-06-30 15:48 ` [Qemu-devel] " Anthony PERARD
2017-06-30 15:48 ` Anthony PERARD
2017-07-04 1:52 ` [Qemu-devel] " Lan Tianyu
2017-07-04 1:52 ` Lan Tianyu
2017-06-29 5:49 ` [Qemu-devel] [PATCH 3/3] msi: Handle remappable format interrupt request Lan Tianyu
2017-06-29 5:49 ` Lan Tianyu
2017-06-30 15:52 ` [Qemu-devel] " Anthony PERARD
2017-06-30 15:52 ` Anthony PERARD
2017-07-06 23:50 ` [Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support no-reply
2017-07-06 23:50 ` no-reply
2017-07-07 0:02 ` Fam Zheng
2017-07-07 0:02 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704023134.GE32003@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=chao.gao@intel.com \
--cc=kevin.tian@intel.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=tianyu.lan@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.