From: Al Viro <viro@ZenIV.linux.org.uk>
To: Colin King <colin.king@canonical.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Sean Paul <seanpaul@chromium.org>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][drm-next] drm compat: ensure mode in drm_agp_info is being copied
Date: Tue, 04 Jul 2017 17:36:55 +0000 [thread overview]
Message-ID: <20170704173655.GX10672@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170704164822.20177-1-colin.king@canonical.com>
On Tue, Jul 04, 2017 at 05:48:21PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A recent compat change removed the copying of i32.mode from info.mode.
> Add it back in to fix this removal as we currently are leaking information
> from the stack.
>
> Detected by CoverityScan, CID#1449374 ("Unitialized scalar variable")
Folded and pushed out.
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Colin King <colin.king@canonical.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Sean Paul <seanpaul@chromium.org>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][drm-next] drm compat: ensure mode in drm_agp_info is being copied
Date: Tue, 4 Jul 2017 18:36:55 +0100 [thread overview]
Message-ID: <20170704173655.GX10672@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170704164822.20177-1-colin.king@canonical.com>
On Tue, Jul 04, 2017 at 05:48:21PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A recent compat change removed the copying of i32.mode from info.mode.
> Add it back in to fix this removal as we currently are leaking information
> from the stack.
>
> Detected by CoverityScan, CID#1449374 ("Unitialized scalar variable")
Folded and pushed out.
next prev parent reply other threads:[~2017-07-04 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 16:48 [PATCH][drm-next] drm compat: ensure mode in drm_agp_info is being copied Colin King
2017-07-04 16:48 ` Colin King
2017-07-04 16:48 ` Colin King
2017-07-04 17:36 ` Al Viro [this message]
2017-07-04 17:36 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170704173655.GX10672@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.