* [PATCH][drm-next] drm compat: ensure mode in drm_agp_info is being copied
@ 2017-07-04 16:48 ` Colin King
0 siblings, 0 replies; 5+ messages in thread
From: Colin King @ 2017-07-04 16:48 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, Sean Paul, David Airlie, dri-devel,
Al Viro
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
A recent compat change removed the copying of i32.mode from info.mode.
Add it back in to fix this removal as we currently are leaking information
from the stack.
Detected by CoverityScan, CID#1449374 ("Unitialized scalar variable")
Fixes: 2337f2272ee1 ("compat_drm: switch AGP compat ioctls to drm_ioctl_kernel()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/drm_ioc32.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c
index 340eccfe35a1..94acf5109235 100644
--- a/drivers/gpu/drm/drm_ioc32.c
+++ b/drivers/gpu/drm/drm_ioc32.c
@@ -648,6 +648,7 @@ static int compat_drm_agp_info(struct file *file, unsigned int cmd,
i32.agp_version_major = info.agp_version_major;
i32.agp_version_minor = info.agp_version_minor;
+ i32.mode = info.mode;
i32.aperture_base = info.aperture_base;
i32.aperture_size = info.aperture_size;
i32.memory_allowed = info.memory_allowed;
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH][drm-next] drm compat: ensure mode in drm_agp_info is being copied
@ 2017-07-04 16:48 ` Colin King
0 siblings, 0 replies; 5+ messages in thread
From: Colin King @ 2017-07-04 16:48 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, Sean Paul, David Airlie, dri-devel,
Al Viro
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
A recent compat change removed the copying of i32.mode from info.mode.
Add it back in to fix this removal as we currently are leaking information
from the stack.
Detected by CoverityScan, CID#1449374 ("Unitialized scalar variable")
Fixes: 2337f2272ee1 ("compat_drm: switch AGP compat ioctls to drm_ioctl_kernel()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/drm_ioc32.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c
index 340eccfe35a1..94acf5109235 100644
--- a/drivers/gpu/drm/drm_ioc32.c
+++ b/drivers/gpu/drm/drm_ioc32.c
@@ -648,6 +648,7 @@ static int compat_drm_agp_info(struct file *file, unsigned int cmd,
i32.agp_version_major = info.agp_version_major;
i32.agp_version_minor = info.agp_version_minor;
+ i32.mode = info.mode;
i32.aperture_base = info.aperture_base;
i32.aperture_size = info.aperture_size;
i32.memory_allowed = info.memory_allowed;
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH][drm-next] drm compat: ensure mode in drm_agp_info is being copied
@ 2017-07-04 16:48 ` Colin King
0 siblings, 0 replies; 5+ messages in thread
From: Colin King @ 2017-07-04 16:48 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, Sean Paul, David Airlie, dri-devel,
Al Viro
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
A recent compat change removed the copying of i32.mode from info.mode.
Add it back in to fix this removal as we currently are leaking information
from the stack.
Detected by CoverityScan, CID#1449374 ("Unitialized scalar variable")
Fixes: 2337f2272ee1 ("compat_drm: switch AGP compat ioctls to drm_ioctl_kernel()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/drm_ioc32.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c
index 340eccfe35a1..94acf5109235 100644
--- a/drivers/gpu/drm/drm_ioc32.c
+++ b/drivers/gpu/drm/drm_ioc32.c
@@ -648,6 +648,7 @@ static int compat_drm_agp_info(struct file *file, unsigned int cmd,
i32.agp_version_major = info.agp_version_major;
i32.agp_version_minor = info.agp_version_minor;
+ i32.mode = info.mode;
i32.aperture_base = info.aperture_base;
i32.aperture_size = info.aperture_size;
i32.memory_allowed = info.memory_allowed;
--
2.11.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH][drm-next] drm compat: ensure mode in drm_agp_info is being copied
2017-07-04 16:48 ` Colin King
@ 2017-07-04 17:36 ` Al Viro
-1 siblings, 0 replies; 5+ messages in thread
From: Al Viro @ 2017-07-04 17:36 UTC (permalink / raw)
To: Colin King
Cc: Daniel Vetter, Jani Nikula, Sean Paul, David Airlie, dri-devel,
kernel-janitors, linux-kernel
On Tue, Jul 04, 2017 at 05:48:21PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A recent compat change removed the copying of i32.mode from info.mode.
> Add it back in to fix this removal as we currently are leaking information
> from the stack.
>
> Detected by CoverityScan, CID#1449374 ("Unitialized scalar variable")
Folded and pushed out.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH][drm-next] drm compat: ensure mode in drm_agp_info is being copied
@ 2017-07-04 17:36 ` Al Viro
0 siblings, 0 replies; 5+ messages in thread
From: Al Viro @ 2017-07-04 17:36 UTC (permalink / raw)
To: Colin King
Cc: Daniel Vetter, Jani Nikula, Sean Paul, David Airlie, dri-devel,
kernel-janitors, linux-kernel
On Tue, Jul 04, 2017 at 05:48:21PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A recent compat change removed the copying of i32.mode from info.mode.
> Add it back in to fix this removal as we currently are leaking information
> from the stack.
>
> Detected by CoverityScan, CID#1449374 ("Unitialized scalar variable")
Folded and pushed out.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-04 17:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-04 16:48 [PATCH][drm-next] drm compat: ensure mode in drm_agp_info is being copied Colin King
2017-07-04 16:48 ` Colin King
2017-07-04 16:48 ` Colin King
2017-07-04 17:36 ` Al Viro
2017-07-04 17:36 ` Al Viro
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.